[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up
Todd Lipcon has submitted this change and it was merged. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. [KuduScanBatch::const_iterator] a minor clean-up More 'standardized' signature for the prefix increment operator. Added postfix increment operator. Changed the behavior of the equality/non-equality operators: along with current row index, also check whether iterators are built upon the same batch. Added units tests to cover the modified code. Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Reviewed-on: http://gerrit.cloudera.org:8080/3834 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M src/kudu/client/client-test.cc M src/kudu/client/scan_batch.h 2 files changed, 123 insertions(+), 7 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up
Todd Lipcon has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up
Kudu Jenkins has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2708/ -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3834 to look at the new patch set (#2). Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. [KuduScanBatch::const_iterator] a minor clean-up More 'standardized' signature for the prefix increment operator. Added postfix increment operator. Changed the behavior of the equality/non-equality operators: along with current row index, also check whether iterators are built upon the same batch. Added units tests to cover the modified code. Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 --- M src/kudu/client/client-test.cc M src/kudu/client/scan_batch.h 2 files changed, 123 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/3834/2 -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up
Alexey Serbin has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: (3 comments) Thank you for review. Will post an updated version soon. http://gerrit.cloudera.org:8080/#/c/3834/1/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 208: return (idx_ == other.idx_) && (batch_ == other.batch_); > nit: tabs oops In my .vimrc I have set expandtab set shiftwidth=2 set tabstop=2 I'm curious how it appeared. Line 211: return !this->operator==(other); > is there a difference between this and the more obvious-looking "!(*this == Sure, "!(*this == other)" is much more readable, thanks. Line 221: const KuduScanBatch* batch_; > maybe we should make this const (const KuduScanBatch* const batch_;) to enc Great point -- will change. -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up
Todd Lipcon has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3834/1/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 208: return (idx_ == other.idx_) && (batch_ == other.batch_); nit: tabs Line 211: return !this->operator==(other); is there a difference between this and the more obvious-looking "!(*this == other)"? Line 221: const KuduScanBatch* batch_; maybe we should make this const (const KuduScanBatch* const batch_;) to encourage the optimizer to be able to inline out the equality checks? -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up
Kudu Jenkins has posted comments on this change. Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2706/ -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [KuduScanBatch::const iterator] a minor clean-up
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3834 Change subject: [KuduScanBatch::const_iterator] a minor clean-up .. [KuduScanBatch::const_iterator] a minor clean-up More 'standardized' signature for the prefix increment operator. Added postfix increment operator. Changed the behavior of the equality/non-equality operators: along with current row index, also check whether iterators are built upon the same batch. Added units tests to cover the modified code. Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 --- M src/kudu/client/client-test.cc M src/kudu/client/scan_batch.h 2 files changed, 122 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/3834/1 -- To view, visit http://gerrit.cloudera.org:8080/3834 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3eeba46e5bc45c9dd7b96abad60173381d6c3e39 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin