[kudu-CR] [benchmarks] introduced insert loadgen tool

2016-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change.

Change subject: [benchmarks] introduced insert_loadgen tool
..


Patch Set 3:

> havent looked at the code yet, but from the description at the top
 > of the file this looks pretty similar to "insert-generated-rows".
 > Could we consolidate the functionality here?

Yes, sure.  I remember you mentioned that I was free to completely replace the 
insert-generated-rows, but it seemed to me that people might prefer to keep 
something some functionality from it.  E.g., unlimited number of rows to insert.

Will do.

-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] [benchmarks] introduced insert loadgen tool

2016-09-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change.

Change subject: [benchmarks] introduced insert_loadgen tool
..


Patch Set 3:

havent looked at the code yet, but from the description at the top of the file 
this looks pretty similar to "insert-generated-rows". Could we consolidate the 
functionality here?

-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] [benchmarks] introduced insert loadgen tool

2016-09-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4412

to look at the new patch set (#3).

Change subject: [benchmarks] introduced insert_loadgen tool
..

[benchmarks] introduced insert_loadgen tool

A new simple load generation tool which allows to measure performance
of the Kudu C++ client library in MANUAL_FLUSH and AUTO_FLUSH_BACKGROUND
modes for 'push-as-much-as-you-can' scenarios: the client generates
and pushes as much data to tablet servers as it can given the
parameters for buffering/batching.

Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
---
M src/kudu/benchmarks/CMakeLists.txt
A src/kudu/benchmarks/insert_loadgen.cc
2 files changed, 414 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4412/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] [benchmarks] introduced insert loadgen tool

2016-09-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: [benchmarks] introduced insert_loadgen tool
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/3421/

-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] [benchmarks] introduced insert loadgen tool

2016-09-13 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4412

to look at the new patch set (#2).

Change subject: [benchmarks] introduced insert_loadgen tool
..

[benchmarks] introduced insert_loadgen tool

A new simple load generation tool which allows to measure performance
of the Kudu C++ client library in MANUAL_FLUSH and AUTO_FLUSH_BACKGROUND
modes for 'push-as-much-as-you-can' scenarios: the client generates
and pushes as much data to tablet servers as it can given the
parameters for buffering/batching.

Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
---
M src/kudu/benchmarks/CMakeLists.txt
A src/kudu/benchmarks/insert_loadgen.cc
2 files changed, 413 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4412/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] [benchmarks] introduced insert loadgen tool

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: [benchmarks] introduced insert_loadgen tool
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3420/

-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] [benchmarks] introduced insert loadgen tool

2016-09-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4412

Change subject: [benchmarks] introduced insert_loadgen tool
..

[benchmarks] introduced insert_loadgen tool

A new simple load generation tool which allows to measure performance
of the Kudu C++ client library in MANUAL_FLUSH and AUTO_FLUSH_BACKGROUND
modes for 'push-as-much-as-you-can' scenarios: the client generates
and pushes as much data to tablet servers as it can given the
parameters for buffering/batching.

Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
---
M src/kudu/benchmarks/CMakeLists.txt
A src/kudu/benchmarks/insert_loadgen.cc
2 files changed, 414 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4412/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 


[kudu-CR] [benchmarks] introduced insert loadgen tool

2016-09-13 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: [benchmarks] introduced insert_loadgen tool
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3419/

-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No