[kudu-CR] [consensus queue] local peer is always healthy

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8709 )

Change subject: [consensus_queue] local peer is always healthy
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8709/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8709/2//COMMIT_MSG@7
PS2, Line 7: healthy
nit: can you also call it a viable voter here? In case it gets confused with 
Peer "HealthPB" healthy



--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 03:57:35 +
Gerrit-HasComments: Yes

[kudu-CR] [consensus queue] local peer is always healthy

[Alexey Serbin (Code Review)]

Hello Mike Percy, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8709

to look at the new patch set (#2).

Change subject: [consensus_queue] local peer is always healthy
..

[consensus_queue] local peer is always healthy

While iterating over peers in PeerMessageQueue::SafeToEvictUnlocked(),
assume that the leader is always a viable voter.  Prior to this patch,
the leader itself was not counted as a viable voter since the leader
does not update its own last_communication_time.

Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/8709/2
--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] [consensus queue] local peer is always healthy

[Andrew Wong (Code Review)]

Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8709 )

Change subject: [consensus_queue] local peer is always healthy
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8709/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/8709/1//COMMIT_MSG@12
PS1, Line 12: counter
nit: counted


http://gerrit.cloudera.org:8080/#/c/8709/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

http://gerrit.cloudera.org:8080/#/c/8709/1/src/kudu/consensus/consensus_queue.cc@420
PS1, Line 420: alive
nit: "local"? or: "This is the local peer, which is guaranteed to be viable."



--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Comment-Date: Fri, 01 Dec 2017 03:52:32 +
Gerrit-HasComments: Yes

[kudu-CR] [consensus queue] local peer is always healthy

[Alexey Serbin (Code Review)]

Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8709


Change subject: [consensus_queue] local peer is always healthy
..

[consensus_queue] local peer is always healthy

While iterating over peers in PeerMessageQueue::SafeToEvictUnlocked(),
assume the local peer is always healthy.  Otherwise, since the
last_communication_time is not updated by the leader, the leader itself
is not counter as a viable voter.

Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
---
M src/kudu/consensus/consensus_queue.cc
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/8709/1
--
To view, visit http://gerrit.cloudera.org:8080/8709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id200ec8e562e2b21c8eef09e7b38a8d85d23239c
Gerrit-Change-Number: 8709
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin