[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Adar Dembo has submitted this change and it was merged. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. [doxygen] made DESTDIR applicable for ninja builds Moved the DESTDIR parameter into the environment to make the 'doxygen' target buildable under ninja as well. Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Reviewed-on: http://gerrit.cloudera.org:8080/3825 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Alexey Serbin has posted comments on this change. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. Patch Set 1: > Looks good provided you've tested it with both make and ninja. Yes, I tested it with GNU make 3.81 and ninja 1.6.0 under MacOS X and it worked for me. -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Adar Dembo has posted comments on this change. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. Patch Set 1: Code-Review+2 Looks good provided you've tested it with both make and ninja. -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Kudu Jenkins has posted comments on this change. Change subject: [doxygen] made DESTDIR applicable for ninja builds .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2694/ -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [doxygen] made DESTDIR applicable for ninja builds
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3825 Change subject: [doxygen] made DESTDIR applicable for ninja builds .. [doxygen] made DESTDIR applicable for ninja builds Moved the DESTDIR parameter into the environment to make the 'doxygen' target buildable under ninja as well. Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba --- M CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/3825/1 -- To view, visit http://gerrit.cloudera.org:8080/3825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I22867e66f03b5d355d884f667ed88f85ba429bba Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin
