[kudu-CR] [java] Use TEST TMPDIR environment variable in MiniKuduCluster
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10978 ) Change subject: [java] Use TEST_TMPDIR environment variable in MiniKuduCluster .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c Gerrit-Change-Number: 10978 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 18 Jul 2018 16:26:26 + Gerrit-HasComments: No
[kudu-CR] [java] Use TEST TMPDIR environment variable in MiniKuduCluster
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10978 ) Change subject: [java] Use TEST_TMPDIR environment variable in MiniKuduCluster .. [java] Use TEST_TMPDIR environment variable in MiniKuduCluster In order to match the functionality of the C++ MiniCluster, this change repects the TEST_TMPDIR environment variable when creating a temporary cluster root directory in MiniKuduCluster.java. Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c Reviewed-on: http://gerrit.cloudera.org:8080/10978 Reviewed-by: Adar Dembo Tested-by: Grant Henke --- M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java 1 file changed, 16 insertions(+), 2 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Grant Henke: Verified -- To view, visit http://gerrit.cloudera.org:8080/10978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c Gerrit-Change-Number: 10978 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Use TEST TMPDIR environment variable in MiniKuduCluster
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10978 ) Change subject: [java] Use TEST_TMPDIR environment variable in MiniKuduCluster .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/10978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c Gerrit-Change-Number: 10978 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 18 Jul 2018 16:24:27 + Gerrit-HasComments: No
[kudu-CR] [java] Use TEST TMPDIR environment variable in MiniKuduCluster
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10978 to look at the new patch set (#2). Change subject: [java] Use TEST_TMPDIR environment variable in MiniKuduCluster .. [java] Use TEST_TMPDIR environment variable in MiniKuduCluster In order to match the functionality of the C++ MiniCluster, this change repects the TEST_TMPDIR environment variable when creating a temporary cluster root directory in MiniKuduCluster.java. Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c --- M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java 1 file changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/10978/2 -- To view, visit http://gerrit.cloudera.org:8080/10978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c Gerrit-Change-Number: 10978 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Use TEST TMPDIR environment variable in MiniKuduCluster
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10978 ) Change subject: [java] Use TEST_TMPDIR environment variable in MiniKuduCluster .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10978/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/10978/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java@128 PS1, Line 128: // Match the C++ MiniCluster test functionality for overriding the tmp directory used. Maybe link to the C++ file where this is defined? tool_action_test.cc I think. -- To view, visit http://gerrit.cloudera.org:8080/10978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c Gerrit-Change-Number: 10978 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Wed, 18 Jul 2018 15:42:33 + Gerrit-HasComments: Yes
[kudu-CR] [java] Use TEST TMPDIR environment variable in MiniKuduCluster
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10978 Change subject: [java] Use TEST_TMPDIR environment variable in MiniKuduCluster .. [java] Use TEST_TMPDIR environment variable in MiniKuduCluster In order to match the functionality of the C++ MiniCluster, this change repects the TEST_TMPDIR environment variable when creating a temporary cluster root directory in MiniKuduCluster.java. Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c --- M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/10978/1 -- To view, visit http://gerrit.cloudera.org:8080/10978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I1e3a8bb4e91680a00a0d70f9ad9d29ac6802751c Gerrit-Change-Number: 10978 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
