[kudu-CR] [java-client] Re-enable multi-master tests
Adar Dembo has submitted this change and it was merged. Change subject: [java-client] Re-enable multi-master tests .. [java-client] Re-enable multi-master tests This patch makes TestMasterFailover useful again. It also adds the killing of masters to ITClient. Finally, it sets the raft heartbeat lower so that we don't wait 1.5s for leader elections. TestGetMasterRegistrationReceived was added since a previous version of this patch encountered a bug that such a simple unit test can detect. Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Reviewed-on: http://gerrit.cloudera.org:8080/3654 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon --- M java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestGetMasterRegistrationReceived.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java 6 files changed, 252 insertions(+), 34 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java-client] Re-enable multi-master tests
Todd Lipcon has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] Re-enable multi-master tests
Hello Dan Burkert, Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3654 to look at the new patch set (#5). Change subject: [java-client] Re-enable multi-master tests .. [java-client] Re-enable multi-master tests This patch makes TestMasterFailover useful again. It also adds the killing of masters to ITClient. Finally, it sets the raft heartbeat lower so that we don't wait 1.5s for leader elections. TestGetMasterRegistrationReceived was added since a previous version of this patch encountered a bug that such a simple unit test can detect. Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 --- M java/kudu-client/src/main/java/org/apache/kudu/client/GetMasterRegistrationReceived.java M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestGetMasterRegistrationReceived.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java 6 files changed, 252 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/3654/5 -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon
[kudu-CR] [java-client] Re-enable multi-master tests
Kudu Jenkins has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2721/ -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] Re-enable multi-master tests
Adar Dembo has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 4: > Oh, apparently it needs a manual rebase (I guess due to the package > change) Yeah, I'll take care of that. -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] Re-enable multi-master tests
Todd Lipcon has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 4: Oh, apparently it needs a manual rebase (I guess due to the package change) -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] Re-enable multi-master tests
Todd Lipcon has posted comments on this change. Change subject: [java-client] Re-enable multi-master tests .. Patch Set 4: Adar, do you think we can push this now? I'll hit a rebase to make sure it still passes tests -- To view, visit http://gerrit.cloudera.org:8080/3654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1051222738c84ef3d3e1a33b4981bc9454b7972 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
