[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-12-01 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change.

Change subject: [java client] Allow to pass extra flags to tservers/masters
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-12-01 Thread Mike Percy (Code Review) 
Mike Percy has submitted this change and it was merged.

Change subject: [java client] Allow to pass extra flags to tservers/masters
..


[java client] Allow to pass extra flags to tservers/masters

This path adds a couple of methods to MiniKuduClusterBuilder so that
a test can pass extra flags to the daemons. Another change is that
the builder is now a protected static final field of BaseKuduTest
so that subclasses can set flags before starting the cluster.

This is required for TestHybridTime to pass for a follow up patch.

Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Reviewed-on: http://gerrit.cloudera.org:8080/5299
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy 
---
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
2 files changed, 41 insertions(+), 3 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-11-30 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has posted comments on this change.

Change subject: [java client] Allow to pass extra flags to tservers/masters
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5299/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

Line 220: commandLine.add(extraTserverFlag);
> addAll?
Done


Line 299: commandLine.add(extraMasterFlag);
> same
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-11-30 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has uploaded a new patch set (#2).

Change subject: [java client] Allow to pass extra flags to tservers/masters
..

[java client] Allow to pass extra flags to tservers/masters

This path adds a couple of methods to MiniKuduClusterBuilder so that
a test can pass extra flags to the daemons. Another change is that
the builder is now a protected static final field of BaseKuduTest
so that subclasses can set flags before starting the cluster.

This is required for TestHybridTime to pass for a follow up patch.

Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
---
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
2 files changed, 41 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/5299/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-11-30 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: [java client] Allow to pass extra flags to tservers/masters
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5299/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java:

Line 220: commandLine.add(extraTserverFlag);
addAll?


Line 299: commandLine.add(extraMasterFlag);
same


-- 
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [java client] Allow to pass extra flags to tservers/masters

2016-11-30 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5299

Change subject: [java client] Allow to pass extra flags to tservers/masters
..

[java client] Allow to pass extra flags to tservers/masters

This path adds a couple of methods to MiniKuduClusterBuilder so that
a test can pass extra flags to the daemons. Another change is that
the builder is now a protected static final field of BaseKuduTest
so that subclasses can set flags before starting the cluster.

This is required for TestHybridTime to pass for a follow up patch.

Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
---
M java/kudu-client/src/test/java/org/apache/kudu/client/BaseKuduTest.java
M java/kudu-client/src/test/java/org/apache/kudu/client/MiniKuduCluster.java
2 files changed, 45 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/5299/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5299
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If9ecf0d22c0b49e2a07d5e3cf21c762e0790361a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves