[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-29 Thread Alexey Serbin (Code Review) 
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..

[rebalancer] location-aware rebalancer (part 2/n)

Small refactoring on tools::Rebalancer: renamed
Rebalancer::ResetKsck() into Rebalancer::RefreshKsckResults()
and made the actual ksck utility run as a part of the renamed
method.

Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Reviewed-on: http://gerrit.cloudera.org:8080/11743
Tested-by: Alexey Serbin 
Reviewed-by: Will Berkeley 
---
M src/kudu/tools/rebalancer.cc
M src/kudu/tools/rebalancer.h
2 files changed, 13 insertions(+), 21 deletions(-)

Approvals:
  Alexey Serbin: Verified
  Will Berkeley: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-29 Thread Will Berkeley (Code Review) 
Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 29 Oct 2018 23:00:56 +
Gerrit-HasComments: No

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-29 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Patch Set 3: Verified+1

Unrelated flakes in:
  1) org.apache.kudu.spark.kudu.DefaultSourceTest
  2) org.apache.kudu.backup.TestKuduBackup


--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 29 Oct 2018 22:49:42 +
Gerrit-HasComments: No

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-29 Thread Alexey Serbin (Code Review) 
Alexey Serbin has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-23 Thread Will Berkeley (Code Review) 
Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Tue, 23 Oct 2018 20:33:24 +
Gerrit-HasComments: No

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-23 Thread Alexey Serbin (Code Review) 
Alexey Serbin has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-23 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Patch Set 2: Verified+1

Unrelated flake in AdminCliTest.TestSimultaneousLeaderTransferAndAbruptStepdown


--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Tue, 23 Oct 2018 18:24:32 +
Gerrit-HasComments: No

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-22 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11743/1/src/kudu/tools/rebalancer.h
File src/kudu/tools/rebalancer.h:

http://gerrit.cloudera.org:8080/#/c/11743/1/src/kudu/tools/rebalancer.h@265
PS1, Line 265:   Status GetNextMoves(const MovesInProgress& moves_in_progress,
> warning: function 'kudu::tools::Rebalancer::GetNextMoves' has a definition
Done



--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Tue, 23 Oct 2018 05:26:23 +
Gerrit-HasComments: Yes

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-22 Thread Alexey Serbin (Code Review) 
Hello Will Berkeley, Tidy Bot,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/11743

to look at the new patch set (#2).

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..

[rebalancer] location-aware rebalancer (part 2/n)

Small refactoring on tools::Rebalancer: renamed
Rebalancer::ResetKsck() into Rebalancer::RefreshKsckResults()
and made the actual ksck utility run as a part of the renamed
method.

Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
---
M src/kudu/tools/rebalancer.cc
M src/kudu/tools/rebalancer.h
2 files changed, 13 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/11743/2
--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-22 Thread Will Berkeley (Code Review) 
Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Patch Set 1: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 22 Oct 2018 19:49:54 +
Gerrit-HasComments: No

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-22 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Patch Set 1: Verified+1

Unrelated flake in org.apache.kudu.spark.kudu.DefaultSourceTest


--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 22 Oct 2018 17:39:15 +
Gerrit-HasComments: No

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-22 Thread Alexey Serbin (Code Review) 
Alexey Serbin has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/11743 )

Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley

[kudu-CR] [rebalancer] location-aware rebalancer (part 2/n)

2018-10-20 Thread Alexey Serbin (Code Review) 
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/11743


Change subject: [rebalancer] location-aware rebalancer (part 2/n)
..

[rebalancer] location-aware rebalancer (part 2/n)

Small refactoring on tools::Rebalancer: renamed
Rebalancer::ResetKsck() into Rebalancer::RefreshKsckResults()
and made the actual ksck utility run as a part of the renamed
method.

Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
---
M src/kudu/tools/rebalancer.cc
M src/kudu/tools/rebalancer.h
2 files changed, 6 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/11743/1
--
To view, visit http://gerrit.cloudera.org:8080/11743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1bdd4ee13d0522e49467b8b6e4e3a76ec560b26
Gerrit-Change-Number: 11743
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin