[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. [rebalancer] location-aware rebalancer (part 8/n) Updated FindBestReplicaToReplace() to handle common and edge cases of even replication factors. Added corresponding unit tests as well. Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de Reviewed-on: http://gerrit.cloudera.org:8080/11761 Tested-by: Kudu Jenkins Reviewed-by: Will Berkeley --- M src/kudu/tools/placement_policy_util-test.cc M src/kudu/tools/placement_policy_util.cc 2 files changed, 222 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Will Berkeley: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de Gerrit-Change-Number: 11761 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de Gerrit-Change-Number: 11761 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 01 Nov 2018 03:32:17 + Gerrit-HasComments: No
[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de Gerrit-Change-Number: 11761 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Thu, 01 Nov 2018 02:05:20 + Gerrit-HasComments: No
[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11761 to look at the new patch set (#4). Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. [rebalancer] location-aware rebalancer (part 8/n) Updated FindBestReplicaToReplace() to handle common and edge cases of even replication factors. Added corresponding unit tests as well. Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de --- M src/kudu/tools/placement_policy_util-test.cc M src/kudu/tools/placement_policy_util.cc 2 files changed, 222 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11761/4 -- To view, visit http://gerrit.cloudera.org:8080/11761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de Gerrit-Change-Number: 11761 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley
[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc File src/kudu/tools/placement_policy_util.cc: http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc@81 PS1, Line 81: == > Yeah, my bad. NP, that was not obvious. I think that means I need to add a comment with the explanation. -- To view, visit http://gerrit.cloudera.org:8080/11761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de Gerrit-Change-Number: 11761 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Mon, 29 Oct 2018 23:28:53 + Gerrit-HasComments: Yes
[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11761 ) Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc File src/kudu/tools/placement_policy_util.cc: http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc@81 PS1, Line 81: > Well, I think this case is a separate one. Yeah, my bad. -- To view, visit http://gerrit.cloudera.org:8080/11761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de Gerrit-Change-Number: 11761 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Mon, 29 Oct 2018 23:19:26 + Gerrit-HasComments: Yes
[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/11761 )
Change subject: [rebalancer] location-aware rebalancer (part 8/n)
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util-test.cc
File src/kudu/tools/placement_policy_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util-test.cc@633
PS1, Line 633: { "G", { "t0", } }
> Extra indentation.
Done
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc
File src/kudu/tools/placement_policy_util.cc:
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc@78
PS1, Line 78: edgecases
> I'd point out that these are special cases of the general problem of having
Done
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc@81
PS1, Line 81: ==
> >=
Well, I think this case is a separate one.
It seems with 3 locations and RF=5 there is a good way to place replicas so the
majority would be on-line if any tablet servers goes down:
2+2+1
In case of 3 locations and RF=6 that's
2+2+2
And so on with higher replication factors.
--
To view, visit http://gerrit.cloudera.org:8080/11761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de
Gerrit-Change-Number: 11761
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Mon, 29 Oct 2018 20:54:57 +
Gerrit-HasComments: Yes
[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Will Berkeley has posted comments on this change. (
http://gerrit.cloudera.org:8080/11761 )
Change subject: [rebalancer] location-aware rebalancer (part 8/n)
..
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util-test.cc
File src/kudu/tools/placement_policy_util-test.cc:
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util-test.cc@633
PS1, Line 633: { "G", { "t0", } }
Extra indentation.
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc
File src/kudu/tools/placement_policy_util.cc:
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc@78
PS1, Line 78: edgecases
I'd point out that these are special cases of the general problem of having too
few locations relative to a replication factor and we're calling them out with
a special error message since they are by far the most likely to actually occur.
http://gerrit.cloudera.org:8080/#/c/11761/1/src/kudu/tools/placement_policy_util.cc@81
PS1, Line 81: ==
>=
--
To view, visit http://gerrit.cloudera.org:8080/11761
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de
Gerrit-Change-Number: 11761
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley
Gerrit-Comment-Date: Mon, 29 Oct 2018 17:40:16 +
Gerrit-HasComments: Yes
[kudu-CR] [rebalancer] location-aware rebalancer (part 8/n)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11761 Change subject: [rebalancer] location-aware rebalancer (part 8/n) .. [rebalancer] location-aware rebalancer (part 8/n) Updated FindBestReplicaToReplace() to handle common and edge cases of even replication factors. Added corresponding unit tests as well. Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de --- M src/kudu/tools/placement_policy_util-test.cc M src/kudu/tools/placement_policy_util.cc 2 files changed, 203 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/11761/1 -- To view, visit http://gerrit.cloudera.org:8080/11761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8f8831d254b2ca0d9a12e0ffbc336a59c3c5c8de Gerrit-Change-Number: 11761 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
