[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote replica list command.

2021-12-13 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18092 )

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last statue" in 
remote_replica list command.
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18092/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18092/3//COMMIT_MSG@7
PS3, Line 7: statue
typo: status


http://gerrit.cloudera.org:8080/#/c/18092/3/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/18092/3/src/kudu/tools/kudu-tool-test.cc@3468
PS3, Line 3468: ASSERT_STR_CONTAINS(stdout, "Data state: 
TABLET_DATA_TOMBSTONED");
Could you add a test case for "Last status" as well?



--
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 3
Gerrit-Owner: yejiabao 
Gerrit-Reviewer: Adar Lieber-Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 13 Dec 2021 15:28:08 +
Gerrit-HasComments: Yes


[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote replica list command.

2021-12-12 Thread yejiabao (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Adar Lieber-Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/18092

to look at the new patch set (#3).

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last statue" in 
remote_replica list command.
..

[tool] KUDU-3343 Display the "Data state" and "Last statue" in remote_replica 
list command.

It's will make simple and more detail to judge tablet state by
"Data state" and "Last status" in remote_replica list

Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18092/3
--
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 3
Gerrit-Owner: yejiabao 
Gerrit-Reviewer: Adar Lieber-Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] [tool] KUDU-3343 Display the "Data state" and "Last statue" in remote replica list command.

2021-12-12 Thread yejiabao (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/18092

to look at the new patch set (#2).

Change subject: [tool] KUDU-3343 Display the "Data state" and "Last statue" in 
remote_replica list command.
..

[tool] KUDU-3343 Display the "Data state" and "Last statue" in remote_replica 
list command.

It's will make simple and more detail to judge tablet state by
"Data state" and "Last status" in remote_replica list

Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_remote_replica.cc
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/18092/2
--
To view, visit http://gerrit.cloudera.org:8080/18092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9c6b28a7a6d69f04872b28e5b57c0fcfea915777
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 2
Gerrit-Owner: yejiabao 
Gerrit-Reviewer: Kudu Jenkins (120)