[kudu-CR] [tools] Allow ksck output to be filtered by section

2019-01-04 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/12038 )

Change subject: [tools] Allow ksck output to be filtered by section
..

[tools] Allow ksck output to be filtered by section

When there are lots of tables or tservers in the cluster, the `kudu ksck`
output may be very large and hard for administrators to read.
This commit adds a parameter `--sections` to filter output sections.

Change-Id: Ic31dcb7795b5c510b40fa2024960306b9da40e05
Reviewed-on: http://gerrit.cloudera.org:8080/12038
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley 
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 447 insertions(+), 140 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Will Berkeley: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/12038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic31dcb7795b5c510b40fa2024960306b9da40e05
Gerrit-Change-Number: 12038
Gerrit-PatchSet: 9
Gerrit-Owner: Yingchun Lai <405403...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] [tools] Allow ksck output to be filtered by section

2019-01-04 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12038 )

Change subject: [tools] Allow ksck output to be filtered by section
..


Patch Set 8: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/12038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic31dcb7795b5c510b40fa2024960306b9da40e05
Gerrit-Change-Number: 12038
Gerrit-PatchSet: 8
Gerrit-Owner: Yingchun Lai <405403...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Fri, 04 Jan 2019 17:35:09 +
Gerrit-HasComments: No


[kudu-CR] [tools] Allow ksck output to be filtered by section

2019-01-03 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12038

to look at the new patch set (#8).

Change subject: [tools] Allow ksck output to be filtered by section
..

[tools] Allow ksck output to be filtered by section

When there are lots of tables or tservers in the cluster, the `kudu ksck`
output may be very large and hard for administrators to read.
This commit adds a parameter `--sections` to filter output sections.

Change-Id: Ic31dcb7795b5c510b40fa2024960306b9da40e05
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 447 insertions(+), 140 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/12038/8
--
To view, visit http://gerrit.cloudera.org:8080/12038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic31dcb7795b5c510b40fa2024960306b9da40e05
Gerrit-Change-Number: 12038
Gerrit-PatchSet: 8
Gerrit-Owner: Yingchun Lai <405403...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley 


[kudu-CR] [tools] Allow ksck output to be filtered by section

2019-01-03 Thread Yingchun Lai (Code Review)
Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/12038

to look at the new patch set (#7).

Change subject: [tools] Allow ksck output to be filtered by section
..

[tools] Allow ksck output to be filtered by section

When there are lots of tables or tservers in the cluster, the `kudu ksck`
output may be very large and hard for administrators to read.
This commit adds a parameter `--sections` to filter output sections.

Change-Id: Ic31dcb7795b5c510b40fa2024960306b9da40e05
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_results.cc
M src/kudu/tools/ksck_results.h
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_cluster.cc
7 files changed, 447 insertions(+), 140 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/12038/7
--
To view, visit http://gerrit.cloudera.org:8080/12038
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic31dcb7795b5c510b40fa2024960306b9da40e05
Gerrit-Change-Number: 12038
Gerrit-PatchSet: 7
Gerrit-Owner: Yingchun Lai <405403...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley