[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4412

to look at the new patch set (#8).

Change subject: [tools] updated insert-generated-rows tool
..

[tools] updated insert-generated-rows tool

Added ability to run multiple inserter threads and specify additional
parameters on batching behavior of the generated write operations.
Now it's possible to run data generating sessions both in MANUAL_FLUSH
and AUTO_FLUSH_BACKGROUND modes.  Also, introduced sequential and
random modes for the data generator.  Overall, the change allow to use
the tool to measure performance of the Kudu C++ client library
in simplistic 'push-as-much-as-you-can' scenario: the client generates
and sends data as fast as it can.

Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
---
M src/kudu/tools/insert-generated-rows.cc
1 file changed, 394 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4412/8
-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4412

to look at the new patch set (#7).

Change subject: [tools] updated insert-generated-rows tool
..

[tools] updated insert-generated-rows tool

Added ability to run multiple inserter threads and specify different
parameters on batching/buffering of the generated write operations.
Now it's possible to run the data generating session both in
MANUAL_FLUSH and AUTO_FLUSH_BACKGROUND modes.  Also, introduced
different modes for the row generator.  Overall, the changes allow
allow to use the tool to measure performance of the Kudu C++ client
library in 'push-as-much-as-you-can' scenarios: the client generates
and sends as much data to tablet servers as it can.

Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
---
M src/kudu/tools/insert-generated-rows.cc
1 file changed, 394 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4412/7
-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change.

Change subject: [tools] updated insert-generated-rows tool
..


Patch Set 6:

(1 comment)

> (1 comment)
 > 
 > Would be nice to see a small integration test that runs the tool
 > against a cluster then verifies that it indeed inserted rows. Our
 > CLI tools have a tendency to bit-rot because of the lack of tests;
 > we're trying to change that with the new CLI tool.
 > 
 > On that note, what do you think of incorporating this as an action
 > in the new CLI tool? You'll get most of main() for free, but it
 > means this will ship to users. Do you think it'd a useful tool for
 > them?

Good point!  Sure -- I think it's a good idea to provide a means to check that 
the cluster was configured properly and is able to accept some data.  I will 
try to put up a small addition to the CLI tools, as you suggested.

http://gerrit.cloudera.org:8080/#/c/4412/6/src/kudu/tools/insert-generated-rows.cc
File src/kudu/tools/insert-generated-rows.cc:

Line 116: DEFINE_string(master_address, "localhost:7051",
> Nit: can we change this to master_addresses?
If we are not afraid of braking compatibility with the old version, then yes.

But Todd told me I'm free to break it! :)

Will change.


-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes


[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change.

Change subject: [tools] updated insert-generated-rows tool
..


Patch Set 6:

(1 comment)

Would be nice to see a small integration test that runs the tool against a 
cluster then verifies that it indeed inserted rows. Our CLI tools have a 
tendency to bit-rot because of the lack of tests; we're trying to change that 
with the new CLI tool.

On that note, what do you think of incorporating this as an action in the new 
CLI tool? You'll get most of main() for free, but it means this will ship to 
users. Do you think it'd a useful tool for them?

http://gerrit.cloudera.org:8080/#/c/4412/6/src/kudu/tools/insert-generated-rows.cc
File src/kudu/tools/insert-generated-rows.cc:

Line 116: DEFINE_string(master_address, "localhost:7051",
Nit: can we change this to master_addresses?


-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes


[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4412

to look at the new patch set (#6).

Change subject: [tools] updated insert-generated-rows tool
..

[tools] updated insert-generated-rows tool

Added ability to run multiple inserter threads and specify different
parameters on batching/buffering of the generated write operations.
Now it's possible to run the data generating session both in
MANUAL_FLUSH and AUTO_FLUSH_BACKGROUND modes.  Also, introduced
different modes for the row generator.  Overall, the changes allow
allow to use the tool to measure performance of the Kudu C++ client
library in 'push-as-much-as-you-can' scenarios: the client generates
and sends as much data to tablet servers as it can.

Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
---
M src/kudu/tools/insert-generated-rows.cc
1 file changed, 394 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4412/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] [tools] updated insert-generated-rows tool

2016-09-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4412

to look at the new patch set (#5).

Change subject: [tools] updated insert-generated-rows tool
..

[tools] updated insert-generated-rows tool

Added ability to run multiple inserter threads and specify different
parameters on batching/buffering of the generated write operations.
Now it's possible to run the data generating session both in
MANUAL_FLUSH and AUTO_FLUSH_BACKGROUND modes.  Also, introduced
different modes for the row generator.  Overall, the changes allow
allow to use the tool to measure performance of the Kudu C++ client
library in 'push-as-much-as-you-can' scenarios: the client generates
and sends as much data to tablet servers as it can.

Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
---
M src/kudu/tools/insert-generated-rows.cc
1 file changed, 394 insertions(+), 84 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/4412/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4412
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I332927c0b928c9c4fb81a8e26f5c9ed7565299ad
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon