[kudu-CR] Add a basic .clang-tidy configuration

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add a basic .clang-tidy configuration
..


Patch Set 1:

any docs on how to use this locally?

-- 
To view, visit http://gerrit.cloudera.org:8080/4453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b22195b11265959768c07fb60e9f97feeba95c7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Add a basic .clang-tidy configuration

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Add a basic .clang-tidy configuration
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4453/1/src/kudu/.clang-tidy
File src/kudu/.clang-tidy:

Line 18: Checks:  
'-*,clang-diagnostic-*,-clang-diagnostic-unused-const-variable,readability-*,-readability-implicit-bool-cast,-readability-braces-around-statements,-readability-redundant-string-init,-readability-inconsistent-declaration-parameter-name,performance-*,google-*,-google-readability-todo,-google-readability-braces-around-statements,misc-*,-misc-unused-parameters'
Is it possible to split this across multiple lines with backslashes or some 
such? It would simplify adding/removing checks.


-- 
To view, visit http://gerrit.cloudera.org:8080/4453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b22195b11265959768c07fb60e9f97feeba95c7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Add a basic .clang-tidy configuration

[Todd Lipcon (Code Review)]

Hello David Ribeiro Alves,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4453

to review the following change.

Change subject: Add a basic .clang-tidy configuration
..

Add a basic .clang-tidy configuration

This configuration enables just the most important checks for now, and
disables the more "stylistic" ones for the most part.

Change-Id: I7b22195b11265959768c07fb60e9f97feeba95c7
---
A src/kudu/.clang-tidy
1 file changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/4453/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4453
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b22195b11265959768c07fb60e9f97feeba95c7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves