[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: Another pass on 0.10.0 release notes
..


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3979/2/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 141: // TODO(dan) can we link to the docs once they're committed?
Looks like this is the only remaining TODO.


-- 
To view, visit http://gerrit.cloudera.org:8080/3979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: Another pass on 0.10.0 release notes
..


Patch Set 1:

(2 comments)

Did a pass on the new stuff. Looks good overall.

http://gerrit.cloudera.org:8080/#/c/3979/1/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 145:   despite a failure of a master.
Nit: maybe "despite a failure of one or two masters, respectively" to tie into 
"three or five" above?


Line 151:   on each of its drives. If a drive's free disk space drops to less 
than the
Nit: "drive" isn't really the terminology we use internally; "data directory" 
is more appropriate, I think.


-- 
To view, visit http://gerrit.cloudera.org:8080/3979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: Another pass on 0.10.0 release notes
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3979/1/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 145:   despite a failure of a master.
> Nit: maybe "despite a failure of one or two masters, respectively" to tie i
Done


Line 151:   on each of its drives. If a drive's free disk space drops to less 
than the
> Nit: "drive" isn't really the terminology we use internally; "data director
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: Another pass on 0.10.0 release notes
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3979/1/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 236: //  TODO(mpercy): does this prevent downgrade? does everything 
upgrade OK on its own?
> I believe, though have not yet tested, that downgrade will be possible if w
k, will remove the TODO.


-- 
To view, visit http://gerrit.cloudera.org:8080/3979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Mike Percy (Code Review) 
Mike Percy has posted comments on this change.

Change subject: Another pass on 0.10.0 release notes
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3979/1/docs/release_notes.adoc
File docs/release_notes.adoc:

Line 236: //  TODO(mpercy): does this prevent downgrade? does everything 
upgrade OK on its own?
I believe, though have not yet tested, that downgrade will be possible if we 
merge https://gerrit.cloudera.org/#/c/3985/


-- 
To view, visit http://gerrit.cloudera.org:8080/3979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Another pass on 0.10.0 release notes
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2897/

-- 
To view, visit http://gerrit.cloudera.org:8080/3979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] Another pass on 0.10.0 release notes

2016-08-15 Thread Todd Lipcon (Code Review) 
Hello Dan Burkert, Mike Percy, Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3979

to review the following change.

Change subject: Another pass on 0.10.0 release notes
..

Another pass on 0.10.0 release notes

Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9
---
M docs/release_notes.adoc
1 file changed, 48 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/3979/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3979
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4414bdebb15d976c025dfce5a3f2bda5768bd5a9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Mike Percy