[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has submitted this change and it was merged.

Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..


Change timestamp printing to ISO-8601 (with microseconds)

Dan raised the concern in a recent review that we're not adhering to the
standard while printing timestamps. The main point of this was to mimic
impala's behavior but then we would also print 'GMT', which impala does
not, meaning we aren't really mimicking impala either.

This changes timestamp printing to adhere to ISO-8601, hopefully allowing
standard date parsers to more easily process the output, if needed.

Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Reviewed-on: http://gerrit.cloudera.org:8080/1995
Tested-by: David Ribeiro Alves 
Reviewed-by: Todd Lipcon 
---
M src/kudu/common/types-test.cc
M src/kudu/common/types.h
2 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  David Ribeiro Alves: Verified
  Todd Lipcon: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/1995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/1995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..


Patch Set 3:

Yep, it was changed on the Java side recently.  
https://github.com/apache/kudu/blob/master/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java#L519

-- 
To view, visit http://gerrit.cloudera.org:8080/1995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..


Patch Set 3:

Dan mentioned that it had already done it for java

-- 
To view, visit http://gerrit.cloudera.org:8080/1995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..


Patch Set 3:

Should we be consistent with the Java side?

-- 
To view, visit http://gerrit.cloudera.org:8080/1995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..


Patch Set 3:

I fixed this on the Java side a little bit ago, since I thought this patch had 
landed a long time ago.  I think we should still merge.

-- 
To view, visit http://gerrit.cloudera.org:8080/1995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

[Dan Burkert (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/1995

to look at the new patch set (#3).

Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..

Change timestamp printing to ISO-8601 (with microseconds)

Dan raised the concern in a recent review that we're not adhering to the
standard while printing timestamps. The main point of this was to mimic
impala's behavior but then we would also print 'GMT', which impala does
not, meaning we aren't really mimicking impala either.

This changes timestamp printing to adhere to ISO-8601, hopefully allowing
standard date parsers to more easily process the output, if needed.

Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
---
M src/kudu/common/types-test.cc
M src/kudu/common/types.h
2 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/1995/3
-- 
To view, visit http://gerrit.cloudera.org:8080/1995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Change timestamp printing to ISO-8601 (with microseconds)

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Change timestamp printing to ISO-8601 (with microseconds)
..


Patch Set 2:

Should we still do this?

-- 
To view, visit http://gerrit.cloudera.org:8080/1995
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I421e3595af2b21eee6ec22606b6046e470559ad4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No