[kudu-CR] Convert pbc-dump over to the new tool infrastructure

2016-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change.

Change subject: Convert pbc-dump over to the new tool infrastructure
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] Convert pbc-dump over to the new tool infrastructure

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change.

Change subject: Convert pbc-dump over to the new tool infrastructure
..


Patch Set 2:

> Please update install_kudu.sh (on the internal CDH/cdh-package.git:kudu repo 
> and branch) before merging.

Already did.

-- 
To view, visit http://gerrit.cloudera.org:8080/4037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] Convert pbc-dump over to the new tool infrastructure

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: Convert pbc-dump over to the new tool infrastructure
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3029/

-- 
To view, visit http://gerrit.cloudera.org:8080/4037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR] Convert pbc-dump over to the new tool infrastructure

2016-08-23 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/4037

to look at the new patch set (#2).

Change subject: Convert pbc-dump over to the new tool infrastructure
..

Convert pbc-dump over to the new tool infrastructure

Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78
---
M src/kudu/tools/CMakeLists.txt
D src/kudu/tools/pbc-dump.cc
M src/kudu/tools/tool_action.h
A src/kudu/tools/tool_action_pbc.cc
M src/kudu/tools/tool_main.cc
5 files changed, 78 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/4037/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia7707f004ea31d1a9e7bb890611080785f667c78
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon