[kudu-CR] Improve breakpad tooling

[Mike Percy (Code Review)]

Mike Percy has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/8576 )

Change subject: Improve breakpad tooling
..

Improve breakpad tooling

Kudu has used Google Breakpad to produce minidumps since a806ce003.
This patch adds a useful script to produce Breakpad symbols from Kudu
binaries in a few different ways. This script was taken, with minor
modifications, from Impala.

I also found that symbol dumping didn't work on el7 because the
Breakpad dump_syms utility lacks support for certain DWARF macros, and
I borrowed a Breakpad patch from Impala to work around it.

To test this patch, I dumped the symbols and used them to process a
minidump file from (binary, dump) pairs from el6, el7, and Ubuntu Trusty.
The binaries were in RPMs, debs, or in a Kudu build directory.

Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Reviewed-on: http://gerrit.cloudera.org:8080/8576
Reviewed-by: Mike Percy 
Tested-by: Mike Percy 
---
M docs/troubleshooting.adoc
A src/kudu/scripts/dump_breakpad_symbols.py
M thirdparty/download-thirdparty.sh
A thirdparty/patches/breakpad-add-basic-support-for-dwz-dwarf-extension.patch
4 files changed, 385 insertions(+), 1 deletion(-)

Approvals:
  Mike Percy: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/8576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Gerrit-Change-Number: 8576
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] Improve breakpad tooling

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8576 )

Change subject: Improve breakpad tooling
..


Patch Set 4: Verified+1 Code-Review+2

Overriding unrelated failure


--
To view, visit http://gerrit.cloudera.org:8080/8576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Gerrit-Change-Number: 8576
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Mon, 27 Nov 2017 22:03:16 +
Gerrit-HasComments: No

[kudu-CR] Improve breakpad tooling

[Mike Percy (Code Review)]

Mike Percy has removed a vote on this change.

Change subject: Improve breakpad tooling
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/8576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Gerrit-Change-Number: 8576
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] Improve breakpad tooling

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8576 )

Change subject: Improve breakpad tooling
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/8576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Gerrit-Change-Number: 8576
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 16 Nov 2017 22:02:31 +
Gerrit-HasComments: No

[kudu-CR] Improve breakpad tooling

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8576 )

Change subject: Improve breakpad tooling
..


Patch Set 2:

Test failures look they're due to Jenkins problems; other precommits are 
failing with the same problem. Will re-run later.


--
To view, visit http://gerrit.cloudera.org:8080/8576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Gerrit-Change-Number: 8576
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 16 Nov 2017 21:52:24 +
Gerrit-HasComments: No

[kudu-CR] Improve breakpad tooling

[Will Berkeley (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/8576

to look at the new patch set (#2).

Change subject: Improve breakpad tooling
..

Improve breakpad tooling

Kudu has used Google Breakpad to produce minidumps since a806ce003.
This patch adds a useful script to produce Breakpad symbols from Kudu
binaries in a few different ways. This script was taken, with minor
modifications, from Impala.

I also found that symbol dumping didn't work on el7 because the
Breakpad dump_syms utility lacks support for certain DWARF macros, and
I borrowed a Breakpad patch from Impala to work around it.

To test this patch, I dumped the symbols and used them to process a
minidump file from (binary, dump) pairs from el6, el7, and Ubuntu Trusty.
The binaries were in RPMs, debs, or in a Kudu build directory.

Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
---
M docs/troubleshooting.adoc
A src/kudu/scripts/dump_breakpad_symbols.py
M thirdparty/download-thirdparty.sh
A thirdparty/patches/breakpad-add-basic-support-for-dwz-dwarf-extension.patch
4 files changed, 385 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/8576/2
--
To view, visit http://gerrit.cloudera.org:8080/8576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Gerrit-Change-Number: 8576
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 

[kudu-CR] Improve breakpad tooling

[Will Berkeley (Code Review)]

Will Berkeley has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/8576 )

Change subject: Improve breakpad tooling
..


Patch Set 1:

Failure was:

10:55:58 ../nondebug/libpmemobj/tx.o: file not recognized: File truncated
10:55:58 make[1]: *** [../nondebug/libpmemobj/libpmemobj_unscoped.o] Error 1
10:55:58 make[1]: Leaving directory 
`/home/jenkins-slave/workspace/kudu-master/0/thirdparty/build/nvml-1.1/src/libpmemobj'

It's in a different thirdparty component so I think it is unrelated.


--
To view, visit http://gerrit.cloudera.org:8080/8576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Gerrit-Change-Number: 8576
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley 
Gerrit-Comment-Date: Thu, 16 Nov 2017 19:46:28 +
Gerrit-HasComments: No

[kudu-CR] Improve breakpad tooling

[Will Berkeley (Code Review)]

Will Berkeley has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/8576


Change subject: Improve breakpad tooling
..

Improve breakpad tooling

Kudu has used Google Breakpad to produce minidumps since a806ce003.
This patch adds a useful script to produce Breakpad symbols from Kudu
binaries in a few different ways. This script was taken, with minor
modifications, from Impala.

I also found that symbol dumping didn't work on el7 because the
Breakpad dump_syms utility lacks support for certain DWARF macros, and
I borrowed a Breakpad patch from Impala to work around it.

To test this patch, I dumped the symbols and used them to process a
minidump file from (binary, dump) pairs from el6, el7, and Ubuntu Trusty.
The binaries were in RPMs, debs, or in a Kudu build directory.

Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
---
A build-support/dump_breakpad_symbols.py
M thirdparty/download-thirdparty.sh
A thirdparty/patches/breakpad-add-basic-support-for-dwz-dwarf-extension.patch
3 files changed, 380 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/8576/1
--
To view, visit http://gerrit.cloudera.org:8080/8576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e17c5c24115fa34f55fc5c0105f6d9eaa6b39ac
Gerrit-Change-Number: 8576
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley