[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/3079/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 6: (2 comments) TFTR Adar, will follow the JIRA suggestions for more testing tonight.

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#7). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 6: (2 comments) I left you some more comments in the JIRA regarding the testing.

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 4: Addressed all the rev comments below, thanks Adar. Also updated commit message to reflect

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/3078/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#6). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 5: (3 comments) Just a couple of nits but this is otherwise good, though we still need to find

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 4: (14 comments) TFTR Adar/Alexey, updated the patch after addressing rev comments.

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#5). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/3071/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/3070/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-25 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#4). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 3: (13 comments) http://gerrit.cloudera.org:8080/#/c/4099/3//COMMIT_MSG Commit Message: Line

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4099/1//COMMIT_MSG Commit Message: Line

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4099/1//COMMIT_MSG Commit Message: Line 8:

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-23 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#3). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3042/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-23 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 2: (1 comment) Yeah, I think it is possible to keep just one although they seem to be coming

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3026/ -- To view, visit

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC

2016-08-23 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4099 to look at the new patch set (#2). Change subject: KUDU-1534 : Added software_version to ListMasters RPC

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf

2016-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf .. Patch Set 1:

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf

2016-08-23 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf .. Patch Set 1:

[kudu-CR] KUDU-1534 : Added software version to ListMasters RPC Sample output is at: https://github.com/dineshabbi/scripts/blob/master/MasterRegWebUI.pdf

2016-08-23 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4099 to review the following change. Change subject: KUDU-1534 : Added software_version to ListMasters RPC Sample output is at: