[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-14 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged.

Change subject: KUDU-1559. Fix block manager metric for aborted blocks
..


KUDU-1559. Fix block manager metric for aborted blocks

We weren't properly decrementing the "open writable blocks" metric when
aborting a LogWritableBlock.

Change-Id: I4447d2c4e3073732dc423cc7b6dd22e2ba9ad926
Reviewed-on: http://gerrit.cloudera.org:8080/3964
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
2 files changed, 39 insertions(+), 45 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4447d2c4e3073732dc423cc7b6dd22e2ba9ad926
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change.

Change subject: KUDU-1559. Fix block manager metric for aborted blocks
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4447d2c4e3073732dc423cc7b6dd22e2ba9ad926
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-12 Thread Todd Lipcon (Code Review)
Hello Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3964

to review the following change.

Change subject: KUDU-1559. Fix block manager metric for aborted blocks
..

KUDU-1559. Fix block manager metric for aborted blocks

We weren't properly decrementing the "open writable blocks" metric when
aborting a LogWritableBlock.

Change-Id: I4447d2c4e3073732dc423cc7b6dd22e2ba9ad926
---
M src/kudu/fs/block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
2 files changed, 39 insertions(+), 45 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/3964/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4447d2c4e3073732dc423cc7b6dd22e2ba9ad926
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 


[kudu-CR] KUDU-1559. Fix block manager metric for aborted blocks

2016-08-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1559. Fix block manager metric for aborted blocks
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2857/

-- 
To view, visit http://gerrit.cloudera.org:8080/3964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4447d2c4e3073732dc423cc7b6dd22e2ba9ad926
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No