[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-20 Thread Will Berkeley (Code Review)
Will Berkeley has submitted this change and it was merged. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. KUDU-1755 Part 2: Improve tablet on-disk size metric This adds WAL segment and cmeta sizes to

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 23: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6968 To

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-19 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#23). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 22: (10 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 22: (10 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/19/src/kudu/tablet/diskrowset.h File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-19 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#22). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-18 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-18 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#21). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 21: Something mysterious happened and so 19 + 1 = 21. -- To view, visit

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/19/src/kudu/consensus/log.h File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/19/src/kudu/consensus/log.h

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/17/src/kudu/consensus/log.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#19). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/17/src/kudu/consensus/log.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#18). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/6968/17/src/kudu/consensus/log.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/6968/17/src/kudu/consensus/log.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6968 To unsubscribe,

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/16/src/kudu/consensus/log-test.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-14 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#17). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-08 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/6968/16/src/kudu/consensus/log-test.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 15: (2 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-08 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#16). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-07 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 15: (2 comments) http://gerrit.cloudera.org:8080/#/c/6968/13/src/kudu/consensus/consensus_meta.h

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 13: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 15: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#15). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#14). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 13: (4 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-06 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 13: (2 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/6968/10/src/kudu/tablet/diskrowset.cc File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#13). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#12). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 11: Odd...I compiled and ran some tests just before pushing this to review. And TSAN worked.

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#11). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-09-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 10: (11 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 10: (10 comments) Would be nice to add a simple test for the values stored by the new metrics.

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 10: Code-Review+1 (1 comment) Todd and/or Mike should take another look.

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-14 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 9: (13 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-14 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#10). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 9: (12 comments) http://gerrit.cloudera.org:8080/#/c/6968/9/src/kudu/consensus/consensus_meta.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/9/src/kudu/consensus/consensus_meta.h

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-10 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#9). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-08-10 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) Minor rebasing.

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-05 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/consensus/consensus_meta.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-05 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 8: Build failure looks like a random timeout in Python tests, which incidentally exposed a

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-02 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#8). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-02 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (7 comments)

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-02 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#7). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/consensus/consensus_meta.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/consensus/consensus_meta.h

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/consensus/consensus_meta.cc

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/6968/6/src/kudu/tablet/diskrowset.h File

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 6: > Uploaded patch set 6. This is still going to change quite a bit when all of Mike's

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#6). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-06-01 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#5). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6968/4//COMMIT_MSG Commit Message: Line

[kudu-CR] KUDU-1755 Part 2: Improve tablet on-disk size metric

2017-05-25 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6968 to look at the new patch set (#4). Change subject: KUDU-1755 Part 2: Improve tablet on-disk size metric ..