[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks Previously a bunch of logic to collect all the stacks from the process was in the /stacks path handler. This logic is relatively generic and shouldn't be intermingled with the formatting code. In particular I'd like to use it in the diagnostics log, where a different output format is desirable. Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Reviewed-on: http://gerrit.cloudera.org:8080/9329 Tested-by: Todd LipconReviewed-by: Mike Percy --- M src/kudu/server/default_path_handlers.cc M src/kudu/server/diagnostics_log.cc M src/kudu/util/debug-util-test.cc M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h 5 files changed, 190 insertions(+), 112 deletions(-) Approvals: Todd Lipcon: Verified Mike Percy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 9 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 8 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 23 Feb 2018 22:23:15 + Gerrit-HasComments: No
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9329/7/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9329/7/src/kudu/util/debug-util.cc@715 PS7, Line 715: CHECK(!infos_[i].stack.HasCollected()) << infos_[i].status.ToString(); > Did you figure this out? yea, I put the fix in the separate patch "KUDU-2291 (part 7): fix race in stack trace collection" -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 7 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 23 Feb 2018 02:38:41 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/9329/7/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9329/7/src/kudu/util/debug-util.cc@715 PS7, Line 715: num_failed_ = 0; > this assertion failed for me under load, it appears that somehow we are som Did you figure this out? -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 8 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 23 Feb 2018 02:09:44 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 8 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Patch Set 8: Verified+1 IWYU failure from ancestor patch -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 8 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 23 Feb 2018 00:11:45 + Gerrit-HasComments: No
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9329 ) Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/9329/7/src/kudu/util/debug-util.cc File src/kudu/util/debug-util.cc: http://gerrit.cloudera.org:8080/#/c/9329/7/src/kudu/util/debug-util.cc@715 PS7, Line 715: CHECK(!infos_[i].stack.HasCollected()) << infos_[i].status.ToString(); this assertion failed for me under load, it appears that somehow we are sometimes racing against the other thread collecting stacks here -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 7 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 21 Feb 2018 20:39:34 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9329 to look at the new patch set (#4). Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks Previously a bunch of logic to collect all the stacks from the process was in the /stacks path handler. This logic is relatively generic and shouldn't be intermingled with the formatting code. In particular I'd like to use it in the diagnostics log, where a different output format is desirable. Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 --- M src/kudu/server/default_path_handlers.cc M src/kudu/server/diagnostics_log.cc M src/kudu/util/debug-util-test.cc M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h 5 files changed, 190 insertions(+), 112 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/9329/4 -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 4 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9329 to look at the new patch set (#3). Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks Previously a bunch of logic to collect all the stacks from the process was in the /stacks path handler. This logic is relatively generic and shouldn't be intermingled with the formatting code. In particular I'd like to use it in the diagnostics log, where a different output format is desirable. Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 --- M src/kudu/server/default_path_handlers.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/diagnostics_log.h M src/kudu/util/debug-util-test.cc M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h 6 files changed, 184 insertions(+), 112 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/9329/3 -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 3 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9329 to look at the new patch set (#2). Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks Previously a bunch of logic to collect all the stacks from the process was in the /stacks path handler. This logic is relatively generic and shouldn't be intermingled with the formatting code. In particular I'd like to use it in the diagnostics log, where a different output format is desirable. Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 --- M src/kudu/server/default_path_handlers.cc M src/kudu/server/diagnostics_log.cc M src/kudu/server/diagnostics_log.h M src/kudu/server/server_base.cc M src/kudu/util/debug-util-test.cc M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h M src/kudu/util/logging.cc M src/kudu/util/trace.cc 9 files changed, 200 insertions(+), 119 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/9329/2 -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 2 Gerrit-Owner: Todd LipconGerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley
[kudu-CR] KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9329 to review the following change. Change subject: KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks .. KUDU-2297 (part 3): refactor process-wide stack collection out of /stacks Previously a bunch of logic to collect all the stacks from the process was in the /stacks path handler. This logic is relatively generic and shouldn't be intermingled with the formatting code. In particular I'd like to use it in the diagnostics log, where a different output format is desirable. Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 --- M src/kudu/server/default_path_handlers.cc M src/kudu/util/debug-util-test.cc M src/kudu/util/debug-util.cc M src/kudu/util/debug-util.h 4 files changed, 178 insertions(+), 105 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/9329/1 -- To view, visit http://gerrit.cloudera.org:8080/9329 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb7c6edd31254f3d7e0cbef1eaf575bde3570df6 Gerrit-Change-Number: 9329 Gerrit-PatchSet: 1 Gerrit-Owner: Todd LipconGerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley