[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has removed a vote on this change. Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9601 To

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. KUDU-2305: Limit sidecars to INT_MAX and fortify

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 9: Verified+1 Code-Review+2 -- To view, visit

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-21 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 8: (3 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-21 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9601 to look at the new patch set (#9). Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 8: Code-Review+1 (3 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 7: (4 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-20 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9601 to look at the new patch set (#8). Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-20 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 7: (4 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 7: Testing locally, I do not see the errors

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-20 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 6: Rebase to get related change to

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-19 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9601 to look at the new patch set (#6). Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 5: TSAN introduces memory overhead. It looks

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-19 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: (5 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-19 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Dan Burkert, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9601 to look at the new patch set (#4). Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-18 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-16 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: (4 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: (2 comments) Thanks for the comments,

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-16 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-16 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: This is needed for Impala's KRPC work. Is

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 3: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9601 to look at the new patch set (#3). Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: (3 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: (2 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-14 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 2: I'm having trouble reproducing the

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-13 Thread Joe McDonnell (Code Review)
Hello Michael Ho, Kudu Jenkins, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9601 to look at the new patch set (#2). Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-13 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 1: (6 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 1: (6 comments)

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 1: The test failure on

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9601 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 1: There are probably some comments that

[kudu-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-03-12 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9601 Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. KUDU-2305: Limit sidecars to INT_MAX and fortify socket