[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/10434 )

Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr
..

KUDU-2427: relax dlsym call to dl_iterate_phdr

When gcc passes --as-needed to ld by default, dynamically linked test
binaries that don't directly reference symbols in kudu_util may end up
loading libc before loading kudu_util. This causes dlsym(RTLD_NEXT, ...) on
libc symbols to fail because libc falls earlier in the symbol search order.

At first I thought this was a new problem in Ubuntu 18.04, but I was able to
reproduce it in Ubuntu 16.04 too; the only difference is that in Ubuntu
16.04 the failure isn't reported via dlerror() so we never noticed it. Given
that, I figured it'd be okay to make it non-fatal across the board.

Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
Reviewed-on: http://gerrit.cloudera.org:8080/10434
Reviewed-by: Todd Lipcon 
Tested-by: Adar Dembo 
---
M src/kudu/util/debug/unwind_safeness.cc
1 file changed, 33 insertions(+), 6 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Adar Dembo: Verified

--
To view, visit http://gerrit.cloudera.org:8080/10434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
Gerrit-Change-Number: 10434
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10434 )

Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr
..


Patch Set 3: Verified+1

Overriding Jenkins, known Java flakes.


--
To view, visit http://gerrit.cloudera.org:8080/10434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
Gerrit-Change-Number: 10434
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 17 May 2018 18:08:11 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

[Adar Dembo (Code Review)]

Adar Dembo has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/10434 )

Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
Gerrit-Change-Number: 10434
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10434 )

Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/10434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
Gerrit-Change-Number: 10434
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Thu, 17 May 2018 17:51:16 +
Gerrit-HasComments: No

[kudu-CR] KUDU-2427: relax dlsym call to dl iterate phdr

[Adar Dembo (Code Review)]

Hello Todd Lipcon,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/10434

to review the following change.


Change subject: KUDU-2427: relax dlsym call to dl_iterate_phdr
..

KUDU-2427: relax dlsym call to dl_iterate_phdr

When gcc passes --as-needed to ld by default, dynamically linked test
binaries that don't directly reference symbols in kudu_util may end up
loading libc before loading kudu_util. This causes dlsym(RTLD_NEXT, ...) on
libc symbols to fail because libc falls earlier in the symbol search order.

At first I thought this was a new problem in Ubuntu 18.04, but I was able to
reproduce it in Ubuntu 16.04 too; the only difference is that in Ubuntu
16.04 the failure isn't reported via dlerror() so we never noticed it. Given
that, I figured it'd be okay to make it non-fatal across the board.

Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
---
M src/kudu/util/debug/unwind_safeness.cc
1 file changed, 33 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/10434/1
--
To view, visit http://gerrit.cloudera.org:8080/10434
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1795847740b1201c46331b6a64a96631ecbcea36
Gerrit-Change-Number: 10434
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon