[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-07-10 Thread Grant Henke (Code Review) 
Grant Henke has abandoned this change. ( http://gerrit.cloudera.org:8080/15939 )

Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4
..


Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/15939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
Gerrit-Change-Number: 15939
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-21 Thread Grant Henke (Code Review) 
Hello Tidy Bot, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15939

to look at the new patch set (#4).

Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4
..

KUDU-2817: Upgrade Protobuf to 3.11.4

This patch upgrades Protobuf from 3.4.1 to 3.11.4. This aligns
the C++ Protobuf version with the version used in the Java client.

As a part of the upgrade I adjusted our build to use the `cpp`
source tar instead of the `all` source tar, which reduces the
size of thirdparty because it doesn’t include all the other
language sources. I also updated some usage of deprecated
methods.

See the release notes here:
https://github.com/protocolbuffers/protobuf/releases

Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
---
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/serialization.h
M src/kudu/tablet/ops/op_tracker.cc
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/protobuf_util.h
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
26 files changed, 72 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/15939/4
--
To view, visit http://gerrit.cloudera.org:8080/15939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
Gerrit-Change-Number: 15939
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-21 Thread Grant Henke (Code Review) 
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15939 )

Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4
..


Patch Set 2:

(8 comments)

http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/consensus/consensus_queue.cc
File src/kudu/consensus/consensus_queue.cc:

http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/consensus/consensus_queue.cc@696
PS1, Line 696: int64_t max_batch_size =
> warning: narrowing conversion from 'unsigned long' to signed type 'int' is
Done


http://gerrit.cloudera.org:8080/#/c/15939/2/src/kudu/consensus/log-test-base.h
File src/kudu/consensus/log-test-base.h:

http://gerrit.cloudera.org:8080/#/c/15939/2/src/kudu/consensus/log-test-base.h@91
PS2, Line 91:   *size += repl->ByteSizeLong() + 1;
> warning: narrowing conversion from 'unsigned long' to signed type 'int' is
Done


http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/rpc/exactly_once_rpc-test.cc
File src/kudu/rpc/exactly_once_rpc-test.cc:

http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/rpc/exactly_once_rpc-test.cc@402
PS1, Line 402: int64_t expected_incremental_usage =
> warning: narrowing conversion from 'unsigned long' to signed type 'int' is
Done


http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/rpc/result_tracker.h
File src/kudu/rpc/result_tracker.h:

http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/rpc/result_tracker.h@286
PS1, Line 286:   + (response != nullptr ? 
static_cast(response->SpaceUsedLong()) : 0);
> warning: redundant get() call on smart pointer [readability-redundant-smart
Done


http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/rpc/serialization.cc
File src/kudu/rpc/serialization.cc:

http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/rpc/serialization.cc@58
PS1, Line 58:   size_t pb_size = use_cached_size ?
> warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed
Done


http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/rpc/serialization.cc@58
PS1, Line 58:   size_t pb_size = use_cached_size ?
> warning: narrowing conversion from 'unsigned long' to signed type 'int' is
Done


http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/util/pb_util.cc
File src/kudu/util/pb_util.cc:

http://gerrit.cloudera.org:8080/#/c/15939/1/src/kudu/util/pb_util.cc@483
PS1, Line 483:   uint8* end = msg.SerializeWithCachedSizesToArray(start);
> warning: narrowing conversion from 'long' to signed type 'int' is implement
Done


http://gerrit.cloudera.org:8080/#/c/15939/2/src/kudu/util/pb_util.cc
File src/kudu/util/pb_util.cc:

http://gerrit.cloudera.org:8080/#/c/15939/2/src/kudu/util/pb_util.cc@89
PS2, Line 89: using google::protobuf::StrCat;
> warning: using decl 'StrCat' is unused [misc-unused-using-decls]
Done



--
To view, visit http://gerrit.cloudera.org:8080/15939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
Gerrit-Change-Number: 15939
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 21 May 2020 19:17:15 +
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-21 Thread Grant Henke (Code Review) 
Hello Tidy Bot, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15939

to look at the new patch set (#3).

Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4
..

KUDU-2817: Upgrade Protobuf to 3.11.4

This patch upgrades Protobuf from 3.4.1 to 3.11.4. This aligns
the C++ Protobuf version with the version used in the Java client.

As a part of the upgrade I adjusted our build to use the `cpp`
source tar instead of the `all` source tar, which reduces the
size of thirdparty because it doesn’t include all the other
language sources. I also updated some usage of deprecated
methods.

See the release notes here:
https://github.com/protocolbuffers/protobuf/releases

Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
---
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/serialization.h
M src/kudu/tablet/ops/op_tracker.cc
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/protobuf_util.h
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
26 files changed, 73 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/15939/3
--
To view, visit http://gerrit.cloudera.org:8080/15939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
Gerrit-Change-Number: 15939
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-21 Thread Grant Henke (Code Review) 
Hello Tidy Bot, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15939

to look at the new patch set (#2).

Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4
..

KUDU-2817: Upgrade Protobuf to 3.11.4

This patch upgrades Protobuf from 3.4.1 to 3.11.4. This aligns
the C++ Protobuf version with the version used in the Java client.

As a part of the upgrade I adjusted our build to use the `cpp`
source tar instead of the `all` source tar, which reduces the
size of thirdparty because it doesn’t include all the other
language sources. I also updated some usage of deprecated
methods.

See the release notes here:
https://github.com/protocolbuffers/protobuf/releases

Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
---
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_cache.h
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/serialization.h
M src/kudu/tablet/ops/op_tracker.cc
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/protobuf_util.h
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
25 files changed, 59 insertions(+), 52 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/15939/2
--
To view, visit http://gerrit.cloudera.org:8080/15939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
Gerrit-Change-Number: 15939
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] KUDU-2817: Upgrade Protobuf to 3.11.4

2020-05-17 Thread Grant Henke (Code Review) 
Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15939


Change subject: KUDU-2817: Upgrade Protobuf to 3.11.4
..

KUDU-2817: Upgrade Protobuf to 3.11.4

This patch upgrades Protobuf from 3.4.1 to 3.11.4. This aligns
the C++ Protobuf version with the version used in the Java client.

As a part of the upgrade I adjusted our build to use the `cpp`
source tar instead of the `all` source tar, which reduces the
size of thirdparty because it doesn’t include all the other
language sources. I also updated some usage of deprecated
methods.

See the release notes here:
https://github.com/protocolbuffers/protobuf/releases

Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
---
M src/kudu/cfile/bloomfile.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_cache.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/rpc/exactly_once_rpc-test.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/result_tracker.h
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/serialization.h
M src/kudu/tablet/ops/op_tracker.cc
M src/kudu/tablet/tablet_metadata-test.cc
M src/kudu/tserver/tablet_copy_source_session-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/protobuf_util.h
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
23 files changed, 52 insertions(+), 50 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/15939/1
--
To view, visit http://gerrit.cloudera.org:8080/15939
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc7ef2af17a350d05665baf002e00b1adc8db71a
Gerrit-Change-Number: 15939
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke