[kudu-CR] KUDU-3297 fix Thrift client used for HMS integration
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17958 ) Change subject: KUDU-3297 fix Thrift client used for HMS integration .. KUDU-3297 fix Thrift client used for HMS integration As it turns out, in the context of KUDU-3297, the SASL negotiation code needs to be updated in one more place: src/kudu/thrift/sasl_client_transport.cc I also thought about unifying the code between the Thrift client and the RPC code to have a single place to have the correct ordering between the calls EnableProtection() and sasl_client_start(), but after some consideration I realized it's not worth it. As for the testing, I verified that before this patch the following scenarios in hms_client-test were failing every time when running on RedHat/CentOS 8.4: * ProtectionTypes/HmsClientTest.TestHmsOperations/1 * ProtectionTypes/HmsClientTest.TestHmsOperations/3 * ProtectionTypes/HmsClientTest.TestLargeObjects/1 * ProtectionTypes/HmsClientTest.TestLargeObjects/3 The output of the failed test scenarios always contained the following: Bad status: Runtime error: failed to open Hive Metastore connection: SASL(-15): mechanism too weak for this user: With this patch, all scenarios of the hms_client-test pass when running on RedHat/CentOS 8.4: This is a follow-up to fff48ea4e5eadd365a85a05a82f66b3eb76d0b0b. Change-Id: Ic6af12932647eda7092f9f42a57eb211fe31f062 Reviewed-on: http://gerrit.cloudera.org:8080/17958 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar Reviewed-by: Abhishek Chennaka Reviewed-by: Attila Bukor --- M src/kudu/rpc/client_negotiation.cc M src/kudu/thrift/sasl_client_transport.cc 2 files changed, 14 insertions(+), 11 deletions(-) Approvals: Kudu Jenkins: Verified Bankim Bhavsar: Looks good to me, but someone else must approve Abhishek Chennaka: Looks good to me, but someone else must approve Attila Bukor: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic6af12932647eda7092f9f42a57eb211fe31f062 Gerrit-Change-Number: 17958 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3297 fix Thrift client used for HMS integration
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17958 ) Change subject: KUDU-3297 fix Thrift client used for HMS integration .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6af12932647eda7092f9f42a57eb211fe31f062 Gerrit-Change-Number: 17958 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Oct 2021 18:10:09 + Gerrit-HasComments: No
[kudu-CR] KUDU-3297 fix Thrift client used for HMS integration
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17958 ) Change subject: KUDU-3297 fix Thrift client used for HMS integration .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6af12932647eda7092f9f42a57eb211fe31f062 Gerrit-Change-Number: 17958 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Oct 2021 18:08:07 + Gerrit-HasComments: No
[kudu-CR] KUDU-3297 fix Thrift client used for HMS integration
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17958 ) Change subject: KUDU-3297 fix Thrift client used for HMS integration .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/17958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic6af12932647eda7092f9f42a57eb211fe31f062 Gerrit-Change-Number: 17958 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Abhishek Chennaka Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Greg Solovyev Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 21 Oct 2021 17:39:23 + Gerrit-HasComments: No
[kudu-CR] KUDU-3297 fix Thrift client used for HMS integration
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17958 Change subject: KUDU-3297 fix Thrift client used for HMS integration .. KUDU-3297 fix Thrift client used for HMS integration As it turns out, in the context of KUDU-3297, the SASL negotiation code needs to be updated in one more place: src/kudu/thrift/sasl_client_transport.cc I also thought about unifying the code between the Thrift client and the RPC code to have a single place to have the correct ordering between the calls EnableProtection() and sasl_client_start(), but after some consideration I realized it's not worth it. As for the testing, I verified that before this patch the following scenarios in hms_client-test were failing every time when running on RedHat/CentOS 8.4: * ProtectionTypes/HmsClientTest.TestHmsOperations/1 * ProtectionTypes/HmsClientTest.TestHmsOperations/3 * ProtectionTypes/HmsClientTest.TestLargeObjects/1 * ProtectionTypes/HmsClientTest.TestLargeObjects/3 The output of the failed test scenarios always contained the following: Bad status: Runtime error: failed to open Hive Metastore connection: SASL(-15): mechanism too weak for this user: With this patch, all scenarios of the hms_client-test pass when running on RedHat/CentOS 8.4: This is a follow-up to fff48ea4e5eadd365a85a05a82f66b3eb76d0b0b. Change-Id: Ic6af12932647eda7092f9f42a57eb211fe31f062 --- M src/kudu/rpc/client_negotiation.cc M src/kudu/thrift/sasl_client_transport.cc 2 files changed, 14 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/17958/1 -- To view, visit http://gerrit.cloudera.org:8080/17958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6af12932647eda7092f9f42a57eb211fe31f062 Gerrit-Change-Number: 17958 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin