[kudu-CR] KUDU-3326 correct error messages in tool usage instructions
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21266 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. KUDU-3326 correct error messages in tool usage instructions This patch mainly fixes the error messages in the recall tool as follows: ` Usage: kudu table recall [-new_table_name=] ` We expect to recall tables in soft delete state using the table ID, not the tablet ID. The correct output is as follows: ` Usage: kudu table recall [-new_table_name=] ` This is just about correcting the errors in the prompts and does not involve any related recall logic. Therefore, there are no additional unit tests added. Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Reviewed-on: http://gerrit.cloudera.org:8080/21266 Reviewed-by: Alexey Serbin Tested-by: Alexey Serbin --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_table.cc 3 files changed, 4 insertions(+), 2 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Gerrit-Change-Number: 21266 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-3326 correct error messages in tool usage instructions
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21266 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/21266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Gerrit-Change-Number: 21266 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Apr 2024 15:35:15 + Gerrit-HasComments: No
[kudu-CR] KUDU-3326 correct error messages in tool usage instructions
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21266 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Gerrit-Change-Number: 21266 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Apr 2024 15:32:06 + Gerrit-HasComments: No
[kudu-CR] KUDU-3326 correct error messages in tool usage instructions
KeDeng has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21266 ) Change subject: KUDU-3326 correct error messages in tool usage instructions .. KUDU-3326 correct error messages in tool usage instructions This patch mainly fixes the error messages in the recall tool as follows: ` Usage: kudu table recall [-new_table_name=] ` We expect to recall tables in soft delete state using the table ID, not the tablet ID. The correct output is as follows: ` Usage: kudu table recall [-new_table_name=] ` This is just about correcting the errors in the prompts and does not involve any related recall logic. Therefore, there are no additional unit tests added. Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f --- M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_table.cc 3 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/21266/2 -- To view, visit http://gerrit.cloudera.org:8080/21266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib1c6df0806eee78280b00f6a528d42d434a63e2f Gerrit-Change-Number: 21266 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng
