[kudu-CR] KUDU-625 - Make write transctions abort in mvcc, by default
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: KUDU-625 - Make write transctions abort in mvcc, by default .. KUDU-625 - Make write transctions abort in mvcc, by default This patch addresses a long standing TODO where we would commit transactions on the WriteTransactionState dctor instead of aborting them. Besides changing WriteTransactionState::Reset() to call CommitOrAbort(Transaction::ABORTED) this also required that we change TabletBootstrap to explicitely call tx_state.CommitOrAbort(Transaction::COMMITTED) in PlayWriteRequest(). I ran raft_consensus-itest and exactly_once_writes-itest in slow mode, asan, for 1000 loops on dist-test. No failures. Results: exactly_once_writes-itest: http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678 raft_consensus-itest : http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678 Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9 --- M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/transactions/write_transaction.cc 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/5320/2 -- To view, visit http://gerrit.cloudera.org:8080/5320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-625 - Make write transctions abort in mvcc, by default
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5320 Change subject: KUDU-625 - Make write transctions abort in mvcc, by default .. KUDU-625 - Make write transctions abort in mvcc, by default This patch addresses a long standing TODO where we would commit transactions on the WriteTransactionState dctor instead of aborting them. Besides changing WriteTransactionState::Reset() to call CommitOrAbort(Transaction::ABORTED) this also required that we change TabletBootstrap to explicitely call tx_state.CommitOrAbort(Transaction::COMMITTED) in PlayWriteRequest(). I ran raft_consensus-itest and exactly_once_writes-itest in slow mode, asan, for 1000 loops on dist-test. Results: exactly_once_writes-itest: http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678 raft_consensus-itest : http://dist-test.cloudera.org//job?job_id=david.alves.1480657298.6678 Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9 --- M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/transactions/write_transaction.cc 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/5320/1 -- To view, visit http://gerrit.cloudera.org:8080/5320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I22be773081ca3f3b1eab029e847a21e3182c64c9 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves
