[kudu-CR] KuduSession: do not advertise thread-safety
Dan Burkert has submitted this change and it was merged. Change subject: KuduSession: do not advertise thread-safety .. KuduSession: do not advertise thread-safety Do not advertise thread-safety of KuduSession methods for the Kudu C++ client, even if they are thread-safe de facto. This is to have one set of semantics for both C++ and Java Kudu client libraries (corresponding methods of the Java client are not thread-safe). Besides, current use cases for the Kudu client assume that operations with KuduSession object do not involve multiple threads. Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Reviewed-on: http://gerrit.cloudera.org:8080/4105 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert --- M docs/release_notes.adoc M src/kudu/client/client.h 2 files changed, 4 insertions(+), 13 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KuduSession: do not advertise thread-safety
Dan Burkert has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KuduSession: do not advertise thread-safety
Alexey Serbin has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4105/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1011: /// @note This class is not thread-safe except where otherwise specified. > Should this be removed too? Replaced with 'This class is not thread-safe.' per Dan's recommendation. PS2, Line 1011: /// @note This class is not thread-safe except where otherwise specified. > or change it to Done, thanks! -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KuduSession: do not advertise thread-safety
Kudu Jenkins has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3046/ -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KuduSession: do not advertise thread-safety
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4105 to look at the new patch set (#3). Change subject: KuduSession: do not advertise thread-safety .. KuduSession: do not advertise thread-safety Do not advertise thread-safety of KuduSession methods for the Kudu C++ client, even if they are thread-safe de facto. This is to have one set of semantics for both C++ and Java Kudu client libraries (corresponding methods of the Java client are not thread-safe). Besides, current use cases for the Kudu client assume that operations with KuduSession object do not involve multiple threads. Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd --- M docs/release_notes.adoc M src/kudu/client/client.h 2 files changed, 4 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/4105/3 -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KuduSession: do not advertise thread-safety
Dan Burkert has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4105/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1011: /// @note This class is not thread-safe except where otherwise specified. > Should this be removed too? or change it to @note This class is not thread-safe. -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KuduSession: do not advertise thread-safety
Adar Dembo has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4105/2/src/kudu/client/client.h File src/kudu/client/client.h: PS2, Line 1011: /// @note This class is not thread-safe except where otherwise specified. Should this be removed too? -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] KuduSession: do not advertise thread-safety
Alexey Serbin has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 1: > Out of good hygiene, we should release-note this as an incompatible > change, just in case anyone's using the C++ client in a > multi-threaded manner. Good catch! I added a note in docs/release_notes.adoc for 1.0.0 in the subsequent patch. Please take a look. -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KuduSession: do not advertise thread-safety
Kudu Jenkins has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3041/ -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KuduSession: do not advertise thread-safety
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4105 to look at the new patch set (#2). Change subject: KuduSession: do not advertise thread-safety .. KuduSession: do not advertise thread-safety Do not advertise thread-safety of KuduSession methods for the Kudu C++ client, even if they are thread-safe de facto. This is to have one set of semantics for both C++ and Java Kudu client libraries (corresponding methods of the Java client are not thread-safe). Besides, current use cases for the Kudu client assume that operations with KuduSession object do not involve multiple threads. Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd --- M docs/release_notes.adoc M src/kudu/client/client.h 2 files changed, 3 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/4105/2 -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Binglin Chang Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] KuduSession: do not advertise thread-safety
Todd Lipcon has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 1: Out of good hygiene, we should release-note this as an incompatible change, just in case anyone's using the C++ client in a multi-threaded manner. -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] KuduSession: do not advertise thread-safety
Kudu Jenkins has posted comments on this change. Change subject: KuduSession: do not advertise thread-safety .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3038/ -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KuduSession: do not advertise thread-safety
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4105 Change subject: KuduSession: do not advertise thread-safety .. KuduSession: do not advertise thread-safety Do not advertise thread-safety of KuduSession methods for the Kudu C++ client, even if they are thread-safe de facto. This is to have one set of semantics for both C++ and Java Kudu client libraries (corresponding methods of the Java client are not thread-safe). Besides, current use cases for the Kudu client assume that operations with KuduSession object do not involve multiple threads. Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd --- M src/kudu/client/client.h 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/4105/1 -- To view, visit http://gerrit.cloudera.org:8080/4105 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b3fcbd0d6446ccddce7a1812260c692eba18fcd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin
