[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has submitted this change and it was merged.

Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..


Patch gperftools to be able to work on macOS Sierra/XCode 8

Apparently gperftools needs to be patched for tcmalloc to work
with the new clang version that ships with XCode 8, but the fix
hasn't landed yet.

This patch fixes that and was copied verbatim from:
https://github.com/gperftools/gperftools/issues/827

Note that this fix is virtually identical to the one merged into
jemalloc, which had the same problem:
https://github.com/jemalloc/jemalloc/pull/427/commits/19c9a3e828ed46f1576521c264640e60bd0cb01f

Finally it's noteworthy that this is an macOS/OS X only
fix and, as such, doesn't affect released binaries.

Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
Reviewed-on: http://gerrit.cloudera.org:8080/4495
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
A 
thirdparty/patches/gperftools-issue-827-add_get_default_zone_to_osx_libc_override.patch
2 files changed, 50 insertions(+), 1 deletion(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has uploaded a new patch set (#2).

Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..

Patch gperftools to be able to work on macOS Sierra/XCode 8

Apparently gperftools needs to be patched for tcmalloc to work
with the new clang version that ships with XCode 8, but the fix
hasn't landed yet.

This patch fixes that and was copied verbatim from:
https://github.com/gperftools/gperftools/issues/827

Note that this fix is virtually identical to the one merged into
jemalloc, which had the same problem:
https://github.com/jemalloc/jemalloc/pull/427/commits/19c9a3e828ed46f1576521c264640e60bd0cb01f

Finally it's noteworthy that this is an macOS/OS X only
fix and, as such, doesn't affect released binaries.

Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
---
M thirdparty/download-thirdparty.sh
A 
thirdparty/patches/gperftools-issue-827-add_get_default_zone_to_osx_libc_override.patch
2 files changed, 50 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/4495/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4495/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

PS1, Line 127: 2
> Need to change this to 3.
yeah, my guess is that this wasn't a problem cuz no macOS jenkins


PS1, Line 135: gperftools-add_get_default_zone_to_osx_libc_override
> Maybe you can rename the patch so that it explicitly refers to the gperftoo
makes sense. Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4495/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

PS1, Line 127: 2
Need to change this to 3.


PS1, Line 135: gperftools-add_get_default_zone_to_osx_libc_override
Maybe you can rename the patch so that it explicitly refers to the gperftools 
issue number in the name? That way it'll be easier to figure out if we still 
need it later. See "glog-issue-198-fix-unused-warnings.patch".


-- 
To view, visit http://gerrit.cloudera.org:8080/4495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Patch gperftools to be able to work on macOS Sierra/XCode 8

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4495

Change subject: Patch gperftools to be able to work on macOS Sierra/XCode 8
..

Patch gperftools to be able to work on macOS Sierra/XCode 8

Apparently gperftools needs to be patched for tcmalloc to work
with the new clang version that ships with XCode 8, but the fix
hasn't landed yet.

This patch fixes that and was copied verbatim from:
https://github.com/gperftools/gperftools/issues/827

Note that this fix is virtually identical to the one merged into
jemalloc, which had the same problem:
https://github.com/jemalloc/jemalloc/pull/427/commits/19c9a3e828ed46f1576521c264640e60bd0cb01f

Finally it's noteworthy that this is an macOS/OS X only
fix and, as such, doesn't affect released binaries.

Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/gperftools-add_get_default_zone_to_osx_libc_override.patch
2 files changed, 49 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/4495/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie00d9fad36d1746aa94da3b1711353110da42d95
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves