[kudu-CR] Revert "KUDU-1490: Show software version of tablet servers"
Mike Percy has abandoned this change. Change subject: Revert "KUDU-1490: Show software version of tablet servers" .. Abandoned Adar, not sure a commit message is the right place to have that kind of a policy discussion. Probably the dev list to be honest. Anyway it turns out this is not actually a hard downgrade problem. Todd you are right that this only affects rolling upgrades / downgrades. Not very serious at this stage in the game. I'm going to abandon this patch. -- To view, visit http://gerrit.cloudera.org:8080/4060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8a873a01404ae04018511bd2899b8a510df71722 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Revert "KUDU-1490: Show software version of tablet servers"
Todd Lipcon has posted comments on this change. Change subject: Revert "KUDU-1490: Show software version of tablet servers" .. Patch Set 1: This is necessary for _rolling downgrade_ but shouldn't be necessary for a "turn everything off and restart with the old version" downgrade, right? The check only happens if you have a new master running, and you restart a tablet server with a different version. I think this would also constrain our ability to do rolling uprgade (must upgrade TS before masters) -- To view, visit http://gerrit.cloudera.org:8080/4060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a873a01404ae04018511bd2899b8a510df71722 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-1490: Show software version of tablet servers"
Adar Dembo has posted comments on this change. Change subject: Revert "KUDU-1490: Show software version of tablet servers" .. Patch Set 1: Why is downgrade support more important than this? A frank discussion of the trade-offs seems worthwhile in the commit message. -- To view, visit http://gerrit.cloudera.org:8080/4060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a873a01404ae04018511bd2899b8a510df71722 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-1490: Show software version of tablet servers"
Kudu Jenkins has posted comments on this change. Change subject: Revert "KUDU-1490: Show software version of tablet servers" .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2992/ -- To view, visit http://gerrit.cloudera.org:8080/4060 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a873a01404ae04018511bd2899b8a510df71722 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-1490: Show software version of tablet servers"
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4060
Change subject: Revert "KUDU-1490: Show software version of tablet servers"
..
Revert "KUDU-1490: Show software version of tablet servers"
This reverts commit 1b7abe081817b5f9af979407df105a08dd226521.
After reverting this commit and applying the previous patch, downgrade
works.
The reason for the problem is that there is some validation in
TSDescriptor::Register() in ts_descriptor.cc on line 65
that returns an error if the ShortDebugString() of two TSDescriptor
objects must not change between registrations. Since this adds a field,
that check is triggered. If you downgrade, you get the following error
message over and over on the master:
E0819 01:56:10.421804 32374 ts_descriptor.cc:73] Tablet server
e1b61aaede6844049378351a3eb42f73 is attempting to re-register with a different
host/port. This is not currently supported.
Old: {rpc_addresses { host: "mpercy-ThinkPad-T530" port: 7050 } http_addresses
{ host: "mpercy-ThinkPad-T530" port: 8050 } 3: "kudu 0.10.0 (rev
4686cc4f11a03507f8eca5ee7cc1653d323dba72)"}
New: {rpc_addresses { host: "mpercy-ThinkPad-T530" port: 7050 } http_addresses
{ host: "mpercy-ThinkPad-T530" port: 8050 }}
Change-Id: I8a873a01404ae04018511bd2899b8a510df71722
---
M src/kudu/integration-tests/registration-test.cc
M src/kudu/master/master.proto
M src/kudu/tserver/heartbeater.cc
3 files changed, 2 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/4060/1
--
To view, visit http://gerrit.cloudera.org:8080/4060
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a873a01404ae04018511bd2899b8a510df71722
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy
