[kudu-CR] Revert "env: change various file filename() functions to return copies"

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged.

Change subject: Revert "env: change various file filename() functions to return 
copies"
..


Revert "env: change various file filename() functions to return copies"

I didn't end up needing this flexibility in the file cache implementation,
and returning references is cheaper.

This reverts commit e836ac18df2ec2405a61aa7a9a90d61ee30716c5.

Change-Id: Ib920fc9a418dcfdf35ba1b038f288ca2ee98343a
Reviewed-on: http://gerrit.cloudera.org:8080/5318
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert 
---
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/pb_util.h
5 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/5318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib920fc9a418dcfdf35ba1b038f288ca2ee98343a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Revert "env: change various file filename() functions to return copies"

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: Revert "env: change various file filename() functions to return 
copies"
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/5318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib920fc9a418dcfdf35ba1b038f288ca2ee98343a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Revert "env: change various file filename() functions to return copies"

[Adar Dembo (Code Review)]

Hello Dan Burkert, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/5318

to review the following change.

Change subject: Revert "env: change various file filename() functions to return 
copies"
..

Revert "env: change various file filename() functions to return copies"

I didn't end up needing this flexibility in the file cache implementation,
and returning references is cheaper.

This reverts commit e836ac18df2ec2405a61aa7a9a90d61ee30716c5.

Change-Id: Ib920fc9a418dcfdf35ba1b038f288ca2ee98343a
---
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/pb_util.h
5 files changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/18/5318/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5318
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib920fc9a418dcfdf35ba1b038f288ca2ee98343a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon