[kudu-CR] WIP: support for running Java tests in dist-test
Todd Lipcon has abandoned this change. ( http://gerrit.cloudera.org:8080/7579 ) Change subject: WIP: support for running Java tests in dist-test .. Abandoned got committed by https://gerrit.cloudera.org/c/10907/ -- To view, visit http://gerrit.cloudera.org:8080/7579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451 Gerrit-Change-Number: 7579 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] WIP: support for running Java tests in dist-test
Hello Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10907 to look at the new patch set (#2). Change subject: WIP: support for running Java tests in dist-test .. WIP: support for running Java tests in dist-test Probably not worth a serious review yet, since this has a few failing tests. However, it maybe worth glancing over the "big idea". Sample usage: $ python build-support/dist_test.py java run-all $ python build-support/dist_test.py java loop --num-instances 10 *AsyncKuduSession* Change-Id: I446a15192a45e296b323a4c7d305f236e22ab557 --- M build-support/dist_test.py M build-support/run-test.sh M build-support/run_dist_test.py M java/build.gradle M java/buildSrc/build.gradle A java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java 6 files changed, 434 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/10907/2 -- To view, visit http://gerrit.cloudera.org:8080/10907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I446a15192a45e296b323a4c7d305f236e22ab557 Gerrit-Change-Number: 10907 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP: support for running Java tests in dist-test
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10907 Change subject: WIP: support for running Java tests in dist-test .. WIP: support for running Java tests in dist-test Probably not worth a serious review yet, since this has a few failing tests yet. However, it maybe worth glancing over the "big idea". Sample usage: $ python build-support/dist_test.py java run-all $ python build-support/dist_test.py java loop --num-instances 10 *AsyncKuduSession* Change-Id: I446a15192a45e296b323a4c7d305f236e22ab557 --- M build-support/dist_test.py M build-support/run-test.sh M build-support/run_dist_test.py M java/build.gradle M java/buildSrc/build.gradle A java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java 6 files changed, 434 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/10907/1 -- To view, visit http://gerrit.cloudera.org:8080/10907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I446a15192a45e296b323a4c7d305f236e22ab557 Gerrit-Change-Number: 10907 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Andrew Wong
[kudu-CR] WIP: support for running Java tests in dist-test
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7579 ) Change subject: WIP: support for running Java tests in dist-test .. Patch Set 2: Rebased and updated to get it working on ve0518 -- To view, visit http://gerrit.cloudera.org:8080/7579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451 Gerrit-Change-Number: 7579 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Thu, 21 Jun 2018 05:04:20 + Gerrit-HasComments: No
[kudu-CR] WIP: support for running Java tests in dist-test
Andrew Wong has uploaded a new patch set (#2) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/7579 ) Change subject: WIP: support for running Java tests in dist-test .. WIP: support for running Java tests in dist-test Probably not worth a serious review yet, since this has a few hacks and one of the tests is still failing when run in this environment, but maybe worth glancing over the "big idea". Sample usage: $ python dist_test.py java loop 10 *AsyncKuduSession* Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451 --- M build-support/dist_test.py M build-support/run-test.sh M build-support/run_dist_test.py M java/build.gradle M java/buildSrc/build.gradle A java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java M java/gradle/shadow.gradle M java/gradle/tests.gradle A java/kudu-flume-sink/src/test/resources/testAvroKuduOperationsProducer.avsc 9 files changed, 423 insertions(+), 21 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/7579/2 -- To view, visit http://gerrit.cloudera.org:8080/7579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451 Gerrit-Change-Number: 7579 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP: support for running Java tests in dist-test
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/9932 ) Change subject: WIP: support for running Java tests in dist-test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: If6de6042e818e265a5e4382786eaee5d576aa6f7 Gerrit-Change-Number: 9932 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP: support for running Java tests in dist-test
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9932 Change subject: WIP: support for running Java tests in dist-test .. WIP: support for running Java tests in dist-test Probably not worth a serious review yet, since this has a few hacks and one of the tests is still failing when run in this environment, but maybe worth glancing over the "big idea". Latest rebase of https://gerrit.cloudera.org/#/c/7579/. Change-Id: If6de6042e818e265a5e4382786eaee5d576aa6f7 --- M build-support/dist_test.py M build-support/run-test.sh M build-support/run_dist_test.py M java/build.gradle M java/buildSrc/build.gradle A java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java M java/gradle/shadow.gradle M java/gradle/tests.gradle A java/kudu-flume-sink/src/test/resources/testAvroKuduOperationsProducer.avsc 9 files changed, 415 insertions(+), 27 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/9932/1 -- To view, visit http://gerrit.cloudera.org:8080/9932 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If6de6042e818e265a5e4382786eaee5d576aa6f7 Gerrit-Change-Number: 9932 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao
[kudu-CR] WIP: support for running Java tests in dist-test
Grant Henke has posted comments on this change. Change subject: WIP: support for running Java tests in dist-test .. Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/7579/1//COMMIT_MSG Commit Message: Line 10: one of the tests is still failing when run in this environment, but What's failing? I would be happy to help with this. http://gerrit.cloudera.org:8080/#/c/7579/1/build-support/run_dist_test.py File build-support/run_dist_test.py: Line 200: # i.e the presence of the '.gradle' in the user's home directory outside of the Kudu You can set the GRADLE_USER_HOME environment variable, gradle.user.home system property, or --gradle-user-home command line parameter to change where the .gradle is placed. Would that help? I am not sure I grok the issue. http://gerrit.cloudera.org:8080/#/c/7579/1/java/build.gradle File java/build.gradle: Line 51: task distTest(type: DistTestTask) { Would adding this task to the `tests.gradle` file make sense? Its already applied to each subproject. http://gerrit.cloudera.org:8080/#/c/7579/1/java/gradle/shadow.gradle File java/gradle/shadow.gradle: Line 110: } Nit. White space. http://gerrit.cloudera.org:8080/#/c/7579/1/java/gradle/tests.gradle File java/gradle/tests.gradle: Line 25 Nit. Move this comment about the testLogging line now. Line 83: check.dependsOn(integrationTest) Nit. White space. http://gerrit.cloudera.org:8080/#/c/7579/1/java/kudu-flume-sink/src/test/resources/testAvroKuduOperationsProducer.avsc File java/kudu-flume-sink/src/test/resources/testAvroKuduOperationsProducer.avsc: Line 1: {"namespace": "org.apache.kudu.flume.sink", Looks like this exists already here: java/kudu-flume-sink/src/test/avro/testAvroKuduOperationsProducer.avsc Does it need to be moved? -- To view, visit http://gerrit.cloudera.org:8080/7579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] WIP: support for running Java tests in dist-test
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7579 to review the following change. Change subject: WIP: support for running Java tests in dist-test .. WIP: support for running Java tests in dist-test Probably not worth a serious review yet, since this has a few hacks and one of the tests is still failing when run in this environment, but maybe worth glancing over the "big idea". Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451 --- M build-support/dist_test.py M build-support/run-test.sh M build-support/run_dist_test.py M java/build.gradle A java/buildSrc/build.gradle A java/buildSrc/src/main/groovy/org/apache/kudu/gradle/DistTestTask.java M java/gradle/shadow.gradle M java/gradle/tests.gradle A java/kudu-flume-sink/src/test/resources/testAvroKuduOperationsProducer.avsc 9 files changed, 417 insertions(+), 23 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/7579/1 -- To view, visit http://gerrit.cloudera.org:8080/7579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I163c3d88b0cfbb6c2aa9af3af5a308c4196c0451 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Grant Henke