[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has abandoned this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Abandoned

Obsoleted by https://gerrit.cloudera.org/#/c/14414/
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 7:

(22 comments)

http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@34
PS7, Line 34: * Flume 1.8+ requires Java 8 at runtime even though the Kudu 
Flume integration
:   is Java 7 compatible. Flume 1.9 is the default dependency 
version as of
:   Kudu 1.9.0.
:
: * Hadoop 3.0+ requires Java 8 at runtime even though the Kudu 
Hadoop integration
:   is Java 7 compatible. Hadoop 3.2 is the default dependency 
version as of
:   Kudu 1.9.0.
> Should probably modify these bits too. See KUDU-2099 for more details on th
Ah, great.  I removed this sice Java8 is already a requirement in Kudu 1.10.0


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@48
PS7, Line 48: * `TabletLocationsPB.ReplicaPB` has been deprecated since Kudu 
1.11.0 in both
:   {cpp} and Java Kudu clients. The server side still recognizes 
the
:   `TabletLocationsPB.ReplicaPB` message for backward 
compatibility with clients
:   of prior versions.
> While accurate, we should try to describe this in concrete user-facing term
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@52
PS7, Line 52:
: * Support for Java 7 has been deprecated since Kudu 1.5.0 and may 
be removed in
:   the next major release.
> Java 7 support was removed in 1.10.0. Not sure why this carried over into h
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@59
PS7, Line 59: While a tablet
:   server is in maintenance, its downtime does not automatically 
trigger
:   re-replication of its replicas
> Nit: perhaps "While in this mode, the tablet server's replicas will not be
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@68
PS7, Line 68: With the built-in NTP
:   client enabled
> Nit: "When enabled,"
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@69
PS7, Line 69: it's no longer required to keep the system clock of Kudu
:   nodes synchronzed with NTP (might be useful in case of 
containerized
:   deployments)
> Nit: "system clock synchronization for nodes running Kudu is no longer nece
The idea was to mention that the built-in NTP client might be useful for 
containerized deployments.


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@71
PS7, Line 71: With the built-in NTP client enabled, the internal wallclock
:   is synchronized with NTP servers specified with the 
`--builtin_ntp_servers`
:   flag. By default, the built-in NTP client uses public servers 
of the
:   `pool.ntp.org` project
> Nit: "The list of NTP servers to synchronize against is specified with the
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@75
PS7, Line 75:   `0.pool.ntp.org,1.pool.ntp.org,2.pool.ntp.org,3.pool.ntp.org`
> I don't think we need to get this specific; just referencing pool.ntp.org i
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@75
PS7, Line 75: To switch Kudu
:   masters and tablet servers to use the built-in NTP client, add
:   `--time_source=builtin` into the set of their flags, 
customizing the
:   `--builtin_ntp_servers` flag if necessary
:   (see 
link:https://issues.apache.org/jira/browse/KUDU-2935[KUDU-2935]).
:
> Nit: "To use the built-in NTP client, set `--time_source=builtin` and recon
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@81
PS7, Line 81: via
:   GetTableStatistics master's RPC
> Let's refer to specific APIs rather than to RPCs, as users interact with th
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@87
PS7, Line 87: uuid
> Should we surround this with triangular brackets to emphasize that it's not
Done


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@91
PS7, Line 91: * The `kudu` CLI tool now supports altering and dropping table 
columns. Using
:   the newly introduced `kudu table delete_column` sub-command, 
it's possible to
:   drop a column of the specified table. The newly introduced 
commands such as
:   `kudu table column_set_default`, `kudu table 
column_remove_default`,
:   `kudu table column_set_compression`, `kudu table 
column_set_encoding`,
:   and `kudu table column_set_block_size` allows for altering a 
column of the
:   specified table correspondingly.
> Given the asymmetry between 

[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-11 Thread Alexey Serbin (Code Review)
Hello honeyhexin, Attila Bukor, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, 
Grant Henke, Greg Solovyev, Hao Hao, Volodymyr Verovkin, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14404

to look at the new patch set (#8).

Change subject: WIP [docs] Kudu 1.11 release notes draft
..

WIP [docs] Kudu 1.11 release notes draft

The rendered version is available at:
  https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f

WIP:
  * this is published just as working draft to iterate upon
  * the branch is wrong (should be in branch-1.11.x): DO NOT COMMIT
into the master branch

Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
---
M docs/release_notes.adoc
1 file changed, 191 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/8
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 8
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 7:

(22 comments)

http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@34
PS7, Line 34: * Flume 1.8+ requires Java 8 at runtime even though the Kudu 
Flume integration
:   is Java 7 compatible. Flume 1.9 is the default dependency 
version as of
:   Kudu 1.9.0.
:
: * Hadoop 3.0+ requires Java 8 at runtime even though the Kudu 
Hadoop integration
:   is Java 7 compatible. Hadoop 3.2 is the default dependency 
version as of
:   Kudu 1.9.0.
Should probably modify these bits too. See KUDU-2099 for more details on the 
removal of Java 7 support.


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@48
PS7, Line 48: * `TabletLocationsPB.ReplicaPB` has been deprecated since Kudu 
1.11.0 in both
:   {cpp} and Java Kudu clients. The server side still recognizes 
the
:   `TabletLocationsPB.ReplicaPB` message for backward 
compatibility with clients
:   of prior versions.
While accurate, we should try to describe this in concrete user-facing terms. 
Is there any? Won't new clients operate correctly against old servers, and vice 
versa? If so, there's probably nothing worth mentioning here.


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@52
PS7, Line 52:
: * Support for Java 7 has been deprecated since Kudu 1.5.0 and may 
be removed in
:   the next major release.
Java 7 support was removed in 1.10.0. Not sure why this carried over into here.


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@59
PS7, Line 59: While a tablet
:   server is in maintenance, its downtime does not automatically 
trigger
:   re-replication of its replicas
Nit: perhaps "While in this mode, the tablet server's replicas will not be 
rereplicated if it fails. Only upon exiting maintenance will re-replication be 
triggered for any remaining under-replicated tablets."


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@68
PS7, Line 68: With the built-in NTP
:   client enabled
Nit: "When enabled,"


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@69
PS7, Line 69: it's no longer required to keep the system clock of Kudu
:   nodes synchronzed with NTP (might be useful in case of 
containerized
:   deployments)
Nit: "system clock synchronization for nodes running Kudu is no longer 
necessary, though it might still be useful for containerized deployments."


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@71
PS7, Line 71: With the built-in NTP client enabled, the internal wallclock
:   is synchronized with NTP servers specified with the 
`--builtin_ntp_servers`
:   flag. By default, the built-in NTP client uses public servers 
of the
:   `pool.ntp.org` project
Nit: "The list of NTP servers to synchronize against is specified with the 
`--builtin_ntp_servers` flag. By default, Kudu will use public servers hosted 
by the NTP Pool project."


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@75
PS7, Line 75:   `0.pool.ntp.org,1.pool.ntp.org,2.pool.ntp.org,3.pool.ntp.org`
I don't think we need to get this specific; just referencing pool.ntp.org is 
good enough.


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@75
PS7, Line 75: To switch Kudu
:   masters and tablet servers to use the built-in NTP client, add
:   `--time_source=builtin` into the set of their flags, 
customizing the
:   `--builtin_ntp_servers` flag if necessary
:   (see 
link:https://issues.apache.org/jira/browse/KUDU-2935[KUDU-2935]).
:
Nit: "To use the built-in NTP client, set `--time_source=builtin` and 
reconfigure `--builtin_ntp_servers` if necessary (see KUDU-2935)."


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@81
PS7, Line 81: via
:   GetTableStatistics master's RPC
Let's refer to specific APIs rather than to RPCs, as users interact with the 
former but not the latter.


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@87
PS7, Line 87: uuid
Should we surround this with triangular brackets to emphasize that it's not a 
string literal, but a variable?


http://gerrit.cloudera.org:8080/#/c/14404/7/docs/release_notes.adoc@91
PS7, Line 91: * The `kudu` CLI tool now supports altering and dropping table 
columns. Using
:   the newly introduced `kudu table delete_column` sub-command, 
it's possible to
:   drop a column of the specified table. 

[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-10 Thread Alexey Serbin (Code Review)
Hello honeyhexin, Attila Bukor, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, 
Grant Henke, Greg Solovyev, Hao Hao, Volodymyr Verovkin, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14404

to look at the new patch set (#7).

Change subject: WIP [docs] Kudu 1.11 release notes draft
..

WIP [docs] Kudu 1.11 release notes draft

The rendered version is available at:
  https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f

WIP:
  * this is published just as working draft to iterate upon
  * the branch is wrong (should be in branch-1.11.x): DO NOT COMMIT
into the master branch

Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
---
M docs/release_notes.adoc
1 file changed, 186 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/7
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-10 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc@157
PS6, Line 157: * A quick-start example of using Apache Spark to load, query, 
and modify
> nit: I'd change these two bullet points to active voice
Done


http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc@188
PS6, Line 188: * Decoding of deltas' timestamps has been optimized
> "Optimized decoding of deltas' timestamps" - I'd use active voice instead o
Done



--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 
Gerrit-Comment-Date: Fri, 11 Oct 2019 00:19:54 +
Gerrit-HasComments: Yes


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-10 Thread Greg Solovyev (Code Review)
Greg Solovyev has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc@157
PS6, Line 157: * A quick-start example of using Apache Spark to load, query, 
and modify
nit: I'd change these two bullet points to active voice


http://gerrit.cloudera.org:8080/#/c/14404/6/docs/release_notes.adoc@188
PS6, Line 188: * Decoding of deltas' timestamps has been optimized
"Optimized decoding of deltas' timestamps" - I'd use active voice instead of 
passive, because it is shorter and because we use it in most other items.



--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 
Gerrit-Comment-Date: Thu, 10 Oct 2019 22:42:04 +
Gerrit-HasComments: Yes


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-10 Thread Alexey Serbin (Code Review)
Hello honeyhexin, Attila Bukor, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, 
Grant Henke, Greg Solovyev, Hao Hao, Volodymyr Verovkin, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14404

to look at the new patch set (#6).

Change subject: WIP [docs] Kudu 1.11 release notes draft
..

WIP [docs] Kudu 1.11 release notes draft

The rendered version is available at:
  https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f

WIP:
  * this is published just as working draft to iterate upon
  * the branch is wrong: DO NOT COMMIT

Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
---
M docs/release_notes.adoc
1 file changed, 187 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/6
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Alexey Serbin (Code Review)
Hello honeyhexin, Attila Bukor, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, 
Grant Henke, Greg Solovyev, Hao Hao, Volodymyr Verovkin, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14404

to look at the new patch set (#5).

Change subject: WIP [docs] Kudu 1.11 release notes draft
..

WIP [docs] Kudu 1.11 release notes draft

The rendered version is available at:
  https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f

WIP:
  * this is published just as working draft to iterate upon
  * the branch is wrong: DO NOT COMMIT

Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
---
M docs/release_notes.adoc
1 file changed, 187 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/5
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14404/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14404/3//COMMIT_MSG@7
PS3, Line 7: WIP [docs] Kudu 1.11 release notes draft
> Could you also post to your own github branch and post a link so reviewers
Done

https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@123
PS1, Line 123:
 : * The --master_client_location_assignment_enabled master's flag 
is now
 :   available for usage without the necessity to add 
--unlock_unsafe_flags.
> Actually upon looking at the commits, I thought the default behavior has ch
Ah, maybe getting rid of this item might be the best option :)   You are right.

Done.



--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 
Gerrit-Comment-Date: Thu, 10 Oct 2019 01:52:46 +
Gerrit-HasComments: Yes


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 3:

(14 comments)

http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@51
PS1, Line 51:
> Ah you're right. I think the "interned replica" behavior itself was impleme
Ack


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@127
PS1, Line 127: lient_locat
> My concern isn't about tense. "are now able" and "are able" don't really ma
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@133
PS1, Line 133: d tablet's data directory group
> Thanks! Yeah, while the previous behavior isn't gone now, I might have foun
Ack


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@196
PS1, Line 196: Optimized the initialization of DeltaMemStore for the case when 
no matching
 :   deltas are present
 :   (see 
link:https://issues.apache.org/jira/browse/KUDU-2381[KUDU-2381]).
 :
 : * Scan tokens are now rehydrated so a scan token created before 
renaming
 :   a column can be used even after the
> Yep, much better. Some tweaks to limit the redundancy (you mention frequent
That sounds good, thanks.  Updated.

With that blurb about heavy load to tablet servers, I was trying to get an 
example of conditions where the manifestation of the bug could be seen 
(election storms).  Indeed, I think we can drop that since if removing the 
mention of tablet servers, the seconds sentence simply re-phrases the same 
information.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@204
PS1, Line 204: /`NOT NULL` predicates to leverage SIMD instructions
> SGTM
Ack


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@272
PS1, Line 272:   vice-versa.
> Ah, you're right. For some reason, one of my commits from a while ago shows
Ack


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@100
PS3, Line 100: m
> nit: the, same below
Done


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@140
PS3, Line 140: initiated
> nit: "initiating", or "that initiated"
Done


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@179
PS3, Line 179:  with specified dimension
> nit: "with a dimension"? "with a specific dimension"?
Done


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@212
PS3, Line 212: was contributing to the frequent leader change phenomenon
 :   (a.k.a. election storms)
> nit: could lead to frequent elections.
As discussed, I removed this sentence.


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@216
PS3, Line 216:  case if b
> nit: "in cases where"
Done


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@232
PS3, Line 232:  Kudu
> nit: the Kudu
Done


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@240
PS3, Line 240: pending AlterSchema
 :   transaction.
> nit: plurality is off, "pending `AlterSchema` transactions"? "a pending `Al
Done


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@296
PS3, Line 296: * honeyhexin
> On Slack, she goes by Xin He.
Thanks!  Updated.



--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 
Gerrit-Comment-Date: Thu, 10 Oct 2019 01:47:07 +
Gerrit-HasComments: Yes


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Alexey Serbin (Code Review)
Hello honeyhexin, Attila Bukor, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, 
Grant Henke, Greg Solovyev, Hao Hao, Volodymyr Verovkin, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14404

to look at the new patch set (#4).

Change subject: WIP [docs] Kudu 1.11 release notes draft
..

WIP [docs] Kudu 1.11 release notes draft

The rendered version is available at:
  https://gist.github.com/alexeyserbin/53200325d07f4c922682580489e3d45f

WIP:
  * this is published just as working draft to iterate upon
  * the branch is wrong: DO NOT COMMIT

Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
---
M docs/release_notes.adoc
1 file changed, 193 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/4
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 3:

(16 comments)

http://gerrit.cloudera.org:8080/#/c/14404/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14404/3//COMMIT_MSG@7
PS3, Line 7: WIP [docs] Kudu 1.11 release notes draft
Could you also post to your own github branch and post a link so reviewers can 
read a rendered version?


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@51
PS1, Line 51:
> Why?  d8aeab7f97a76275e6f7f647099c5b339961c623 is not in 1.10
Ah you're right. I think the "interned replica" behavior itself was implemented 
in 1.10, not the deprecation.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@123
PS1, Line 123:
 : * Tablet server Web UI now supports sorting the list of tables 
by the columns
 :   of "Table Name", "Create Time", and "Last Alter Time".
> Done
Actually upon looking at the commits, I thought the default behavior has 
changed, but only the tagging has changed.

Omitting the second sentence should be fine, I think. Or maybe elaborate on why 
a user might want to set this to false. It's not clear upon reading this why 
this is an improvement.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@127
PS1, Line 127: lient_locat
> I prefer present tense.
My concern isn't about tense. "are now able" and "are able" don't really make 
clear that the behavior always happens.

How about: "Maybe Tablet servers now expand a tablet's data directory groups 
with available healthy directories when all directories of that tablet's group 
are full."


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@133
PS1, Line 133: d tablet's data directory group
> I described why it's beneficial.
Thanks! Yeah, while the previous behavior isn't gone now, I might have found 
myself wondering why this was an improvement, because I might have thought we 
would be taking into account location awareness somehow.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@196
PS1, Line 196: Optimized the initialization of DeltaMemStore for the case when 
no matching
 :   deltas are present
 :   (see 
link:https://issues.apache.org/jira/browse/KUDU-2381[KUDU-2381]).
 :
 : * Scan tokens are now rehydrated so a scan token created before 
renaming
 :   a column can be used even after the
> Yep, there is nothing mentioned about tablet server specifics, right.
Yep, much better. Some tweaks to limit the redundancy (you mention frequent 
leader changes a couple times), how does this sound:

Fixed an issue that would cause frequent leader elections when Raft 
transactions to the WAL took longer than the leader election timeout to persist.

Though why was heavy load to tablet servers important? And isn't it not 
specific to tablet servers? Or was it that heavy load could contribute to a 
slow WAL?


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@204
PS1, Line 204: /`NOT NULL` predicates to leverage SIMD instructions
> I changed it to:
SGTM


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@272
PS1, Line 272:   vice-versa.
> Thanks. There is one more, I think: honeyhexin
Ah, you're right. For some reason, one of my commits from a while ago shows up 
when I search her name (seems she was a reviewer): 
https://gerrit.cloudera.org/c/11614/


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@100
PS3, Line 100: m
nit: the, same below


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@140
PS3, Line 140: initiated
nit: "initiating", or "that initiated"


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@179
PS3, Line 179:  with specified dimension
nit: "with a dimension"? "with a specific dimension"?


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@212
PS3, Line 212: was contributing to the frequent leader change phenomenon
 :   (a.k.a. election storms)
nit: could lead to frequent elections.


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@216
PS3, Line 216:  case if b
nit: "in cases where"


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@232
PS3, Line 232:  Kudu
nit: the Kudu


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@240
PS3, Line 240: pending AlterSchema
 :   transaction.
nit: plurality is off, "pending `AlterSchema` transactions"? "a pending 
`AlterSchema` transaction?


http://gerrit.cloudera.org:8080/#/c/14404/3/docs/release_notes.adoc@296
PS3, 

[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 3:

(28 comments)

http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@51
PS1, Line 51:
> I think it was deprecated in 1.10
Why?  d8aeab7f97a76275e6f7f647099c5b339961c623 is not in 1.10


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@51
PS1, Line 51: with clients of earlier ver
> nit: wrap with ``s so it shows up as monospaced code font.
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@63
PS1, Line 63:   tablet server maintenance, and the `kudu tserver list` tool is 
amended with
:   a "state" column option to display current state of each tablet 
server
> Kudu now supports putting tablet servers into maintenance. While a tablet s
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@66
PS1, Line 66:
> nit: a built-in
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@66
PS1, Line 66:
> Might be worth trying to describe what the user should expect if switching
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@73
PS1, Line 73: roject:
> This might be confusing since it might make it seem like the flag is tagged
Removed 'run-time'


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@74
PS1, Line 74: ol.ntp.org`. To switch Kudu
:   masters and tablet servers to use the built-in NTP client, add
:   `--time_source=builtin` into the set of their flags, 
customizing the
:   `--builtin_ntp_servers` flag as well i
> nit: This seems like a lot of detail for a release note. Maybe we should ad
Removed the details.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@82
PS1, Line 82: now
> nit: "will" so it's obvious that this isn't optional. Or "can now optionall
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@83
PS1, Line 83: ar
> are
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@97
PS1, Line 97:
> nit: `kudu table` tool? Or say that new tools `kudu table get_extra_configs
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@111
PS1, Line 111:
> nit: CFileReaders (plural), and maybe we wrap these in quotes. I.e. as "CFi
Done.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@113
PS1, Line 113: * The `kudu fs dump uuid` CLI tool is now significantly faster 
and consumes
 :   significantly less IO.
 :
 : * The memory consumed by CFileReaders and BloomFileReaders is 
factored o
> Not sure this deserves a release note unless there are user-facing ways to
Yep, that's fair.  Removed.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@123
PS1, Line 123:
 : * Tablet server Web UI now supports sorting the list of tables 
by the columns
 :   of "Table Name", "Create Time", and "Last Alter Time".
> We should note that this has been enabled by default and maybe drop the men
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@127
PS1, Line 127: lient_locat
> nit: "will now" so it's obvious this is new non-optional behavior
I prefer present tense.

Replaced with 'are now able ...'


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@133
PS1, Line 133: d tablet's data directory group
> nit: "in case no replica is local"
I described why it's beneficial.

I think it would be too much details to describe the previous strange behavior, 
especially given the fact it's no longer relevant.  But I mentioned what it 
might looked like in prior version.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@135
PS1, Line 135:   tablet's group are full
 :   (see 
link:https://issues.apache.org/jira/browse/KUDU-2907[KUDU-2907]).
 :
> Maybe, "The serialization of in-memory rows to Kudu's wire format has been
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@144
PS1, Line 144: /issues.apa
> nit: capitalize these
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@159
PS1, Line 159: for ta
> nit: previous? Unless this behavior can still be achieved somehow
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@163
PS1, Line 163: a real data set has been added.
> Does this happen by default? If so, use "will now" instead of "can", and if
Done


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@164
PS1, Line 164:
> I don't think this is the right link
It's link:https://issues.apache.org/jira/browse/KUDU-2823 , indeed.



[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Alexey Serbin (Code Review)
Hello honeyhexin, Attila Bukor, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, 
Grant Henke, Greg Solovyev, Hao Hao, Volodymyr Verovkin, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14404

to look at the new patch set (#3).

Change subject: WIP [docs] Kudu 1.11 release notes draft
..

WIP [docs] Kudu 1.11 release notes draft

WIP:
  * this is published just as working draft to iterate upon
  * the branch is wrong: DO NOT COMMIT

Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
---
M docs/release_notes.adoc
1 file changed, 193 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/3
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14404 )

Change subject: WIP [docs] Kudu 1.11 release notes draft
..


Patch Set 2:

(28 comments)

http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@51
PS1, Line 51: 11
I think it was deprecated in 1.10


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@51
PS1, Line 51: TabletLocationsPB.ReplicaPB
nit: wrap with ``s so it shows up as monospaced code font.

Same with gflag and other object names below.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@63
PS1, Line 63: * TODO Kudu now supports maintenance mode
:   (see 
link:https://issues.apache.org/jira/browse/KUDU-2069[KUDU-2069]).
Kudu now supports putting tablet servers into maintenance. While a tablet 
server is in maintenance, its downtime will not automatically trigger 
re-replication of its replicas. The `kudu tserver state enter_maintenance` and 
`kudu tserver state exit_maintenance` tools are added to orchestrate tablet 
server maintenance, and the `kudu tserver list` tool is amended with a "state" 
column option to display current state of each tablet server.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@66
PS1, Line 66:  b
nit: a built-in


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@66
PS1, Line 66: *
Might be worth trying to describe what the user should expect if switching over 
to the built-in client. Faster NTP convergence? No system privileges required? 
Anything else?


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@73
PS1, Line 73: f their run-time flags
This might be confusing since it might make it seem like the flag is tagged 
"runtime".


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@74
PS1, Line 74:  The initial implementation
:   of the built-in NTP client is not RFC-compliant at this point, 
but it is good
:   enough to work with well-behaved NTP servers. For details on 
further
:   improvements, see the sub-tasks of the
nit: This seems like a lot of detail for a release note. Maybe we should add 
docs for this and point the release notes at the docs? Perhaps in the 
Configuring Kudu page?


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@82
PS1, Line 82: can
nit: "will" so it's obvious that this isn't optional. Or "can now optionally" 
if it is


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@83
PS1, Line 83: ar
are


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@97
PS1, Line 97:
nit: `kudu table` tool? Or say that new tools `kudu table get_extra_configs` 
and `kudu table set_extra_config` are introduced. That way the tools are more 
easily discovered.

Same with `drop_range_partition`


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@111
PS1, Line 111:
nit: CFileReaders (plural), and maybe we wrap these in quotes. I.e. as 
"CFileReaders" and "BloomFileReaders"


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@113
PS1, Line 113: * The memory consumed by CFileReaders and BloomFileReaders is 
factored out and
 :   accounted separately by the tablet server memory tracking. The 
stats are
 :   available via tablet server Web UI as CFileReader and 
BloomFileReaders
 :   entries.
Not sure this deserves a release note unless there are user-facing ways to 
leverage this.


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@123
PS1, Line 123:   (see 
link:https://issues.apache.org/jira/browse/KUDU-1561[KUDU-1561]).
 :
 : * Tablet server Web UI now supports sorting the list of tables 
by the col
We should note that this has been enabled by default and maybe drop the mention 
of `--unlock_unsafe_flags`?


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@127
PS1, Line 127:
nit: "will now" so it's obvious this is new non-optional behavior


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@133
PS1, Line 133:
nit: "in case no replica is local"

Also maybe note the previous behavior this replaces? Or why this is beneficial? 
I believe it's to prevent hotspotting?


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@135
PS1, Line 135:
 : * For scan operations run with CLOSEST_REPLICA selection mode, 
Kudu Java client
 :   now picks a random available replica in case if no replica is 
local
Maybe, "The serialization of in-memory rows to Kudu's wire format has been 
optimized to be more CPU efficient."?


http://gerrit.cloudera.org:8080/#/c/14404/1/docs/release_notes.adoc@144
PS1, Line 144:  now possib
nit: capitalize these



[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Alexey Serbin (Code Review)
Hello honeyhexin, Attila Bukor, Kudu Jenkins, Andrew Wong, Yao Xu, Adar Dembo, 
Grant Henke, Greg Solovyev, Hao Hao, Volodymyr Verovkin, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14404

to look at the new patch set (#2).

Change subject: WIP [docs] Kudu 1.11 release notes draft
..

WIP [docs] Kudu 1.11 release notes draft

WIP:
  * this is published just as working draft to iterate upon
  * the branch is wrong: DO NOT COMMIT

Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
---
M docs/release_notes.adoc
1 file changed, 170 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/2
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Attila Bukor 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Greg Solovyev 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: Volodymyr Verovkin 
Gerrit-Reviewer: Yao Xu 
Gerrit-Reviewer: honeyhexin 


[kudu-CR] WIP [docs] Kudu 1.11 release notes draft

2019-10-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14404


Change subject: WIP [docs] Kudu 1.11 release notes draft
..

WIP [docs] Kudu 1.11 release notes draft

WIP:
  * this is published just as working draft to iterate upon
  * the branch is wrong: DO NOT COMMIT

Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
---
M docs/release_notes.adoc
1 file changed, 161 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/14404/1
--
To view, visit http://gerrit.cloudera.org:8080/14404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I201f4e07504d59e668b99d6154c9412ed79c9d35
Gerrit-Change-Number: 14404
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin