[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..

auto_rebalancer: ignore deleted tables

The auto-rebalancer would previously not do any rebalancing if any of
the tables in the cluster were deleted, since the tablets of these
tables would not be RUNNING. This updates the auto-rebalancer to ignore
such tables.

Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Reviewed-on: http://gerrit.cloudera.org:8080/15970
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M src/kudu/master/auto_rebalancer-test.cc
M src/kudu/master/auto_rebalancer.cc
2 files changed, 104 insertions(+), 15 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 7
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@685
PS4, Line 685:   GetTableLocationsResponsePB table_locs;
 :   ASSERT_OK(GetTableLocations(cluster_->master_proxy(), 
kNewTableName,
 :   MonoDelta::FromSeconds(10), 
ReplicaTypeFilter::ANY_REPLICA,
 :   /*table_id*/boost::none, 
_locs));
 :   unordered_set deleted_tablet_ids;
 :   for (const auto& t : table_locs.tablet_locations()) {
 : EmplaceIfNotPresent(_tablet_ids, t.tablet_id());
 :   }
 :   ASSERT_OK(workload_->client()->DeleteTable(kNewTableName));
 :
 :   // Add a new tablet server and restart the stopped server so 
the rebalancer
 :   // can proceed.
 :   ASS
> This wasn't testing that, but I can update it to check that.
Ah, great.  Thank you for doing this!



--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 21 May 2020 05:28:34 +
Gerrit-HasComments: Yes


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Hannah Nguyen, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15970

to look at the new patch set (#6).

Change subject: auto_rebalancer: ignore deleted tables
..

auto_rebalancer: ignore deleted tables

The auto-rebalancer would previously not do any rebalancing if any of
the tables in the cluster were deleted, since the tablets of these
tables would not be RUNNING. This updates the auto-rebalancer to ignore
such tables.

Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
---
M src/kudu/master/auto_rebalancer-test.cc
M src/kudu/master/auto_rebalancer.cc
2 files changed, 104 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/6
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 6
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@647
PS4, Line 647: or (const auto& str : post_capture_l
> nit: it would be nice to add an extra sentence to explain what is the desir
Done


http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@685
PS4, Line 685:   ASSERT_OK(GetTableLocations(cluster_->master_proxy(), 
kNewTableName,
 :   MonoDelta::FromSeconds(10), 
ReplicaTypeFilter::ANY_REPLICA,
 :   /*table_id*/boost::none, 
_locs));
 :   unordered_set deleted_tablet_ids;
 :   for (const auto& t : table_locs.tablet_locations()) {
 : EmplaceIfNotPresent(_tablet_ids, t.tablet_id());
 :   }
 :   ASSERT_OK(workload_->client()->DeleteTable(kNewTableName));
 :
 :   // Add a new tablet server and restart the stopped server so 
the rebalancer
 :   // can proceed.
 :   ASSERT_OK(cluster_->AddTabletServer());
 :   ASS
> Does it give a guarantee that the replicas of the deleted table were not at
This wasn't testing that, but I can update it to check that.


http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer.cc
File src/kudu/master/auto_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer.cc@498
PS4, Line 498: const SysTablesEntryPB& table_data = 
table->metadata().state().pb;
 : if (table_data.state() == SysTablesEntryPB::REMOVED) {
 :   // Don't worry about rebalancing replicas that belong to 
deleted tables.
 :   continue;
 : }
 : TableSummary table_summary;
 : t
> nit: does it make sense to re-order the lines to avoid instantiating 'table
Done



--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 May 2020 03:17:11 +
Gerrit-HasComments: Yes


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hannah Nguyen, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15970

to look at the new patch set (#5).

Change subject: auto_rebalancer: ignore deleted tables
..

auto_rebalancer: ignore deleted tables

The auto-rebalancer would previously not do any rebalancing if any of
the tables in the cluster were deleted, since the tablets of these
tables would not be RUNNING. This updates the auto-rebalancer to ignore
such tables.

Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
---
M src/kudu/master/auto_rebalancer-test.cc
M src/kudu/master/auto_rebalancer.cc
2 files changed, 103 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/5
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@647
PS4, Line 647: Test rebalancing with deleted tables
nit: it would be nice to add an extra sentence to explain what is the desired 
behavior of the auto-rebalancer w.r.t. deleted tables, like do we simply want 
to make sure it doesn't stall; doesn't attempt to move replicas of the deleted 
tables, etc.?


http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer-test.cc@685
PS4, Line 685:   // Even though not all tables are running, this should succeed 
because the
 :   // table that isn't running has been deleted.
 :   ASSERT_EVENTUALLY([&] {
 : int bytes_sent_in_orig_tservers =
 : AggregateMetricCounts(GetBytesSentByTServer(), 0, 
kNumTServers);
 : ASSERT_GT(bytes_sent_in_orig_tservers, 
initial_bytes_sent_in_orig_tservers);
 :   });
 :   ASSERT_EVENTUALLY([&] {
 : int bytes_fetched_in_new_tservers =
 : AggregateMetricCounts(GetBytesFetchedByTServer(), 
kNumTServers,
 :   cluster_->num_tablet_servers());
 : ASSERT_GT(bytes_fetched_in_new_tservers, 0);
 :   });
Does it give a guarantee that the replicas of the deleted table were not 
attempted to be moved?  Or this test isn't trying to verify that?


http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer.cc
File src/kudu/master/auto_rebalancer.cc:

http://gerrit.cloudera.org:8080/#/c/15970/4/src/kudu/master/auto_rebalancer.cc@498
PS4, Line 498: TableSummary table_summary;
 : table_summary.id = table->id();
 : const SysTablesEntryPB& table_data = 
table->metadata().state().pb;
 : if (table_data.state() == SysTablesEntryPB::REMOVED) {
 :   // Don't worry about rebalancing replicas that belong to 
deleted tables.
 :   continue;
 : }
nit: does it make sense to re-order the lines to avoid instantiating 
'table_summary' at all for the short-circuit case?  Something like:



const SysTablesEntryPB& table_data = table->metadata().state().pb;
if (table_data.state() == SysTablesEntryPB::REMOVED) {
  // Don't worry about rebalancing replicas that belong to deleted tables.
  continue;
}

TableSummary table_summary;
table_summary.id = table->id();



--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 May 2020 02:24:46 +
Gerrit-HasComments: Yes


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hannah Nguyen, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15970

to look at the new patch set (#4).

Change subject: auto_rebalancer: ignore deleted tables
..

auto_rebalancer: ignore deleted tables

The auto-rebalancer would previously not do any rebalancing if any of
the tables in the cluster were deleted, since the tablets of these
tables would not be RUNNING. This updates the auto-rebalancer to ignore
such tables.

Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
---
M src/kudu/master/auto_rebalancer-test.cc
M src/kudu/master/auto_rebalancer.cc
2 files changed, 69 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/4
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 May 2020 00:11:03 +
Gerrit-HasComments: No


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@659
PS2, Line 659:
> SetupWorkload() also creates a table with a default name.
I renamed the method so it's more obvious what it's doing.


http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@679
PS2, Line 679:
> nit: downed?
Went with "stopped"



--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 21 May 2020 00:02:59 +
Gerrit-HasComments: Yes


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hannah Nguyen, Bankim Bhavsar,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15970

to look at the new patch set (#3).

Change subject: auto_rebalancer: ignore deleted tables
..

auto_rebalancer: ignore deleted tables

The auto-rebalancer would previously not do any rebalancing if any of
the tables in the cluster were deleted, since the tablets of these
tables would not be RUNNING. This updates the auto-rebalancer to ignore
such tables.

Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
---
M src/kudu/master/auto_rebalancer-test.cc
M src/kudu/master/auto_rebalancer.cc
2 files changed, 68 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/3
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@679
PS2, Line 679: down
nit: downed?



--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 May 2020 23:25:35 +
Gerrit-HasComments: Yes


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@659
PS2, Line 659: multiple tables
> I took a quick look at the TestWorkload and judging by single set_table_nam
SetupWorkload() also creates a table with a default name.



--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 May 2020 23:24:31 +
Gerrit-HasComments: Yes


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15970 )

Change subject: auto_rebalancer: ignore deleted tables
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc
File src/kudu/master/auto_rebalancer-test.cc:

http://gerrit.cloudera.org:8080/#/c/15970/2/src/kudu/master/auto_rebalancer-test.cc@659
PS2, Line 659: multiple tables
I took a quick look at the TestWorkload and judging by single set_table_name(), 
I see only only 1 table created in Setup().
What am I missing?



--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Bankim Bhavsar 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 20 May 2020 23:23:44 +
Gerrit-HasComments: Yes


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Hannah Nguyen,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15970

to look at the new patch set (#2).

Change subject: auto_rebalancer: ignore deleted tables
..

auto_rebalancer: ignore deleted tables

The auto-rebalancer would previously not do any rebalancing if any of
the tables in the cluster were deleted, since the tablets of these
tables would not be RUNNING. This updates the auto-rebalancer to ignore
such tables.

Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
---
M src/kudu/master/auto_rebalancer-test.cc
M src/kudu/master/auto_rebalancer.cc
2 files changed, 58 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/2
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Hannah Nguyen 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] auto rebalancer: ignore deleted tables

2020-05-20 Thread Andrew Wong (Code Review)
Andrew Wong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15970


Change subject: auto_rebalancer: ignore deleted tables
..

auto_rebalancer: ignore deleted tables

The auto-rebalancer would previously not do any rebalancing if any of
the tables in the cluster were deleted, since the tablets of these
tables would not be RUNNING. This updates the auto-rebalancer to ignore
such tables.

Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
---
M src/kudu/master/auto_rebalancer-test.cc
M src/kudu/master/auto_rebalancer.cc
2 files changed, 57 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/15970/1
--
To view, visit http://gerrit.cloudera.org:8080/15970
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib5499b09c677dd6c1016349398952a1c39820691
Gerrit-Change-Number: 15970
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong