[kudu-CR] c++ client: adjust kudu::client::sp
Adar Dembo has posted comments on this change. Change subject: c++ client: adjust kudu::client::sp .. Patch Set 2: Verified+1 Overriding Jenkins, flaky Java tests. -- To view, visit http://gerrit.cloudera.org:8080/4510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a1ef6319c3464a8ec84f066adc885da200af70 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: adjust kudu::client::sp
Adar Dembo has submitted this change and it was merged. Change subject: c++ client: adjust kudu::client::sp .. c++ client: adjust kudu::client::sp In an upcoming change we'll begin using libc++ on Linux for TSAN builds. As macOS developers are probably aware, libc++ lacks TR1 support, so we need to extend our existing macOS-specific workaround for TR1 shared_ptrs to apply to any libc++ build. This has no bearing on backwards compatibility as libc++ is still only used in non-shipping environments. Change-Id: I01a1ef6319c3464a8ec84f066adc885da200af70 Reviewed-on: http://gerrit.cloudera.org:8080/4510 Reviewed-by: Dan Burkert Tested-by: Adar Dembo --- M src/kudu/client/shared_ptr.h 1 file changed, 7 insertions(+), 10 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/4510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I01a1ef6319c3464a8ec84f066adc885da200af70 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon
[kudu-CR] c++ client: adjust kudu::client::sp
Dan Burkert has posted comments on this change. Change subject: c++ client: adjust kudu::client::sp .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a1ef6319c3464a8ec84f066adc885da200af70 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: adjust kudu::client::sp
Dan Burkert has posted comments on this change. Change subject: c++ client: adjust kudu::client::sp .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a1ef6319c3464a8ec84f066adc885da200af70 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: adjust kudu::client::sp
Todd Lipcon has posted comments on this change. Change subject: c++ client: adjust kudu::client::sp .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01a1ef6319c3464a8ec84f066adc885da200af70 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] c++ client: adjust kudu::client::sp
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4510 to review the following change. Change subject: c++ client: adjust kudu::client::sp .. c++ client: adjust kudu::client::sp In an upcoming change we'll begin using libc++ on Linux for TSAN builds. As macOS developers are probably aware, libc++ lacks TR1 support, so we need to extend our existing macOS-specific workaround for TR1 shared_ptrs to apply to any libc++ build. This has no bearing on backwards compatibility as libc++ is still only used in non-shipping environments. Change-Id: I01a1ef6319c3464a8ec84f066adc885da200af70 --- M src/kudu/client/shared_ptr.h 1 file changed, 7 insertions(+), 10 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/4510/1 -- To view, visit http://gerrit.cloudera.org:8080/4510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I01a1ef6319c3464a8ec84f066adc885da200af70 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon
