[kudu-CR] docs: correct invalid link about schema design

2019-08-21 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14028 )

Change subject: docs: correct invalid link about schema_design
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/14028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Gerrit-Change-Number: 14028
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: XiaokaiWang 
Gerrit-Comment-Date: Thu, 22 Aug 2019 01:19:39 +
Gerrit-HasComments: No


[kudu-CR] docs: correct invalid link about schema design

2019-08-21 Thread Grant Henke (Code Review)
Grant Henke has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14028 )

Change subject: docs: correct invalid link about schema_design
..

docs: correct invalid link about schema_design

Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Reviewed-on: http://gerrit.cloudera.org:8080/14028
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke 
---
M docs/index.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/prior_release_notes.adoc
4 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/14028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Gerrit-Change-Number: 14028
Gerrit-PatchSet: 3
Gerrit-Owner: XiaokaiWang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: XiaokaiWang 


[kudu-CR] docs: correct invalid link about schema design

2019-08-16 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14028 )

Change subject: docs: correct invalid link about schema_design
..


Patch Set 2:

> I see. It looks like there is a correct way to handle this so it
 > works in github and on the official site too.
 >
 > The Impala page has an example of this for the HMS integration:
 > https://github.com/apache/kudu/blob/master/docs/kudu_impala_integration.adoc
 >
 > See < documentation>> for more details

Hello Grant. Updated, please have a look.


--
To view, visit http://gerrit.cloudera.org:8080/14028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Gerrit-Change-Number: 14028
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: XiaokaiWang 
Gerrit-Comment-Date: Fri, 16 Aug 2019 16:20:16 +
Gerrit-HasComments: No


[kudu-CR] docs: correct invalid link about schema design

2019-08-16 Thread XiaokaiWang (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/14028

to look at the new patch set (#2).

Change subject: docs: correct invalid link about schema_design
..

docs: correct invalid link about schema_design

Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
---
M docs/index.adoc
M docs/known_issues.adoc
M docs/kudu_impala_integration.adoc
M docs/prior_release_notes.adoc
4 files changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/14028/2
--
To view, visit http://gerrit.cloudera.org:8080/14028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Gerrit-Change-Number: 14028
Gerrit-PatchSet: 2
Gerrit-Owner: XiaokaiWang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: XiaokaiWang 


[kudu-CR] docs: correct invalid link

2019-08-15 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14028 )

Change subject: docs: correct invalid link
..


Patch Set 1:

I see. It looks like there is a correct way to handle this so it works in 
github and on the official site too.

The Impala page has an example of this for the HMS integration:
https://github.com/apache/kudu/blob/master/docs/kudu_impala_integration.adoc

   See <> for more details


--
To view, visit http://gerrit.cloudera.org:8080/14028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Gerrit-Change-Number: 14028
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: XiaokaiWang 
Gerrit-Comment-Date: Thu, 15 Aug 2019 12:54:50 +
Gerrit-HasComments: No


[kudu-CR] docs: correct invalid link

2019-08-14 Thread XiaokaiWang (Code Review)
XiaokaiWang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14028 )

Change subject: docs: correct invalid link
..


Patch Set 1:

> (1 comment)

Hello Grant. Sorry for the late reply.
I saw it from here: 
https://github.com/apache/kudu/blob/master/docs/schema_design.html


--
To view, visit http://gerrit.cloudera.org:8080/14028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Gerrit-Change-Number: 14028
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: XiaokaiWang 
Gerrit-Comment-Date: Thu, 15 Aug 2019 03:55:02 +
Gerrit-HasComments: No


[kudu-CR] docs: correct invalid link

2019-08-12 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14028 )

Change subject: docs: correct invalid link
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14028/1/docs/known_issues.adoc
File docs/known_issues.adoc:

http://gerrit.cloudera.org:8080/#/c/14028/1/docs/known_issues.adoc@a93
PS1, Line 93:
Where are you seeing this broken? When generating the website we convert adoc 
templates into html. I think this should then be the correct link. 
https://kudu.apache.org/docs/schema_design.html



--
To view, visit http://gerrit.cloudera.org:8080/14028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Gerrit-Change-Number: 14028
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Comment-Date: Mon, 12 Aug 2019 17:45:36 +
Gerrit-HasComments: Yes


[kudu-CR] docs: correct invalid link

2019-08-07 Thread XiaokaiWang (Code Review)
XiaokaiWang has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14028


Change subject: docs: correct invalid link
..

docs: correct invalid link

Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
---
M docs/known_issues.adoc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/14028/1
--
To view, visit http://gerrit.cloudera.org:8080/14028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401
Gerrit-Change-Number: 14028
Gerrit-PatchSet: 1
Gerrit-Owner: XiaokaiWang