[kudu-CR] external mini cluster: adjust single master data directory

2016-08-02 Thread Adar Dembo (Code Review) 
Adar Dembo has submitted this change and it was merged.

Change subject: external_mini_cluster: adjust single master data directory
..


external_mini_cluster: adjust single master data directory

If we stored single master data in "master-0" and not "master", it'd be
possible to reuse single master cluster data in a multi master cluster. This
should be a purely cosmetic change, but I've put it in its own patch to draw
more attention to it in case I'm wrong.

I snuck in a change to remove --enable_leader_failure_detection=true as
that's now the default value.

Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Reviewed-on: http://gerrit.cloudera.org:8080/3810
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/integration-tests/external_mini_cluster.cc
1 file changed, 2 insertions(+), 4 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] external mini cluster: adjust single master data directory

2016-08-02 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: external_mini_cluster: adjust single master data directory
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] external mini cluster: adjust single master data directory

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: external_mini_cluster: adjust single master data directory
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2681/

-- 
To view, visit http://gerrit.cloudera.org:8080/3810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] external mini cluster: adjust single master data directory

2016-07-28 Thread Adar Dembo (Code Review) 
Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3810

Change subject: external_mini_cluster: adjust single master data directory
..

external_mini_cluster: adjust single master data directory

If we stored single master data in "master-0" and not "master", it'd be
possible to reuse single master cluster data in a multi master cluster. This
should be a purely cosmetic change, but I've put it in its own patch to draw
more attention to it in case I'm wrong.

I snuck in a change to remove --enable_leader_failure_detection=true as
that's now the default value.

Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
---
M src/kudu/integration-tests/external_mini_cluster.cc
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/3810/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo

[kudu-CR] external mini cluster: adjust single master data directory

2016-07-28 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: external_mini_cluster: adjust single master data directory
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2678/

-- 
To view, visit http://gerrit.cloudera.org:8080/3810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1cfcd529b14cb2472a8673edbc28dbe66175a8a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No