[kudu-CR] gradle: expose testRandomSeed property
Hello Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11908 to review the following change. Change subject: gradle: expose testRandomSeed property .. gradle: expose testRandomSeed property In order to read a system property in tests, it isn't enough to add a System.getProperty() call to the test; we need to expose the property in gradle so that it's properly passed through to the test. With this patch, testRandomSeed can be set using either -D or -P. Note that even with testRandomSeed overridden, the PRNG didn't produce deterministic results in TestKuduBackup.testRandomBackupAndRestore, but perhaps that's a quirk of Scala's Random class. Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d --- M java/gradle/tests.gradle 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/11908/1 -- To view, visit http://gerrit.cloudera.org:8080/11908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d Gerrit-Change-Number: 11908 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Grant Henke
[kudu-CR] gradle: expose testRandomSeed property
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11908 ) Change subject: gradle: expose testRandomSeed property .. Patch Set 2: Verified+1 Overriding Jenkins, DefaultSourceTest failed three times in TSAN. -- To view, visit http://gerrit.cloudera.org:8080/11908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d Gerrit-Change-Number: 11908 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Nov 2018 19:28:05 + Gerrit-HasComments: No
[kudu-CR] gradle: expose testRandomSeed property
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11908 ) Change subject: gradle: expose testRandomSeed property .. gradle: expose testRandomSeed property In order to read a system property in tests, it isn't enough to add a System.getProperty() call to the test; we need to expose the property in gradle so that it's properly passed through to the test. With this patch, testRandomSeed can be set using either -D or -P. Note that even with testRandomSeed overridden, the PRNG didn't produce deterministic results in TestKuduBackup.testRandomBackupAndRestore, but perhaps that's a quirk of Scala's Random class. Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d Reviewed-on: http://gerrit.cloudera.org:8080/11908 Reviewed-by: Grant Henke Tested-by: Adar Dembo --- M java/gradle/tests.gradle 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Grant Henke: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/11908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d Gerrit-Change-Number: 11908 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke
[kudu-CR] gradle: expose testRandomSeed property
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11908 ) Change subject: gradle: expose testRandomSeed property .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d Gerrit-Change-Number: 11908 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke
[kudu-CR] gradle: expose testRandomSeed property
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11908 ) Change subject: gradle: expose testRandomSeed property .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d Gerrit-Change-Number: 11908 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 08 Nov 2018 19:19:05 + Gerrit-HasComments: No
[kudu-CR] gradle: expose testRandomSeed property
Adar Dembo has posted comments on this change. (
http://gerrit.cloudera.org:8080/11908 )
Change subject: gradle: expose testRandomSeed property
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11908/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
http://gerrit.cloudera.org:8080/#/c/11908/1/java/gradle/tests.gradle@69
PS1, Line 69: if (propertyExists("testRandomSeed")) {
> This can't default to "null". It results in a NumberFormatException when tr
Done
--
To view, visit http://gerrit.cloudera.org:8080/11908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d
Gerrit-Change-Number: 11908
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Nov 2018 18:58:23 +
Gerrit-HasComments: Yes
[kudu-CR] gradle: expose testRandomSeed property
Hello Kudu Jenkins, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11908 to look at the new patch set (#2). Change subject: gradle: expose testRandomSeed property .. gradle: expose testRandomSeed property In order to read a system property in tests, it isn't enough to add a System.getProperty() call to the test; we need to expose the property in gradle so that it's properly passed through to the test. With this patch, testRandomSeed can be set using either -D or -P. Note that even with testRandomSeed overridden, the PRNG didn't produce deterministic results in TestKuduBackup.testRandomBackupAndRestore, but perhaps that's a quirk of Scala's Random class. Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d --- M java/gradle/tests.gradle 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/11908/2 -- To view, visit http://gerrit.cloudera.org:8080/11908 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d Gerrit-Change-Number: 11908 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] gradle: expose testRandomSeed property
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/11908 )
Change subject: gradle: expose testRandomSeed property
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11908/1/java/gradle/tests.gradle
File java/gradle/tests.gradle:
http://gerrit.cloudera.org:8080/#/c/11908/1/java/gradle/tests.gradle@69
PS1, Line 69: systemProperty "testRandomSeed",
propertyWithDefault("testRandomSeed", null)
This can't default to "null". It results in a NumberFormatException when trying
to translate the string to an integer.
Instead I think using `if (propertyExists("testRandomSeed"))` should work.
--
To view, visit http://gerrit.cloudera.org:8080/11908
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4873d27998f770a45dd9cc85f84ec8c146261b3d
Gerrit-Change-Number: 11908
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 08 Nov 2018 15:23:05 +
Gerrit-HasComments: Yes
