[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..

gutil: bump up linux-syscall-support.h

Bump up linux-syscall-support.h to newest version
which support aarch64 - commit fd00dbb from
https://chromium.googlesource.com/linux-syscall-support/

This is a clean application of IMPALA-9538 (modulo
the paths of the source files being different).

Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Reviewed-on: http://gerrit.cloudera.org:8080/15557
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin 
---
M src/kudu/gutil/linux_syscall_support.h
M src/kudu/gutil/spinlock_linux-inl.h
M src/kudu/util/debug-util.cc
M src/kudu/util/notification.h
4 files changed, 1,749 insertions(+), 894 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Thu, 26 Mar 2020 03:55:19 +
Gerrit-HasComments: No


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..


Patch Set 3: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 25 Mar 2020 22:59:36 +
Gerrit-HasComments: No


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..


Patch Set 3:

(1 comment)

> Patch Set 2:
>
> (1 comment)
>
> It looks like the other patch has an older version of 
> linux-syscall-support.h. It seems better to bring it up to date with upstream.
>
> TSAN error that caused the test failure is below. I couldn't find a related 
> JIRA but couldn't reproduce locally or see how it might've been caused by 
> this patch (maybe messing with futex did something?). Not sure how to proceed 
> with debugging this.
>
> WARNING: ThreadSanitizer: data race (pid=12896)
>   Write of size 8 at 0x7b2c000672b8 by main thread:
> #0 operator delete(void*) 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:126
>  (tablet_server_quiescing-itest+0x4f5119)
> #1 
> std::__1::default_delete::operator()(kudu::ThreadPoolToken*)
>  const 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
>  (libkudu_util.so+0x2f48b6)
> #2 std::__1::unique_ptr std::__1::default_delete 
> >::reset(kudu::ThreadPoolToken*) 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7
>  (libkudu_util.so+0x2f481d)
> #3 std::__1::unique_ptr std::__1::default_delete >::~unique_ptr() 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19
>  (libkudu_util.so+0x2eeccb)
> #4 kudu::ThreadPool::~ThreadPool() 
> /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/threadpool.cc:300:1 
> (libkudu_util.so+0x2eb29e)
> #5 
> std::__1::default_delete::operator()(kudu::ThreadPool*) 
> const 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
>  (libkudu_util.so+0x23638e)
> #6 std::__1::unique_ptr std::__1::default_delete >::reset(kudu::ThreadPool*) 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7
>  (libkudu_util.so+0x2362fd)
> #7 std::__1::unique_ptr std::__1::default_delete >::~unique_ptr() 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19
>  (libkudu_util.so+0x230d6b)
> #8 kudu::DnsResolver::~DnsResolver() 
> /home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/net/dns_resolver.cc:72:1
>  (libkudu_util.so+0x27ae63)
> #9 
> std::__1::default_delete::operator()(kudu::DnsResolver*) 
> const 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
>  (libkudu_client.so+0x1eb22e)
> #10 std::__1::unique_ptr std::__1::default_delete >::reset(kudu::DnsResolver*) 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7
>  (libkudu_client.so+0x1e20fd)
> #11 kudu::client::KuduClient::Data::~Data() 
> /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client-internal.cc:184:17
>  (libkudu_client.so+0x1dd71d)
> #12 kudu::client::KuduClient::~KuduClient() 
> /home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client.cc:396:3 
> (libkudu_client.so+0x1981dc)
> #13 
> std::__1::default_delete::operator()(kudu::client::KuduClient*)
>  const 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
>  (libkudu_client.so+0x1bd11e)
> #14 std::__1::__shared_ptr_pointer std::__1::default_delete, 
> std::__1::allocator >::__on_zero_shared() 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3511:5
>  (libkudu_client.so+0x1bce62)
> #15 std::__1::__shared_count::__release_shared() 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3415:9
>  (tablet_server_quiescing-itest+0x520b55)
> #16 std::__1::__shared_weak_count::__release_shared() 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3457:27
>  (tablet_server_quiescing-itest+0x520af9)
> #17 std::__1::shared_ptr::~shared_ptr() 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:4393:19
>  (tablet_server_quiescing-itest+0x520688)
> #18 kudu::TestWorkload::~TestWorkload() 
> /home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/test_workload.cc:96:1
>  (libitest_util.so+0xc1922)
> #19 
> std::__1::default_delete::operator()(kudu::TestWorkload*) 
> const 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
>  (tablet_server_quiescing-itest+0x52edde)
> #20 std::__1::unique_ptr std::__1::default_delete >::reset(kudu::TestWorkload*) 
> /home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7
>  (ta

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..


Patch Set 2:

(1 comment)

It looks like the other patch has an older version of linux-syscall-support.h. 
It seems better to bring it up to date with upstream.

TSAN error that caused the test failure is below. I couldn't find a related 
JIRA but couldn't reproduce locally or see how it might've been caused by this 
patch (maybe messing with futex did something?). Not sure how to proceed with 
debugging this.

WARNING: ThreadSanitizer: data race (pid=12896)
  Write of size 8 at 0x7b2c000672b8 by main thread:
#0 operator delete(void*) 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/src/llvm-9.0.0.src/projects/compiler-rt/lib/tsan/rtl/tsan_new_delete.cc:126
 (tablet_server_quiescing-itest+0x4f5119)
#1 
std::__1::default_delete::operator()(kudu::ThreadPoolToken*)
 const 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
 (libkudu_util.so+0x2f48b6)
#2 std::__1::unique_ptr 
>::reset(kudu::ThreadPoolToken*) 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7
 (libkudu_util.so+0x2f481d)
#3 std::__1::unique_ptr >::~unique_ptr() 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19
 (libkudu_util.so+0x2eeccb)
#4 kudu::ThreadPool::~ThreadPool() 
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/threadpool.cc:300:1 
(libkudu_util.so+0x2eb29e)
#5 
std::__1::default_delete::operator()(kudu::ThreadPool*) const 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
 (libkudu_util.so+0x23638e)
#6 std::__1::unique_ptr >::reset(kudu::ThreadPool*) 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7
 (libkudu_util.so+0x2362fd)
#7 std::__1::unique_ptr >::~unique_ptr() 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19
 (libkudu_util.so+0x230d6b)
#8 kudu::DnsResolver::~DnsResolver() 
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/util/net/dns_resolver.cc:72:1
 (libkudu_util.so+0x27ae63)
#9 
std::__1::default_delete::operator()(kudu::DnsResolver*) 
const 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
 (libkudu_client.so+0x1eb22e)
#10 std::__1::unique_ptr >::reset(kudu::DnsResolver*) 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7
 (libkudu_client.so+0x1e20fd)
#11 kudu::client::KuduClient::Data::~Data() 
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client-internal.cc:184:17
 (libkudu_client.so+0x1dd71d)
#12 kudu::client::KuduClient::~KuduClient() 
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/client/client.cc:396:3 
(libkudu_client.so+0x1981dc)
#13 
std::__1::default_delete::operator()(kudu::client::KuduClient*)
 const 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
 (libkudu_client.so+0x1bd11e)
#14 std::__1::__shared_ptr_pointer, 
std::__1::allocator >::__on_zero_shared() 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3511:5
 (libkudu_client.so+0x1bce62)
#15 std::__1::__shared_count::__release_shared() 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3415:9
 (tablet_server_quiescing-itest+0x520b55)
#16 std::__1::__shared_weak_count::__release_shared() 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:3457:27
 (tablet_server_quiescing-itest+0x520af9)
#17 std::__1::shared_ptr::~shared_ptr() 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:4393:19
 (tablet_server_quiescing-itest+0x520688)
#18 kudu::TestWorkload::~TestWorkload() 
/home/jenkins-slave/workspace/kudu-master/1/src/kudu/integration-tests/test_workload.cc:96:1
 (libitest_util.so+0xc1922)
#19 
std::__1::default_delete::operator()(kudu::TestWorkload*) 
const 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2338:5
 (tablet_server_quiescing-itest+0x52edde)
#20 std::__1::unique_ptr >::reset(kudu::TestWorkload*) 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2593:7
 (tablet_server_quiescing-itest+0x52ed4d)
#21 std::__1::unique_ptr >::~unique_ptr() 
/home/jenkins-slave/workspace/kudu-master/1/thirdparty/installed/tsan/include/c++/v1/memory:2547:19
 (tablet_server_quiescing-itest+0x51d27b)
#22 
kudu::itest::TServerQuiescingITest_TestDoesntAllowNewScansLeadersOnly_Test::TestBody()
 
/home/jenkins-slave/workspace/kudu-master/1/src/k

[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Hello Alexey Serbin, zhaoren...@hotmail.com, Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15557

to look at the new patch set (#3).

Change subject: gutil: bump up linux-syscall-support.h
..

gutil: bump up linux-syscall-support.h

Bump up linux-syscall-support.h to newest version
which support aarch64 - commit fd00dbb from
https://chromium.googlesource.com/linux-syscall-support/

This is a clean application of IMPALA-9538 (modulo
the paths of the source files being different).

Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
---
M src/kudu/gutil/linux_syscall_support.h
M src/kudu/gutil/spinlock_linux-inl.h
M src/kudu/util/debug-util.cc
M src/kudu/util/notification.h
4 files changed, 1,749 insertions(+), 894 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15557/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..


Patch Set 2:

(1 comment)

FYI there's another outstanding patch that also bumps the file: 
https://gerrit.cloudera.org/c/14964/7/src/kudu/gutil/linux_syscall_support.h

It hasn't moved in a while so don't feel like you need to coordinate, but it'd 
be good to compare the version you're bumping to and that version just to make 
sure they're roughly the same (or ideally, exactly the same).

http://gerrit.cloudera.org:8080/#/c/15557/2/src/kudu/gutil/spinlock_linux-inl.h
File src/kudu/gutil/spinlock_linux-inl.h:

PS2:
Here and elsewhere, use nullptr in C++ code.



--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 25 Mar 2020 20:11:05 +
Gerrit-HasComments: Yes


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15557/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15557/1//COMMIT_MSG@9
PS1, Line 9: linux-syscall-support.h
> Could you add information on the original upstream source (if any) of the l
Done


http://gerrit.cloudera.org:8080/#/c/15557/1/src/kudu/util/debug-util.cc
File src/kudu/util/debug-util.cc:

http://gerrit.cloudera.org:8080/#/c/15557/1/src/kudu/util/debug-util.cc@166
PS1, Line 166:
> nit: spacing -- using spaces instead of tabs for the indent
Done



--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 25 Mar 2020 17:52:41 +
Gerrit-HasComments: Yes


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Hello Alexey Serbin, zhaoren...@hotmail.com, Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15557

to look at the new patch set (#2).

Change subject: gutil: bump up linux-syscall-support.h
..

gutil: bump up linux-syscall-support.h

Bump up linux-syscall-support.h to newest version
which support aarch64 - commit fd00dbb from
https://chromium.googlesource.com/linux-syscall-support/

This is a clean application of IMPALA-9538 (modulo
the paths of the source files being different).

Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
---
M src/kudu/gutil/linux_syscall_support.h
M src/kudu/gutil/spinlock_linux-inl.h
M src/kudu/util/debug-util.cc
M src/kudu/util/notification.h
4 files changed, 1,748 insertions(+), 893 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15557/2
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/15557/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15557/1//COMMIT_MSG@9
PS1, Line 9: linux-syscall-support.h
Could you add information on the original upstream source (if any) of the 
linux-syscall-suppor.h file?


http://gerrit.cloudera.org:8080/#/c/15557/1/src/kudu/util/debug-util.cc
File src/kudu/util/debug-util.cc:

http://gerrit.cloudera.org:8080/#/c/15557/1/src/kudu/util/debug-util.cc@166
PS1, Line 166:   
nit: spacing -- using spaces instead of tabs for the indent



--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 25 Mar 2020 17:38:30 +
Gerrit-HasComments: Yes


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15557 )

Change subject: gutil: bump up linux-syscall-support.h
..


Patch Set 1:

Please ignore for now, I'm going to look at the failures


--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anonymous Coward 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tim Armstrong 
Gerrit-Comment-Date: Wed, 25 Mar 2020 17:00:30 +
Gerrit-HasComments: No


[kudu-CR] gutil: bump up linux-syscall-support.h

2020-03-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15557


Change subject: gutil: bump up linux-syscall-support.h
..

gutil: bump up linux-syscall-support.h

Bump up linux-syscall-support.h to newest version
which support aarch64

This is a clean application of IMPALA-9538 (modulo
the paths of the source files being different).

Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
---
M src/kudu/gutil/linux_syscall_support.h
M src/kudu/gutil/spinlock_linux-inl.h
M src/kudu/util/debug-util.cc
3 files changed, 1,746 insertions(+), 891 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15557/1
--
To view, visit http://gerrit.cloudera.org:8080/15557
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c46acb17f048890a3f93fc6b910b2df3c1a7058
Gerrit-Change-Number: 15557
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong 
Gerrit-Reviewer: Anonymous Coward