[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-27 Thread Adar Dembo (Code Review) 
Adar Dembo has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..

iwyu: codebase-wide fixes based on libcpp

These were generated by running iwyu.py --fix --all followed by some
massaging of the IWYU mapping files.

Note: kudu/client/shared_ptr.h handling isn't great:
- IWYU removes shared_ptr.h unless it is annotated with a "keep" pragma.
- IWYU adds  if the file references a class from kudu::client::sp.

This appears to be because IWYU, after processing the 'using' statements in
shared_ptr.h, considers the classes in kudu::client::sp to be exactly the same
as the equivalent std classes. As such, IWYU concludes that shared_ptr.h
offers nothing of value and should be removed, and that  should be
added because e.g. kudu::client::sp::shared_ptr is actually std::shared_ptr.

One might think to address the second issue by adding an "export" pragma to
shared_ptr.h's inclusion of . Doing that creates another problem:
IWYU removes  from any file that includes shared_ptr.h, which is
unsafe in non-libc++ builds where kudu::client::sp maps to std::tr1.

The only way I can think of safely addressing this is by copying a non-std
implementation of  into shared_ptr.h, to be used only when running
IWYU. Excising the necessary STL bits and bringing them into Kudu just for
this problem seems like overkill, though, so we'll just live with the "keep"
pragmas and the extra inclusions of .

Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Reviewed-on: http://gerrit.cloudera.org:8080/15543
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
---
M build-support/iwyu/mappings/boost-extra.imp
A build-support/iwyu/mappings/openssl.imp
M build-support/iwyu/mappings/system-linux.imp
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/partitioner-internal.cc
M src/kudu/client/partitioner-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/schema.cc
M src/kudu/client/session-internal.cc
M src/kudu/client/shared_ptr.h
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/clock/builtin_ntp-internal.cc
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/logical_clock.cc
M src/kudu/clock/ntp-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/columnblock.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/id_mapping.h
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta_manager-stress-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/experiments/merge-test.cc
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/dir_manager.cc
M src/kudu/fs/error_manager.h
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/gutil/hash/city.cc
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/stringprintf.cc
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/stringpiece.cc
M src/kudu/gutil/strings/stringpiece.h
M src/kudu/gutil/strings/util.h
M src/kudu/gutil/sysinfo.cc
M src/kudu/gutil/utf/rune.c
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 5: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/15543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 27 Mar 2020 05:28:14 +
Gerrit-HasComments: No

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h
File src/kudu/client/partitioner-internal.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h@20
PS3, Line 20: #include 
> I'm glad it worked out :)  Thank you for verifying and making appropriate u
Unfortunately life is not so simple, and the removal of the  inclusions 
is actually somewhat problematic if the file in question doesn't get  
through another source: if it also uses e.g. std::unique_ptr, it'll fail to 
build with libstdc++.

After much brainstorming, I ended up restoring my previous approach, and 
documenting it extensively in both the commit message and shared_ptr.h.



--
To view, visit http://gerrit.cloudera.org:8080/15543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 27 Mar 2020 05:05:00 +
Gerrit-HasComments: Yes

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Adar Dembo (Code Review) 
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15543

to look at the new patch set (#5).

Change subject: iwyu: codebase-wide fixes based on libcpp
..

iwyu: codebase-wide fixes based on libcpp

These were generated by running iwyu.py --fix --all followed by some
massaging of the IWYU mapping files.

Note: kudu/client/shared_ptr.h handling isn't great:
- IWYU removes shared_ptr.h unless it is annotated with a "keep" pragma.
- IWYU adds  if the file references a class from kudu::client::sp.

This appears to be because IWYU, after processing the 'using' statements in
shared_ptr.h, considers the classes in kudu::client::sp to be exactly the same
as the equivalent std classes. As such, IWYU concludes that shared_ptr.h
offers nothing of value and should be removed, and that  should be
added because e.g. kudu::client::sp::shared_ptr is actually std::shared_ptr.

One might think to address the second issue by adding an "export" pragma to
shared_ptr.h's inclusion of . Doing that creates another problem:
IWYU removes  from any file that includes shared_ptr.h, which is
unsafe in non-libc++ builds where kudu::client::sp maps to std::tr1.

The only way I can think of safely addressing this is by copying a non-std
implementation of  into shared_ptr.h, to be used only when running
IWYU. Excising the necessary STL bits and bringing them into Kudu just for
this problem seems like overkill, though, so we'll just live with the "keep"
pragmas and the extra inclusions of .

Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
---
M build-support/iwyu/mappings/boost-extra.imp
A build-support/iwyu/mappings/openssl.imp
M build-support/iwyu/mappings/system-linux.imp
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/partitioner-internal.cc
M src/kudu/client/partitioner-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/schema.cc
M src/kudu/client/session-internal.cc
M src/kudu/client/shared_ptr.h
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/clock/builtin_ntp-internal.cc
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/logical_clock.cc
M src/kudu/clock/ntp-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/columnblock.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/id_mapping.h
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta_manager-stress-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/experiments/merge-test.cc
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/dir_manager.cc
M src/kudu/fs/error_manager.h
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/gutil/hash/city.cc
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/stringprintf.cc
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/stringpiece.cc
M src/kudu/gutil/strings/stringpiece.h
M src/kudu/gutil/strings/util.h
M src/kudu/gutil/sysinfo.cc
M src/kudu/gutil/utf/rune.c
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 4:

(2 comments)

IWYU reports that some additional inclusion of the  can be removed.

Overall, looks good to me.

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h
File src/kudu/client/partitioner-internal.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h@20
PS3, Line 20: #include 
> The prize goes to Alexey.
I'm glad it worked out :)  Thank you for verifying and making appropriate 
updates!


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/status.h
File src/kudu/util/status.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/status.h@24
PS3, Line 24: // This macro is not defined when status.h
> The gist is: this is part of the public C++ API, so we can't express a depe
Yup, it seems your solution with KUDU_HEADERS_USE_SHORT_STATUS_MACROS is a 
better option.  Thank you!



--
To view, visit http://gerrit.cloudera.org:8080/15543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 26 Mar 2020 18:18:23 +
Gerrit-HasComments: Yes

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Adar Dembo (Code Review) 
Hello Tidy Bot, Alexey Serbin, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15543

to look at the new patch set (#4).

Change subject: iwyu: codebase-wide fixes based on libcpp
..

iwyu: codebase-wide fixes based on libcpp

These were generated by running iwyu.py --fix --all followed by some
massaging of the IWYU mapping files.

Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
---
M build-support/iwyu/mappings/boost-extra.imp
A build-support/iwyu/mappings/openssl.imp
M build-support/iwyu/mappings/system-linux.imp
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/meta_cache.cc
M src/kudu/client/partitioner-internal.cc
M src/kudu/client/predicate-test.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema.cc
M src/kudu/client/session-internal.cc
M src/kudu/client/session-internal.h
M src/kudu/client/shared_ptr.h
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/write_op.cc
M src/kudu/client/write_op.h
M src/kudu/clock/builtin_ntp-internal.cc
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/logical_clock.cc
M src/kudu/clock/ntp-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/columnblock.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/id_mapping.h
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta_manager-stress-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/experiments/merge-test.cc
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/dir_manager.cc
M src/kudu/fs/error_manager.h
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/gutil/hash/city.cc
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/stringprintf.cc
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/stringpiece.cc
M src/kudu/gutil/strings/stringpiece.h
M src/kudu/gutil/strings/util.h
M src/kudu/gutil/sysinfo.cc
M src/kudu/gutil/utf/rune.c
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/catalog_manager_tsk-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/consensus_peer_health_status-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/dense_node-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/log-rolling-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-26 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 3:

(21 comments)

http://gerrit.cloudera.org:8080/#/c/15543/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15543/3//COMMIT_MSG@8
PS3, Line 8:
   : These were generated by running iwyu.py --fix --all followed by 
some
   : massaging of the IWYU mapping files.
> Could you also note the new header ordering guidelines we should be followi
Nothing has actually changed, though:
- Boost headers remain as before, mixed in with the "thirdparty but not system" 
headers (i.e. glog, gflags, etc.)
- Openssl headers are considered "system" headers as they should have been all 
along, because they're not derived from our thirdparty tree; they are derived 
from the system.


http://gerrit.cloudera.org:8080/#/c/15543/3/build-support/iwyu/mappings/openssl.imp
File build-support/iwyu/mappings/openssl.imp:

http://gerrit.cloudera.org:8080/#/c/15543/3/build-support/iwyu/mappings/openssl.imp@17
PS3, Line 17: [
: { include: ["", private, "", 
public ] },
: { include: ["", private, "", 
private ] },
: { include: ["", private, 
"", public ] },
: { include: ["", private, 
"", public ] },
: { include: ["", private, 
"", public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, 
"", public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, 
"", public ] },
> Could you add a brief comment explaining what this is for? similar to that
Done


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client-test-util.h
File src/kudu/client/client-test-util.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client-test-util.h@22
PS3, Line 22: #include 
> Should we no_include this one too?
Moot; Alexey steered me in the right direction and this is now gone.


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client-unittest.cc
File src/kudu/client/client-unittest.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client-unittest.cc@22
PS3, Line 22: #include 
> Move this below?
See my reply to your comment in the commit message: this is actually correct 
because the openssl headers come from the system, not thirdparty.


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client.h@32
PS3, Line 32: // IWYU pragma: no_include 
> This is because we can't trick IWYU into telling us to use client/shared_pt
Now removed; Alexey pointed me in the right direction.


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h
File src/kudu/client/partitioner-internal.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h@20
PS3, Line 20: #include 
> BTW, what if adding 'IWYU pragma: export' into kudu/client/shared_ptr.h for
The prize goes to Alexey.

I had previously removed that pragma because it didn't help me in my goal to 
force IWYU to keep shared_ptr.h included in headers that needed it. Doing so, 
however, triggered these unnecessary inclusions of . I've restored the 
pragma and now the inclusions are gone.

Alexey, I should have listened to you when you warned me against removing the 
pragma. Sorry about that!


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/table-internal.h
File src/kudu/client/table-internal.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/table-internal.h@21
PS3, Line 21: memory
> no_include?
Now removed; Alexey pointed me in the right direction.


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/write_op.h
File src/kudu/client/write_op.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/write_op.h@22
PS3, Line 22: IWYU pragma: no_include 
> nit: could you add a comment explaining why this is necessary?
Moot; your other suggestion got rid of this.


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/common/encoded_key-test.cc
File src/kudu/common/encoded_key-test.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/common/encoded_key-test.cc@43
PS3, Line 43: namespace kudu {
: class EncodedKeyTest;
: class EncodedKeyTest_TestConstructFromEncodedString_Test;
: class EncodedKeyTest_TestDecodeCompoundKeys_Test;
: class EncodedKeyTest_TestDecodeSimpleKeys_Test;
: } // namespace kudu
> Maybe, splitting the declaration and implementation of EncodedKeyTest and d
Unfortunately it

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-25 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/minidump.cc
File src/kudu/util/minidump.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/minidump.cc@37
PS3, Line 37: #include 
> I cherry-picked this patch on macOS catalina and I see this.
Yeah, the same story.

It seems these breakpad headers should be moved under the #if 
defined(__linux__) ... #endif section above.  At least I was able to compile 
the code successfully after doing so.



--
To view, visit http://gerrit.cloudera.org:8080/15543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 26 Mar 2020 03:09:35 +
Gerrit-HasComments: Yes

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-25 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h
File src/kudu/client/partitioner-internal.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h@20
PS3, Line 20: #include 
> no_include here too?
BTW, what if adding 'IWYU pragma: export' into kudu/client/shared_ptr.h for 
?  Will it help to deal with such cases?



--
To view, visit http://gerrit.cloudera.org:8080/15543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 26 Mar 2020 02:31:31 +
Gerrit-HasComments: Yes

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-25 Thread Alexey Serbin (Code Review) 
Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 3:

(11 comments)

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/write_op.h
File src/kudu/client/write_op.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/write_op.h@22
PS3, Line 22: IWYU pragma: no_include 
nit: could you add a comment explaining why this is necessary?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/common/encoded_key-test.cc
File src/kudu/common/encoded_key-test.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/common/encoded_key-test.cc@43
PS3, Line 43: namespace kudu {
: class EncodedKeyTest;
: class EncodedKeyTest_TestConstructFromEncodedString_Test;
: class EncodedKeyTest_TestDecodeCompoundKeys_Test;
: class EncodedKeyTest_TestDecodeSimpleKeys_Test;
: } // namespace kudu
Maybe, splitting the declaration and implementation of EncodedKeyTest and 
defining those macros after the declaration would be a better option?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/common/key_encoder.cc
File src/kudu/common/key_encoder.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/common/key_encoder.cc@21
PS3, Line 21: #include  // IWYU pragma: keep
Interesting: why is it needed?  I don't see std::string-related code in this 
file.


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/rpc/negotiation-test.cc
File src/kudu/rpc/negotiation-test.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/rpc/negotiation-test.cc@34
PS3, Line 34: #include  // IWYU pragma: keep
Interesting -- previously it was not in this file.  If it was able to compile 
without this header file, why to keep it, especially with IWYU's pragma?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/security/openssl_util.h
File src/kudu/security/openssl_util.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/security/openssl_util.h@35
PS3, Line 35: namespace kudu {
: namespace security {
: namespace internal {
: struct ScopedCheckNoPendingSSLErrors;
: }  // namespace internal
: }  // namespace security
: }  // namespace kudu
nit: maybe, moving the definition of the ScopedCheckNoPendingSSLErrors 
structure to the top would be a better option?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/security/openssl_util.cc
File src/kudu/security/openssl_util.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/security/openssl_util.cc@36
PS3, Line 36: #include "kudu/util/debug/leakcheck_disabler.h" // IWYU pragma: 
keep
nit: would be a better optio putting this under '#if OPENSSL_VERSION_NUMBER < 
0x1010L' ... #endif ?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/security/openssl_util.cc@38
PS3, Line 38: #include "kudu/util/mutex.h" // IWYU pragma: keep
ditto


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/tablet/rowset_tree-test.cc
File src/kudu/tablet/rowset_tree-test.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/tablet/rowset_tree-test.cc@20
PS3, Line 20: #include 
#include 

?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/env-test.cc@33
PS3, Line 33: #include 
nit: would  work here?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/env_posix.cc@10
PS3, Line 10: #include 
nit: would  work here?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/status.h
File src/kudu/util/status.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/status.h@24
PS3, Line 24: // IWYU pragma: no_include 
> Why don't we need this? Don't we actually pull LOG() from here?
Probably, it's worth adding a small comment explaining why this is needed here 
or remove this at all?



--
To view, visit http://gerrit.cloudera.org:8080/15543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 26 Mar 2020 02:24:03 +
Gerrit-HasComments: Yes

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-25 Thread Andrew Wong (Code Review) 
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 3:

(12 comments)

http://gerrit.cloudera.org:8080/#/c/15543/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15543/3//COMMIT_MSG@8
PS3, Line 8:
   : These were generated by running iwyu.py --fix --all followed by 
some
   : massaging of the IWYU mapping files.
Could you also note the new header ordering guidelines we should be following? 
E.g. seems like boost and openssl headers ought to be on top now, separate 
other thirdparty headers.


http://gerrit.cloudera.org:8080/#/c/15543/3/build-support/iwyu/mappings/openssl.imp
File build-support/iwyu/mappings/openssl.imp:

http://gerrit.cloudera.org:8080/#/c/15543/3/build-support/iwyu/mappings/openssl.imp@17
PS3, Line 17: [
: { include: ["", private, "", 
public ] },
: { include: ["", private, "", 
private ] },
: { include: ["", private, 
"", public ] },
: { include: ["", private, 
"", public ] },
: { include: ["", private, 
"", public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, 
"", public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, "", 
public ] },
: { include: ["", private, 
"", public ] },
Could you add a brief comment explaining what this is for? similar to that in 
the system-linux.imp?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client-test-util.h
File src/kudu/client/client-test-util.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client-test-util.h@22
PS3, Line 22: #include 
Should we no_include this one too?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client-unittest.cc
File src/kudu/client/client-unittest.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client-unittest.cc@22
PS3, Line 22: #include 
Move this below?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client.h
File src/kudu/client/client.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/client.h@32
PS3, Line 32: // IWYU pragma: no_include 
This is because we can't trick IWYU into telling us to use client/shared_ptr 
instead of std::shared_ptr, right?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h
File src/kudu/client/partitioner-internal.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/partitioner-internal.h@20
PS3, Line 20: #include 
no_include here too?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/table-internal.h
File src/kudu/client/table-internal.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/client/table-internal.h@21
PS3, Line 21: memory
no_include?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/experiments/rwlock-perf.cc
File src/kudu/experiments/rwlock-perf.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/experiments/rwlock-perf.cc@29
PS3, Line 29: #include 
Hrm, this one looks kind of odd. Any clue why it's opting to not include what 
the spinlock header?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/rpc/client_negotiation.cc
File src/kudu/rpc/client_negotiation.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/rpc/client_negotiation.cc@20
PS3, Line 20: #include 
: #include 
: #include 
Same here?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/tablet/delta_key.h
File src/kudu/tablet/delta_key.h:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/tablet/delta_key.h@20
PS3, Line 20: #include 
cstddef?


http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/minidump.cc
File src/kudu/util/minidump.cc:

http://gerrit.cloudera.org:8080/#/c/15543/3/src/kudu/util/minidump.cc@37
PS3, Line 37: #include 
I cherry-picked this patch on macOS catalina and I see this.

[360/1582] Building CXX object 
src/kudu/util/CMakeFiles/kudu_util.dir/minidump.cc.o
FAILED: src/kudu/util/CMakeFiles/kudu_util.dir/minidump.cc.o
/Applications/Xcode.app/Contents/Developer/usr/bin/g++  
-DKUDU_HEADERS_NO_STUBS=1 -DKUDU_HEADERS_USE_RICH_SLICE=1 
-DKUDU_HEADERS_USE_SHORT_STATUS_MACROS=1 -DKUDU_STATIC_DEFINE 
-DTCMALLOC_ENABLED -D__STDC_FORMAT_MACROS -Dkudu_util_EXPORTS -Isrc -I../../src 
-I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/Kerberos.framework/Headers
 -isystem ../../thirdparty/installed/common/include -isystem 
../../thirdparty/installed/uninstrumented/include -isystem 
/usr/local/opt/openssl/include -msse4.2 -Wall -Wno-sign-compare -Wno-comment 
-pthread -fno-strict-aliasing

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-25 Thread Adar Dembo (Code Review) 
Adar Dembo has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/15543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-25 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15543 )

Change subject: iwyu: codebase-wide fixes based on libcpp
..


Patch Set 3: Verified+1

Overriding Jenkins, unrelated test failure.


--
To view, visit http://gerrit.cloudera.org:8080/15543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
Gerrit-Change-Number: 15543
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 26 Mar 2020 01:03:38 +
Gerrit-HasComments: No

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-25 Thread Adar Dembo (Code Review) 
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15543

to look at the new patch set (#3).

Change subject: iwyu: codebase-wide fixes based on libcpp
..

iwyu: codebase-wide fixes based on libcpp

These were generated by running iwyu.py --fix --all followed by some
massaging of the IWYU mapping files.

Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
---
M build-support/iwyu/mappings/boost-extra.imp
A build-support/iwyu/mappings/openssl.imp
M build-support/iwyu/mappings/system-linux.imp
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/partitioner-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/schema.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/write_op.h
M src/kudu/clock/builtin_ntp-internal.cc
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/logical_clock.cc
M src/kudu/clock/ntp-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/columnblock.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/id_mapping.h
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta_manager-stress-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/experiments/merge-test.cc
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/dir_manager.cc
M src/kudu/fs/error_manager.h
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/gutil/hash/city.cc
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/stringprintf.cc
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/stringpiece.cc
M src/kudu/gutil/strings/stringpiece.h
M src/kudu/gutil/strings/util.h
M src/kudu/gutil/sysinfo.cc
M src/kudu/gutil/utf/rune.c
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/catalog_manager_tsk-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/consensus_peer_health_status-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/dense_node-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/log-rolling-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/memory_gc-itest.cc
M src/kudu/integration-tests/mini_cluster_fs_inspector.cc
M

[kudu-CR] iwyu: codebase-wide fixes based on libcpp

2020-03-24 Thread Adar Dembo (Code Review) 
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/15543

to look at the new patch set (#2).

Change subject: iwyu: codebase-wide fixes based on libcpp
..

iwyu: codebase-wide fixes based on libcpp

These were generated by running iwyu.py --fix --all followed by some
massaging of the IWYU mapping files.

Change-Id: Ic248ba1511347d79cc6ea38140de888e5ac13354
---
M build-support/iwyu/mappings/boost-extra.imp
A build-support/iwyu/mappings/openssl.imp
M build-support/iwyu/mappings/system-linux.imp
M src/kudu/benchmarks/tpch/rpc_line_item_dao-test.cc
M src/kudu/cfile/binary_dict_block.cc
M src/kudu/cfile/binary_plain_block.cc
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_writer.h
M src/kudu/cfile/index-test.cc
M src/kudu/cfile/index_btree.cc
M src/kudu/cfile/type_encodings.cc
M src/kudu/client/authz_token_cache.cc
M src/kudu/client/batcher.h
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test-util.cc
M src/kudu/client/client-test-util.h
M src/kudu/client/client-test.cc
M src/kudu/client/client-unittest.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/partitioner-internal.h
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/schema.cc
M src/kudu/client/table-internal.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/write_op.h
M src/kudu/clock/builtin_ntp-internal.cc
M src/kudu/clock/builtin_ntp.cc
M src/kudu/clock/hybrid_clock.cc
M src/kudu/clock/logical_clock.cc
M src/kudu/clock/ntp-test.cc
M src/kudu/codegen/codegen-test.cc
M src/kudu/codegen/compilation_manager.cc
M src/kudu/codegen/module_builder.cc
M src/kudu/common/column_predicate-test.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/columnblock.h
M src/kudu/common/encoded_key-test.cc
M src/kudu/common/generic_iterators-test.cc
M src/kudu/common/id_mapping.h
M src/kudu/common/key_encoder.cc
M src/kudu/common/key_util.cc
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/rowblock.h
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.h
M src/kudu/common/types-test.cc
M src/kudu/common/types.cc
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_meta_manager-stress-test.cc
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/mt-log-test.cc
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/quorum_util-test.cc
M src/kudu/consensus/quorum_util.cc
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/experiments/merge-test.cc
M src/kudu/experiments/rwlock-perf.cc
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/dir_manager.cc
M src/kudu/fs/error_manager.h
M src/kudu/fs/fs_manager-test.cc
M src/kudu/fs/fs_manager.cc
M src/kudu/fs/fs_manager.h
M src/kudu/gutil/hash/city.cc
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/stringprintf.cc
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/stringpiece.cc
M src/kudu/gutil/strings/stringpiece.h
M src/kudu/gutil/strings/util.h
M src/kudu/gutil/sysinfo.cc
M src/kudu/gutil/utf/rune.c
M src/kudu/hms/hms_catalog-test.cc
M src/kudu/hms/hms_catalog.cc
M src/kudu/hms/hms_client-test.cc
M src/kudu/hms/hms_client.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/auth_token_expire-itest.cc
M src/kudu/integration-tests/catalog_manager_tsk-itest.cc
M src/kudu/integration-tests/client-negotiation-failover-itest.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_verifier.cc
M src/kudu/integration-tests/consensus_peer_health_status-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-itest.cc
M src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/dense_node-itest.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/integration-tests/hms_itest-base.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/location_assignment-itest.cc
M src/kudu/integration-tests/log-rolling-itest.cc
M src/kudu/integration-tests/maintenance_mode-itest.cc
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/integration-tests/master_replication-itest.cc
M src/kudu/integration-tests/memory_gc-itest.cc
M src/kudu/integration-tests/mini_cluster_fs_inspector.cc