[kudu-CR] master: do not crash on /dump-entities during startup

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: master: do not crash on /dump-entities during startup
..


master: do not crash on /dump-entities during startup

A user reported a master crash when the following conditions were met:
1. The master tablet was enormous and took a while to bootstrap.
2. An external monitoring agent was periodically accessing the master's
   /dump-entities URL.

While fixing this, I also double checked that the rest of the master URLs do
the right thing before making calls into the master.

The majority of the patch repurposes the PeriodicWebUIChecker (from
linked_list-test) for the new integration test. I modified its URL polling
behavior so that all URLs are polled before sleeping.

Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Reviewed-on: http://gerrit.cloudera.org:8080/4366
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/linked_list-test-util.h
M src/kudu/integration-tests/master_failover-itest.cc
M src/kudu/master/master-path-handlers.cc
4 files changed, 41 insertions(+), 10 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] master: do not crash on /dump-entities during startup

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: master: do not crash on /dump-entities during startup
..


Patch Set 1:

tried the test without the fix locally, looks like it's a good one.

-- 
To view, visit http://gerrit.cloudera.org:8080/4366
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d8e9caf7236d2c487fb9322cb3e1993cc631cdf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No