[kudu-CR] tablet history gc-itest: set scanner ttl ms high

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged.

Change subject: tablet_history_gc-itest: set scanner_ttl_ms high
..


tablet_history_gc-itest: set scanner_ttl_ms high

This test is currently flaky on slower builds (TSAN/ASAN) because of
scanner expiration. The test opens scanners and then waits some time
before actually reading from them. In a slow build, this might be more
than the default 1-minute scanner TTL, which would cause the scanner to
expire and the test to fail to read.

Change-Id: I4bd8a5bdc77871a95b3630f1622a802967d14b84
Reviewed-on: http://gerrit.cloudera.org:8080/4375
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy 
---
M src/kudu/integration-tests/tablet_history_gc-itest.cc
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4bd8a5bdc77871a95b3630f1622a802967d14b84
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 


[kudu-CR] tablet history gc-itest: set scanner ttl ms high

2016-09-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change.

Change subject: tablet_history_gc-itest: set scanner_ttl_ms high
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd8a5bdc77871a95b3630f1622a802967d14b84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No


[kudu-CR] tablet history gc-itest: set scanner ttl ms high

2016-09-11 Thread Todd Lipcon (Code Review)
Hello Mike Percy,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4375

to review the following change.

Change subject: tablet_history_gc-itest: set scanner_ttl_ms high
..

tablet_history_gc-itest: set scanner_ttl_ms high

This test is currently flaky on slower builds (TSAN/ASAN) because of
scanner expiration. The test opens scanners and then waits some time
before actually reading from them. In a slow build, this might be more
than the default 1-minute scanner TTL, which would cause the scanner to
expire and the test to fail to read.

Change-Id: I4bd8a5bdc77871a95b3630f1622a802967d14b84
---
M src/kudu/integration-tests/tablet_history_gc-itest.cc
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/4375/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4bd8a5bdc77871a95b3630f1622a802967d14b84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Mike Percy 


[kudu-CR] tablet history gc-itest: set scanner ttl ms high

2016-09-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: tablet_history_gc-itest: set scanner_ttl_ms high
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3357/

-- 
To view, visit http://gerrit.cloudera.org:8080/4375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4bd8a5bdc77871a95b3630f1622a802967d14b84
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No