[kudu-CR] tablet peer: clean up TabletStatusListener interface
Adar Dembo has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Adar Dembo has submitted this change and it was merged. Change subject: tablet_peer: clean up TabletStatusListener interface .. tablet_peer: clean up TabletStatusListener interface This class duplicated a lot of TabletPeer info for no particular reason. Its main purpose was to provide a clean callback for reporting status back to the TabletPeer, but over time it grew various unnecessary warts. Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Reviewed-on: http://gerrit.cloudera.org:8080/4193 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tserver/tablet_copy_client-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver-path-handlers.cc 12 files changed, 68 insertions(+), 96 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Kudu Jenkins has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/3178/ -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Todd Lipcon has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4193/1/src/kudu/tablet/tablet_peer.h File src/kudu/tablet/tablet_peer.h: Line 374: > ? Done -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4193 to look at the new patch set (#3). Change subject: tablet_peer: clean up TabletStatusListener interface .. tablet_peer: clean up TabletStatusListener interface This class duplicated a lot of TabletPeer info for no particular reason. Its main purpose was to provide a clean callback for reporting status back to the TabletPeer, but over time it grew various unnecessary warts. Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da --- M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tserver/tablet_copy_client-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver-path-handlers.cc 12 files changed, 68 insertions(+), 96 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/4193/3 -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4193 to look at the new patch set (#2). Change subject: tablet_peer: clean up TabletStatusListener interface .. tablet_peer: clean up TabletStatusListener interface This class duplicated a lot of TabletPeer info for no particular reason. Its main purpose was to provide a clean callback for reporting status back to the TabletPeer, but over time it grew various unnecessary warts. Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da --- M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tserver/tablet_copy_client-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver-path-handlers.cc 12 files changed, 69 insertions(+), 96 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/4193/2 -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Kudu Jenkins has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/3175/ -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Adar Dembo has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4193/1/src/kudu/tablet/tablet_peer.h File src/kudu/tablet/tablet_peer.h: Line 374: ? -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Hello Dinesh Bhat, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4193 to review the following change. Change subject: tablet_peer: clean up TabletStatusListener interface .. tablet_peer: clean up TabletStatusListener interface This class duplicated a lot of TabletPeer info for no particular reason. Its main purpose was to provide a clean callback for reporting status back to the TabletPeer, but over time it grew various unnecessary warts. Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da --- M src/kudu/master/sys_catalog.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tserver/tablet_copy_client-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/tserver-path-handlers.cc 11 files changed, 67 insertions(+), 94 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/4193/1 -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat
[kudu-CR] tablet peer: clean up TabletStatusListener interface
Kudu Jenkins has posted comments on this change. Change subject: tablet_peer: clean up TabletStatusListener interface .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3173/ -- To view, visit http://gerrit.cloudera.org:8080/4193 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06233b88a83859020cee1f96cff205952e2aa2da Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No