[kudu-CR] thirdparty: patch glog to omit tests from build
Adar Dembo has posted comments on this change. Change subject: thirdparty: patch glog to omit tests from build .. Patch Set 2: Verified+1 Overriding Jenkins, time out in Java TestAsyncKuduSession. -- To view, visit http://gerrit.cloudera.org:8080/4508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadcf062c0baa1624eabc525bc39f83d8a7135e0b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] thirdparty: patch glog to omit tests from build
Adar Dembo has submitted this change and it was merged. Change subject: thirdparty: patch glog to omit tests from build .. thirdparty: patch glog to omit tests from build The glog tests prevent glog from being built with -fsanitize=thread[1]. Since we never run them, lets just patch them out of the build. 1. https://github.com/google/glog/issues/54 Change-Id: Iadcf062c0baa1624eabc525bc39f83d8a7135e0b Reviewed-on: http://gerrit.cloudera.org:8080/4508 Reviewed-by: Dan Burkert Tested-by: Adar Dembo --- M thirdparty/download-thirdparty.sh A thirdparty/patches/glog-issue-54-dont-build-tests.patch 2 files changed, 149 insertions(+), 1 deletion(-) Approvals: Dan Burkert: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/4508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadcf062c0baa1624eabc525bc39f83d8a7135e0b Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon
[kudu-CR] thirdparty: patch glog to omit tests from build
Dan Burkert has posted comments on this change. Change subject: thirdparty: patch glog to omit tests from build .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadcf062c0baa1624eabc525bc39f83d8a7135e0b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] thirdparty: patch glog to omit tests from build
Dan Burkert has posted comments on this change. Change subject: thirdparty: patch glog to omit tests from build .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadcf062c0baa1624eabc525bc39f83d8a7135e0b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] thirdparty: patch glog to omit tests from build
Todd Lipcon has posted comments on this change. Change subject: thirdparty: patch glog to omit tests from build .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadcf062c0baa1624eabc525bc39f83d8a7135e0b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] thirdparty: patch glog to omit tests from build
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4508 to review the following change. Change subject: thirdparty: patch glog to omit tests from build .. thirdparty: patch glog to omit tests from build The glog tests prevent glog from being built with -fsanitize=thread[1]. Since we never run them, lets just patch them out of the build. 1. https://github.com/google/glog/issues/54 Change-Id: Iadcf062c0baa1624eabc525bc39f83d8a7135e0b --- M thirdparty/download-thirdparty.sh A thirdparty/patches/glog-issue-54-dont-build-tests.patch 2 files changed, 149 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/08/4508/1 -- To view, visit http://gerrit.cloudera.org:8080/4508 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iadcf062c0baa1624eabc525bc39f83d8a7135e0b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Todd Lipcon