[kudu-CR] ts itest-base: chain to superclass TearDown
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9945 ) Change subject: ts_itest-base: chain to superclass TearDown .. Patch Set 3: Code-Review+2 Carrying over Andrew's +2. -- To view, visit http://gerrit.cloudera.org:8080/9945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic20da27c1333a69dc948095828300b03d2298a37 Gerrit-Change-Number: 9945 Gerrit-PatchSet: 3 Gerrit-Owner: Adar DemboGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 06 Apr 2018 19:55:59 + Gerrit-HasComments: No
[kudu-CR] ts itest-base: chain to superclass TearDown
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9945 ) Change subject: ts_itest-base: chain to superclass TearDown .. ts_itest-base: chain to superclass TearDown This didn't cause any real trouble since no superclass in the hierarchy defines a TearDown, but it's a good practice in any case. Change-Id: Ic20da27c1333a69dc948095828300b03d2298a37 Reviewed-on: http://gerrit.cloudera.org:8080/9945 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo--- M src/kudu/integration-tests/ts_itest-base.cc 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic20da27c1333a69dc948095828300b03d2298a37 Gerrit-Change-Number: 9945 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] ts itest-base: chain to superclass TearDown
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9945 ) Change subject: ts_itest-base: chain to superclass TearDown .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic20da27c1333a69dc948095828300b03d2298a37 Gerrit-Change-Number: 9945 Gerrit-PatchSet: 1 Gerrit-Owner: Adar DemboGerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins Gerrit-Comment-Date: Fri, 06 Apr 2018 19:21:23 + Gerrit-HasComments: No
[kudu-CR] ts itest-base: chain to superclass TearDown
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9945 to review the following change. Change subject: ts_itest-base: chain to superclass TearDown .. ts_itest-base: chain to superclass TearDown This didn't cause any real trouble since no superclass in the hierarchy defines a TearDown, but it's a good practice in any case. Change-Id: Ic20da27c1333a69dc948095828300b03d2298a37 --- M src/kudu/integration-tests/ts_itest-base.cc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/9945/1 -- To view, visit http://gerrit.cloudera.org:8080/9945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic20da27c1333a69dc948095828300b03d2298a37 Gerrit-Change-Number: 9945 Gerrit-PatchSet: 1 Gerrit-Owner: Adar DemboGerrit-Reviewer: Andrew Wong