[kudu-CR] util: remove duplicate results from DNS resolution
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. util: remove duplicate results from DNS resolution On some systems it seems that our DNS resolution code can end up yielding multiple copies of the same address. That would produce annoying log messages like: $ kudu table list localhost W0404 20:35:05.511526 31378 client-internal.cc:597] Specified master server address 'localhost' resolved to multiple IPs. Using 127.0.0.1:7051 This patch ensures that any given address is only appended to the result vector once. Change-Id: I7d9b9f9839a899d8022f5ac6496555ff84583192 Reviewed-on: http://gerrit.cloudera.org:8080/15665 Reviewed-by: Adar Dembo Reviewed-by: Alexey Serbin Tested-by: Kudu Jenkins --- M src/kudu/util/net/net_util.cc 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Adar Dembo: Looks good to me, approved Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7d9b9f9839a899d8022f5ac6496555ff84583192 Gerrit-Change-Number: 15665 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] util: remove duplicate results from DNS resolution
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15665/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15665/1//COMMIT_MSG@13 PS1, Line 13: $ kudu table list localhost : W0404 20:35:05.511526 31378 client-internal.cc:597] Specified master : server address 'localhost' resolved to multiple IPs. Using : 127.0.0.1:7051 > seems to be reported here: https://bugzilla.redhat.com/show_bug.cgi?id=4963 thank you for the reference -- To view, visit http://gerrit.cloudera.org:8080/15665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d9b9f9839a899d8022f5ac6496555ff84583192 Gerrit-Change-Number: 15665 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 07 Apr 2020 04:46:24 + Gerrit-HasComments: Yes
[kudu-CR] util: remove duplicate results from DNS resolution
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15665/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15665/1//COMMIT_MSG@13 PS1, Line 13: $ kudu table list localhost : W0404 20:35:05.511526 31378 client-internal.cc:597] Specified master : server address 'localhost' resolved to multiple IPs. Using : 127.0.0.1:7051 > Maybe, that was due to multiple entries in /etc/hosts? seems to be reported here: https://bugzilla.redhat.com/show_bug.cgi?id=496300 with some discussion about whether it's really a bug -- To view, visit http://gerrit.cloudera.org:8080/15665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d9b9f9839a899d8022f5ac6496555ff84583192 Gerrit-Change-Number: 15665 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 07 Apr 2020 04:12:09 + Gerrit-HasComments: Yes
[kudu-CR] util: remove duplicate results from DNS resolution
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15665/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15665/1//COMMIT_MSG@13 PS1, Line 13: $ kudu table list localhost : W0404 20:35:05.511526 31378 client-internal.cc:597] Specified master : server address 'localhost' resolved to multiple IPs. Using : 127.0.0.1:7051 > I've definitely seen this before and always wondered what caused it. Is it Maybe, that was due to multiple entries in /etc/hosts? -- To view, visit http://gerrit.cloudera.org:8080/15665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d9b9f9839a899d8022f5ac6496555ff84583192 Gerrit-Change-Number: 15665 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 06 Apr 2020 23:19:23 + Gerrit-HasComments: Yes
[kudu-CR] util: remove duplicate results from DNS resolution
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15665 ) Change subject: util: remove duplicate results from DNS resolution .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15665/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15665/1//COMMIT_MSG@13 PS1, Line 13: $ kudu table list localhost : W0404 20:35:05.511526 31378 client-internal.cc:597] Specified master : server address 'localhost' resolved to multiple IPs. Using : 127.0.0.1:7051 I've definitely seen this before and always wondered what caused it. Is it due to poor DNS configuration? A bug in glibc? Something else entirely? -- To view, visit http://gerrit.cloudera.org:8080/15665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d9b9f9839a899d8022f5ac6496555ff84583192 Gerrit-Change-Number: 15665 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 06 Apr 2020 22:49:08 + Gerrit-HasComments: Yes
[kudu-CR] util: remove duplicate results from DNS resolution
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15665 to review the following change. Change subject: util: remove duplicate results from DNS resolution .. util: remove duplicate results from DNS resolution On some systems it seems that our DNS resolution code can end up yielding multiple copies of the same address. That would produce annoying log messages like: $ kudu table list localhost W0404 20:35:05.511526 31378 client-internal.cc:597] Specified master server address 'localhost' resolved to multiple IPs. Using 127.0.0.1:7051 This patch ensures that any given address is only appended to the result vector once. Change-Id: I7d9b9f9839a899d8022f5ac6496555ff84583192 --- M src/kudu/util/net/net_util.cc 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/15665/1 -- To view, visit http://gerrit.cloudera.org:8080/15665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7d9b9f9839a899d8022f5ac6496555ff84583192 Gerrit-Change-Number: 15665 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin