[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d
David Ribeiro Alves has posted comments on this change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I077b98ece1bc4e0bdad9957d54df3259e928e19b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d
David Ribeiro Alves has submitted this change and it was merged. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d Fixes up the includes in zlib.h in response to a late review by Alexey. Change-Id: I077b98ece1bc4e0bdad9957d54df3259e928e19b Reviewed-on: http://gerrit.cloudera.org:8080/4293 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin Reviewed-by: David Ribeiro Alves --- M src/kudu/util/zlib.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: David Ribeiro Alves: Looks good to me, approved Alexey Serbin: Looks good to me, but someone else must approve Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/4293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I077b98ece1bc4e0bdad9957d54df3259e928e19b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d
Alexey Serbin has posted comments on this change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I077b98ece1bc4e0bdad9957d54df3259e928e19b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d
Kudu Jenkins has posted comments on this change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/3199/ -- To view, visit http://gerrit.cloudera.org:8080/4293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I077b98ece1bc4e0bdad9957d54df3259e928e19b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d
Kudu Jenkins has posted comments on this change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/3193/ -- To view, visit http://gerrit.cloudera.org:8080/4293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I077b98ece1bc4e0bdad9957d54df3259e928e19b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4293 to review the following change. Change subject: zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d .. zlib: trivial follow-up to 8a4bb33c3d54775ff8520b97e18b3fc94021185d Fixes up the includes in zlib.h in response to a late review by Alexey. Change-Id: I077b98ece1bc4e0bdad9957d54df3259e928e19b --- M src/kudu/util/zlib.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/4293/1 -- To view, visit http://gerrit.cloudera.org:8080/4293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I077b98ece1bc4e0bdad9957d54df3259e928e19b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin