[kudu-CR] increase table locations-itest timeout

2016-06-02 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3287 to review the following change. Change subject: increase table_locations-itest timeout .. increase

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-02 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#6). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-02 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 4: (8 comments)

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-02 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#5). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-02 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#7). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions

[kudu-CR](gh-pages) No default partitioning blog post

2016-06-03 Thread Dan Burkert (Code Review)
Hello Misty Stanley-Jones, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3277 to look at the new patch set (#5). Change subject: No default partitioning blog post .. No default

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3303 to review the following change. Change subject: Update Java client for new master GetTableLocations semantics

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 1: This change will cause a 1.0 Java client to misinterpret an empty GetTableLocations

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Fix a race in TabletClient cleanup .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait

2016-06-07 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3329 to look at the new patch set (#3). Change subject: [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait

[kudu-CR] update dist-test configuration for new client.py location

2016-06-07 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3332 to review the following change. Change subject: update dist-test configuration for new client.py location

[kudu-CR] [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait

2016-06-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait .. Patch Set 1: (1 comment)

[kudu-CR] update dist-test configuration for new client.py location

2016-06-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3332 to look at the new patch set (#3). Change subject: update dist-test configuration for new client.py location ..

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-07 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 9: (1 comment)

[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation

2016-06-07 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. [java-client] RPC timeout may sometimes be reported as max attempts

[kudu-CR] [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait

2016-06-07 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3329 to review the following change. Change subject: [java-client] disconnect all tablets in TestAsyncKuduSession.disconnectAndWait

[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation

2016-06-07 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation .. [java-client] RPC timeout may sometimes be reported as max attempts violation

[kudu-CR] [java-client] RPC timeout may sometimes be reported as max attempts violation

2016-06-07 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3330 to look at the new patch set (#3). Change subject: [java-client] RPC timeout may sometimes be reported as max attempts violation

[kudu-CR](gh-pages) Add weekly update for 06/06

2016-06-06 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add weekly update for 06/06 .. Add weekly update for 06/06 Change-Id: I6814ef94ab522da5d1224fc5d86f975c3978c062 Reviewed-on:

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 1: I think this may be a breaking change. Still thinking about how to do it backwards

[kudu-CR] Remove default table partitioning

2016-05-25 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#10). Change subject: Remove default table partitioning .. Remove default table

[kudu-CR] Remove default table partitioning

2016-05-25 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#11). Change subject: Remove default table partitioning .. Remove default table

[kudu-CR] Reduce verbosity of Java logs

2016-05-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Reduce verbosity of Java logs .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3203/1/java/kudu-client/src/test/resources/log4j.properties File

[kudu-CR] python: add support for specifying partitioning

2016-05-25 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: python: add support for specifying partitioning .. python: add support for specifying partitioning This adds support for range and hash partitioning when

[kudu-CR] Reduce verbosity of Java logs

2016-05-25 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3203 to look at the new patch set (#2). Change subject: Reduce verbosity of Java logs .. Reduce verbosity of Java logs

[kudu-CR](branch-0.9.x) python: add support for specifying partitioning

2016-05-25 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/3218 Change subject: python: add support for specifying partitioning .. python: add support for specifying partitioning This adds support for

[kudu-CR] python: add support for specifying partitioning

2016-05-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: python: add support for specifying partitioning .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3196 To unsubscribe, visit

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 1: (1 comment) Updated to make the similar change for the locate tablets codepath,

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-14 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3303 to look at the new patch set (#2). Change subject: Update Java client for new master GetTableLocations semantics ..

[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges

2016-06-15 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3388 to review the following change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges

[kudu-CR] [java client] fix reruns of TestKuduTable.testGetLocations

2016-06-06 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] fix reruns of TestKuduTable.testGetLocations .. Patch Set 2: (1 comment) LGTM, just the small nit.

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-31 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2806 to look at the new patch set (#12). Change subject: KUDU-1307 [master] support tables with range partition bounds

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1307 [master] support tables with range partition bounds .. Patch Set 11: (1 comment)

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Specify guaranteed semantics of GetTableLocations RPC .. Patch Set 1: actually it's missing tests for a few of the guarantees, I'll add specific tests for those.

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: KUDU-1307 [master] support tables with range partition bounds .. KUDU-1307 [master] support tables with range partition bounds This commit adds support

[kudu-CR] fix compile error when compiling column_predicate-test.cc

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: fix compile error when compiling column_predicate-test.cc .. Patch Set 8: Hi Bruce, This issue looks like a bug in Boost versions 1.56 and 1.57:

[kudu-CR] Kudu 0.9.0 release notes edit

2016-05-31 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3176 to look at the new patch set (#5). Change subject: Kudu 0.9.0 release notes edit .. Kudu 0.9.0 release notes edit

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark .. Patch Set 3: LGTM with the caveat of updating the comment per Todd's suggestion.  I think it's worth rushing this

[kudu-CR] Replace uses of boost::thread with std::thread

2016-05-31 Thread Dan Burkert (Code Review)
Hello Internal Jenkins, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1868 to look at the new patch set (#13). Change subject: Replace uses of boost::thread with std::thread

[kudu-CR] Fix license issues

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Fix license issues .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3254 To unsubscribe, visit

[kudu-CR] Replace uses of boost::thread with std::thread

2016-05-31 Thread Dan Burkert (Code Review)
Hello Internal Jenkins, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/1868 to look at the new patch set (#14). Change subject: Replace uses of boost::thread with std::thread

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-05-31 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3255 to review the following change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions

[kudu-CR] Reduce verbosity of Java logs

2016-05-26 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3203 to look at the new patch set (#3). Change subject: Reduce verbosity of Java logs .. Reduce verbosity of Java logs

[kudu-CR] Remove default table partitioning

2016-05-26 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#12). Change subject: Remove default table partitioning .. Remove default table

[kudu-CR] Remove default table partitioning

2016-05-26 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#13). Change subject: Remove default table partitioning .. Remove default table

[kudu-CR] Remove default table partitioning

2016-05-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Remove default table partitioning .. Patch Set 9: (2 comments)

[kudu-CR] Remove default table partitioning

2016-05-26 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#15). Change subject: Remove default table partitioning .. Remove default table

[kudu-CR] Remove default table partitioning

2016-05-26 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#16). Change subject: Remove default table partitioning .. Remove default table

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1307 [master] support tables with range partition bounds .. Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/2806/10//COMMIT_MSG Commit

[kudu-CR] KUDU-1307 [master] support tables with range partition bounds

2016-05-27 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2806 to look at the new patch set (#11). Change subject: KUDU-1307 [master] support tables with range partition bounds

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-05-31 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#2). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions

[kudu-CR](gh-pages) No default partitioning blog post

2016-06-02 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#4). Change subject: No default partitioning blog post .. No default partitioning blog post Change-Id: I14ace416b3eb5b61bb522a388e564be2e7dce3a9 --- A

[kudu-CR] Remove default table partitioning

2016-05-26 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3131 to look at the new patch set (#17). Change subject: Remove default table partitioning .. Remove default table

[kudu-CR] Remove default table partitioning

2016-05-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Remove default table partitioning .. Patch Set 15: (1 comment) http://gerrit.cloudera.org:8080/#/c/3131/15/docs/schema_design.adoc File docs/schema_design.adoc:

[kudu-CR](branch-0.9.x) Remove default table partitioning

2016-05-26 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/3229 Change subject: Remove default table partitioning .. Remove default table partitioning This commit removes the current default of

[kudu-CR] Document advice about max columns and record size

2016-05-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Document advice about max columns and record size .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2778 To unsubscribe, visit

[kudu-CR] Non-covering Range Partitions design doc

2016-05-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Non-covering Range Partitions design doc .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2772 To unsubscribe, visit

[kudu-CR] Kudu 0.9.0 release notes edit

2016-05-26 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3176 to look at the new patch set (#4). Change subject: Kudu 0.9.0 release notes edit .. Kudu 0.9.0 release notes edit

[kudu-CR] Add TableCreator::add_range_split and deprecate TableCreator::split_rows

2016-06-01 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3275 to look at the new patch set (#2). Change subject: Add TableCreator::add_range_split and deprecate TableCreator::split_rows

[kudu-CR](gh-pages) No default partitioning blog post

2016-06-01 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Misty Stanley-Jones, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3277 to review the following change. Change subject: No default partitioning blog post

[kudu-CR] Replace kudu::{lock_guard, unique_lock} with std lib equivalents

2016-06-01 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3271 to look at the new patch set (#2). Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents

[kudu-CR] Replace boost::{lock, unique_lock, mutex} with std lib equivalents

2016-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Replace boost::{lock, unique_lock, mutex} with std lib equivalents .. Patch Set 2: (3 comments) It wasn't a straight find/replace because I did a lot of import

[kudu-CR] Replace boost::{lock, unique_lock, mutex} with std lib equivalents

2016-06-01 Thread Dan Burkert (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3262 to look at the new patch set (#3). Change subject: Replace boost::{lock, unique_lock, mutex} with std lib equivalents

[kudu-CR] Replace kudu::{lock_guard, unique_lock} with std lib equivalents

2016-06-01 Thread Dan Burkert (Code Review)
Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3271 to review the following change. Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents

[kudu-CR] Replace boost::{lock, unique_lock, mutex} with std lib equivalents

2016-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Replace boost::{lock, unique_lock, mutex} with std lib equivalents .. Patch Set 3: (2 comments)

[kudu-CR] Replace boost::{lock, unique_lock, mutex} with std lib equivalents

2016-06-01 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3262 to look at the new patch set (#4). Change subject: Replace boost::{lock, unique_lock, mutex} with std lib equivalents

[kudu-CR] Replace kudu::{lock_guard, unique_lock} with std lib equivalents

2016-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents .. Patch Set 5: We already have quite a few std::lock_guard instances in the codebase (mostly

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

2016-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3243 To unsubscribe, visit

[kudu-CR] Replace kudu::{lock_guard, unique_lock} with std lib equivalents

2016-06-01 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3271 to look at the new patch set (#6). Change subject: Replace kudu::{lock_guard, unique_lock} with std lib equivalents

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-01 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3255 to look at the new patch set (#3). Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions

[kudu-CR] Add TableCreator::add_range_split and deprecate TableCreator::split_rows

2016-06-01 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3275 to review the following change. Change subject: Add TableCreator::add_range_split and deprecate TableCreator::split_rows

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 2: (1 comment)

[kudu-CR](gh-pages) No default partitioning blog post

2016-06-01 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: No default partitioning blog post .. No default partitioning blog post Change-Id: I14ace416b3eb5b61bb522a388e564be2e7dce3a9 --- A

[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1470 Exceptions on getting a column value should return the column name not the column number .. Patch Set 3: Code-Review+2 Looks good, I'm retrying the

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 2: (1 comment) The changes I made today have been made significantly simpler by

[kudu-CR] [java-client] use tablet cache for locateTablet calls

2016-06-14 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new change for review. http://gerrit.cloudera.org:8080/3386 Change subject: [java-client] use tablet cache for locateTablet calls .. [java-client] use tablet cache for locateTablet calls This

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-14 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3303 to look at the new patch set (#3). Change subject: Update Java client for new master GetTableLocations semantics ..

[kudu-CR] [java-client] use tablet cache for locateTablet calls

2016-06-17 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3386 to look at the new patch set (#5). Change subject: [java-client] use tablet cache for locateTablet calls

[kudu-CR] Add required Debian version to installation page

2016-06-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add required Debian version to installation page .. Patch Set 1: I thought you had? Debian is mentioned along with Ubuntu everywhere in the docs, except in the

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-15 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3303 to look at the new patch set (#4). Change subject: Update Java client for new master GetTableLocations semantics ..

[kudu-CR] [java-client] use tablet cache for locateTablet calls

2016-06-15 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3386 to look at the new patch set (#2). Change subject: [java-client] use tablet cache for locateTablet calls ..

[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges

2016-06-15 Thread Dan Burkert (Code Review)
Dan Burkert has uploaded a new patch set (#2). Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. KUDU-1309: [java client] support tables with non-covering partition-key ranges

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 4: (2 comments)

[kudu-CR] Add required Debian version to installation page

2016-06-15 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3389 to review the following change. Change subject: Add required Debian version to installation page ..

[kudu-CR] Add required Debian version to installation page

2016-06-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add required Debian version to installation page .. Patch Set 1: Ah, so we should probably hold of on this till we can verify that it works. Or we should remove

[kudu-CR] [java-client] use tablet cache for locateTablet calls

2016-06-16 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3386 to look at the new patch set (#3). Change subject: [java-client] use tablet cache for locateTablet calls

[kudu-CR] [java-client] use tablet cache for locateTablet calls

2016-06-16 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] use tablet cache for locateTablet calls .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3386/2//COMMIT_MSG Commit Message: PS2,

[kudu-CR] Add required Debian version to installation page

2016-06-24 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add required Debian version to installation page .. Add required Debian version to installation page Change-Id: I65cef323648d7934cb140046cf391d56867eeb56

[kudu-CR] Add required Debian version to installation page

2016-06-23 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add required Debian version to installation page .. Patch Set 1: -Code-Review JD, are you ok with pushing this now with your recent deb 8 testing? -- To view,

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-23 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3477 to review the following change. Change subject: [java-client] refactor AsyncKuduSession ..

[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges

2016-06-23 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3388 to look at the new patch set (#3). Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3500 To unsubscribe, visit

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3516 To unsubscribe, visit

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: (1 comment)

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: locks: switch from boost::shared_mutex to new read-write mutex .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3499 To

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3497 To unsubscribe,

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 2: Code-Review+1 LGTM except for Todd's comment -- To view, visit

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 1: (5 comments) I'm +1 on moving boost into thirdparty. I like that it removes complexity

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc File src/kudu/util/rw_mutex.cc:

  1   2   >