[kudu-CR](branch-0.9.x) KUDU-1469. Fix handling of fully-deduped requests after a leader change
Todd Lipcon has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR](branch-0.9.x) KUDU-1469. Fix handling of fully-deduped requests after a leader change
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. KUDU-1469. Fix handling of fully-deduped requests after a leader change This fixes KUDU-1469, a bug in which the leader and follower could get into a tight loop of RPCs making no progress replicating operations. The newly included test fails without the bug fix, and passes with it. See its comments for details on the bug itself. Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Reviewed-on: http://gerrit.cloudera.org:8080/3228 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves Reviewed-by: Mike Percy (cherry picked from commit d685747426472d428b1d071df00d112d9f775117) Reviewed-on: http://gerrit.cloudera.org:8080/3455 Reviewed-by: Todd Lipcon --- M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/raft_consensus-test.cc M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus_state.cc M src/kudu/consensus/raft_consensus_state.h M src/kudu/integration-tests/raft_consensus-itest.cc 8 files changed, 158 insertions(+), 24 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR](branch-0.9.x) KUDU-1469. Fix handling of fully-deduped requests after a leader change
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1950/ -- To view, visit http://gerrit.cloudera.org:8080/3455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](branch-0.9.x) KUDU-1469. Fix handling of fully-deduped requests after a leader change
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3455 Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. KUDU-1469. Fix handling of fully-deduped requests after a leader change This fixes KUDU-1469, a bug in which the leader and follower could get into a tight loop of RPCs making no progress replicating operations. The newly included test fails without the bug fix, and passes with it. See its comments for details on the bug itself. Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Reviewed-on: http://gerrit.cloudera.org:8080/3228 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves Reviewed-by: Mike Percy (cherry picked from commit d685747426472d428b1d071df00d112d9f775117) --- M src/kudu/consensus/consensus.proto M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/log_cache.cc M src/kudu/consensus/raft_consensus-test.cc M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus_state.cc M src/kudu/consensus/raft_consensus_state.h M src/kudu/integration-tests/raft_consensus-itest.cc 8 files changed, 158 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/3455/1 -- To view, visit http://gerrit.cloudera.org:8080/3455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon
[kudu-CR](branch-0.9.x) KUDU-1469. Fix handling of fully-deduped requests after a leader change
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1940/ -- To view, visit http://gerrit.cloudera.org:8080/3455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iced21ae1b69c1079efc9aa9cf23e2fa592b8bebd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No