[kudu-CR](branch-0.9.x) catalog manager: fix a locking error

2016-06-22 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged.

Change subject: catalog_manager: fix a locking error
..


catalog_manager: fix a locking error

This lock acquisition took the wrong lock, which meant it didn't add any
protection against table/tablet visition races at all.

See commit 1681d9a for context.

Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Reviewed-on: http://gerrit.cloudera.org:8080/3425
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
(cherry picked from commit 5f7d79910d8da492195b5c22a6d9a7911f950107)
Reviewed-on: http://gerrit.cloudera.org:8080/3461
Tested-by: Adar Dembo 
---
M src/kudu/master/catalog_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Adar Dembo: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: branch-0.9.x
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 


[kudu-CR](branch-0.9.x) catalog manager: fix a locking error

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change.

Change subject: catalog_manager: fix a locking error
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-0.9.x
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-HasComments: No


[kudu-CR](branch-0.9.x) catalog manager: fix a locking error

2016-06-22 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: catalog_manager: fix a locking error
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/1952/

-- 
To view, visit http://gerrit.cloudera.org:8080/3461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-0.9.x
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No


[kudu-CR](branch-0.9.x) catalog manager: fix a locking error

2016-06-22 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Kudu Jenkins,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3461

to review the following change.

Change subject: catalog_manager: fix a locking error
..

catalog_manager: fix a locking error

This lock acquisition took the wrong lock, which meant it didn't add any
protection against table/tablet visition races at all.

See commit 1681d9a for context.

Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Reviewed-on: http://gerrit.cloudera.org:8080/3425
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
(cherry picked from commit 5f7d79910d8da492195b5c22a6d9a7911f950107)
---
M src/kudu/master/catalog_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/3461/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-0.9.x
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR](branch-0.9.x) catalog manager: fix a locking error

2016-06-22 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: catalog_manager: fix a locking error
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1947/

-- 
To view, visit http://gerrit.cloudera.org:8080/3461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-0.9.x
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No